Browse Source

mysql: fix interpolation for numbers in temp vars

Daniel Lee 8 years ago
parent
commit
002b4d3403

+ 8 - 0
public/app/plugins/datasource/mysql/datasource.ts

@@ -20,7 +20,15 @@ export class MysqlDatasource {
       return '\'' + value + '\'';
     }
 
+    if (typeof value === 'number') {
+      return value;
+    }
+
     var quotedValues = _.map(value, function(val) {
+      if (typeof value === 'number') {
+        return value;
+      }
+
       return '\'' + val + '\'';
     });
     return  quotedValues.join(',');

+ 20 - 0
public/app/plugins/datasource/mysql/specs/datasource_specs.ts

@@ -193,4 +193,24 @@ describe('MySQLDatasource', function() {
       expect(results[0].value).to.be('same');
     });
   });
+
+  describe('When interpolating variables', () => {
+    describe('and value is a string', () => {
+      it('should return a quoted value', () => {
+        expect(ctx.ds.interpolateVariable('abc')).to.eql('\'abc\'');
+      });
+    });
+
+    describe('and value is a number', () => {
+      it('should return an unquoted value', () => {
+        expect(ctx.ds.interpolateVariable(1000)).to.eql(1000);
+      });
+    });
+
+    describe('and value is an array of strings', () => {
+      it('should return comma separated quoted values', () => {
+        expect(ctx.ds.interpolateVariable(['a', 'b', 'c'])).to.eql('\'a\',\'b\',\'c\'');
+      });
+    });
+  });
 });