Prechádzať zdrojové kódy

Move function calls w/ side-effects to componentDidMount

* loadStore() modified the url which triggered a new render path, this
gets noticed by react. Moved to componentDidMount.
David Kaltschmidt 7 rokov pred
rodič
commit
0695e431ea

+ 3 - 0
public/app/containers/ManageDashboards/FolderPermissions.tsx

@@ -16,6 +16,9 @@ export class FolderPermissions extends Component<IContainerProps, any> {
   constructor(props) {
     super(props);
     this.handleAddPermission = this.handleAddPermission.bind(this);
+  }
+
+  componentDidMount() {
     this.loadStore();
   }
 

+ 1 - 2
public/app/containers/ManageDashboards/FolderSettings.tsx

@@ -12,8 +12,7 @@ import appEvents from 'app/core/app_events';
 export class FolderSettings extends React.Component<IContainerProps, any> {
   formSnapshot: any;
 
-  constructor(props) {
-    super(props);
+  componentDidMount() {
     this.loadStore();
   }