use template variable prop

public/app/plugins/datasource/stackdriver/components/AggregationPicker.tsx → public/app/plugins/datasource/stackdriver/components/Aggregations.tsx

@@ -27,7 +27,7 @@ interface State {
   aggOptions: any[];
 }
 
-export class AggregationPicker extends React.Component<Props, State> {
+export class Aggregations extends React.Component<Props, State> {
   state: State = {
     alignmentPeriods: [],
     alignOptions: [],
@@ -86,7 +86,7 @@ export class AggregationPicker extends React.Component<Props, State> {
 
   render() {
     const { aggOptions } = this.state;
-    const { aggregation } = this.props;
+    const { aggregation, templateSrv } = this.props;
 
     return (
       <React.Fragment>
@@ -96,6 +96,7 @@ export class AggregationPicker extends React.Component<Props, State> {
             <StackdriverPicker
               onChange={value => this.handleAggregationChange(value)}
               selected={aggregation.crossSeriesReducer}
+              templateVariables={templateSrv.variables}
               options={aggOptions}
               searchable={true}
               placeholder="Select Aggregation"

public/app/plugins/datasource/stackdriver/components/MetricPicker.tsx → public/app/plugins/datasource/stackdriver/components/Metrics.tsx

@@ -19,7 +19,7 @@ interface State {
   metric: string;
 }
 
-export class MetricPicker extends React.Component<Props, State> {
+export class Metrics extends React.Component<Props, State> {
   state: State = {
     metricDescriptors: [],
     metrics: [],
@@ -36,7 +36,6 @@ export class MetricPicker extends React.Component<Props, State> {
     this.getCurrentProject()
       .then(this.loadMetricDescriptors.bind(this))
       .then(this.initializeServiceAndMetrics.bind(this));
-    // .then(this.getLabels.bind(this));
   }
 
   async getCurrentProject() {
@@ -86,7 +85,6 @@ export class MetricPicker extends React.Component<Props, State> {
   }
 
   handleServiceChange(service) {
-    console.log('handleServiceChange', service);
     const { metricDescriptors } = this.state;
     const { templateSrv, metricType } = this.props;
 
@@ -128,19 +126,9 @@ export class MetricPicker extends React.Component<Props, State> {
     };
   }
 
-  getMetricGroups() {
-    return [
-      this.getTemplateVariablesGroup(),
-      {
-        label: 'Metrics',
-        options: this.state.metrics,
-      },
-    ];
-  }
-
   render() {
-    const { services, service } = this.state;
-    const { metricType } = this.props;
+    const { services, service, metrics } = this.state;
+    const { metricType, templateSrv } = this.props;
 
     return (
       <React.Fragment>
@@ -166,10 +154,12 @@ export class MetricPicker extends React.Component<Props, State> {
             <StackdriverPicker
               onChange={value => this.handleMetricTypeChange(value)}
               selected={metricType}
-              options={this.getMetricGroups()}
+              templateVariables={templateSrv.variables}
+              options={metrics}
               searchable={true}
               placeholder="Select Metric"
               className="width-15"
+              groupName="Metric Types"
             />
           </div>
           <div className="gf-form gf-form--grow">

public/app/plugins/datasource/stackdriver/components/QueryEditor.tsx

@@ -2,9 +2,9 @@ import React from 'react';
 import _ from 'lodash';
 import appEvents from 'app/core/app_events';
 
-import { MetricPicker } from './MetricPicker';
+import { Metrics } from './Metrics';
 import { Filter } from './Filter';
-import { AggregationPicker } from './AggregationPicker';
+import { Aggregations } from './Aggregations';
 import { Target, QueryMeta } from '../types';
 
 export interface Props {
@@ -124,7 +124,7 @@ export class QueryEditor extends React.Component<Props, State> {
 
     return (
       <React.Fragment>
-        <MetricPicker
+        <Metrics
           defaultProject={defaultProject}
           metricType={metricType}
           templateSrv={templateSrv}
@@ -140,7 +140,7 @@ export class QueryEditor extends React.Component<Props, State> {
           templateSrv={templateSrv}
           loading={loadLabelsPromise}
         />
-        <AggregationPicker
+        <Aggregations
           valueType={valueType}
           metricKind={metricKind}
           templateSrv={templateSrv}

public/app/plugins/datasource/stackdriver/query_filter_ctrl2.ts

@@ -1,330 +0,0 @@
-// import coreModule from 'app/core/core_module';
-// import _ from 'lodash';
-// import { FilterSegments } from './filter_segments';
-// import appEvents from 'app/core/app_events';
-
-// export class StackdriverFilter {
-//   /** @ngInject */
-//   constructor() {
-//     return {
-//       templateUrl: 'public/app/plugins/datasource/stackdriver/partials/query.filter.html',
-//       controller: 'StackdriverFilterCtrl',
-//       controllerAs: 'ctrl',
-//       restrict: 'E',
-//       scope: {
-//         target: '=',
-//         datasource: '=',
-//         refresh: '&',
-//         hideGroupBys: '<',
-//       },
-//     };
-//   }
-// }
-
-// export class StackdriverFilterCtrl {
-//   metricLabels: { [key: string]: string[] };
-//   resourceLabels: { [key: string]: string[] };
-//   resourceTypes: string[];
-
-//   defaultRemoveGroupByValue = '-- remove group by --';
-//   resourceTypeValue = 'resource.type';
-//   loadLabelsPromise: Promise<any>;
-
-//   metricDescriptors: any[];
-//   metrics: any[];
-//   services: any[];
-//   groupBySegments: any[];
-//   filterSegments: FilterSegments;
-//   removeSegment: any;
-//   target: any;
-//   datasource: any;
-
-//   /** @ngInject */
-//   constructor(private $scope, private uiSegmentSrv, private templateSrv, private $rootScope) {
-//     this.datasource = $scope.datasource;
-//     this.target = $scope.target;
-//     this.metricDescriptors = [];
-//     this.metrics = [];
-//     this.services = [];
-
-//     this.getCurrentProject()
-//       .then(this.loadMetricDescriptors.bind(this))
-//       .then(this.getLabels.bind(this));
-
-//     this.initSegments($scope.hideGroupBys);
-//     this.handleMetricTypeChange = this.handleMetricTypeChange.bind(this);
-//     this.handleServiceChange = this.handleServiceChange.bind(this);
-//   }
-
-//   handleMetricTypeChange(value) {
-//     this.target.metricType = value;
-//     this.setMetricType();
-//     this.$scope.refresh();
-//     this.getLabels();
-//   }
-
-//   initSegments(hideGroupBys: boolean) {
-//     if (!hideGroupBys) {
-//       this.groupBySegments = this.target.aggregation.groupBys.map(groupBy => {
-//         return this.uiSegmentSrv.getSegmentForValue(groupBy);
-//       });
-//       this.ensurePlusButton(this.groupBySegments);
-//     }
-
-//     this.removeSegment = this.uiSegmentSrv.newSegment({ fake: true, value: '-- remove group by --' });
-
-//     this.filterSegments = new FilterSegments(
-//       this.uiSegmentSrv,
-//       this.target,
-//       this.getFilterKeys.bind(this),
-//       this.getFilterValues.bind(this)
-//     );
-//     this.filterSegments.buildSegmentModel();
-//   }
-
-//   async getCurrentProject() {
-//     return new Promise(async (resolve, reject) => {
-//       try {
-//         if (!this.target.defaultProject || this.target.defaultProject === 'loading project...') {
-//           this.target.defaultProject = await this.datasource.getDefaultProject();
-//         }
-//         resolve(this.target.defaultProject);
-//       } catch (error) {
-//         appEvents.emit('ds-request-error', error);
-//         reject();
-//       }
-//     });
-//   }
-
-//   async loadMetricDescriptors() {
-//     if (this.target.defaultProject !== 'loading project...') {
-//       this.metricDescriptors = await this.datasource.getMetricTypes(this.target.defaultProject);
-//       this.services = this.getServicesList();
-//       this.metrics = this.getMetricsList();
-//       return this.metricDescriptors;
-//     } else {
-//       return [];
-//     }
-//   }
-
-//   getServicesList() {
-//     const services = this.metricDescriptors.map(m => ({
-//       value: m.service,
-//       label: _.startCase(m.serviceShortName),
-//     }));
-
-//     return services.length > 0 ? _.uniqBy(services, s => s.value) : [];
-//   }
-
-//   getMetricGroups() {
-//     return [
-//       this.getTemplateVariablesGroup(),
-//       {
-//         label: 'Metrics',
-//         options: this.getMetricsList(),
-//       },
-//     ];
-//   }
-
-//   getTemplateVariablesGroup() {
-//     return {
-//       label: 'Template Variables',
-//       options: this.templateSrv.variables.map(v => ({
-//         label: `$${v.name}`,
-//         value: `$${v.name}`,
-//       })),
-//     };
-//   }
-
-//   getMetricsList() {
-//     const metricsByService = this.metricDescriptors.filter(m => m.service === this.target.service).map(m => ({
-//       service: m.service,
-//       value: m.type,
-//       label: m.displayName,
-//       description: m.description,
-//     }));
-
-//     if (
-//       metricsByService.length > 0 &&
-//       !metricsByService.some(m => m.value === this.templateSrv.replace(this.target.metricType))
-//     ) {
-//       // this.target.metricType = metricsByService[0].value;
-//     }
-//     return metricsByService;
-//   }
-
-//   async getLabels() {
-//     this.loadLabelsPromise = new Promise(async resolve => {
-//       try {
-//         if (this.target.metricType) {
-//           const { meta } = await this.datasource.getLabels(this.target.metricType, this.target.refId);
-//           this.metricLabels = meta.metricLabels;
-//           this.resourceLabels = meta.resourceLabels;
-//           this.resourceTypes = meta.resourceTypes;
-//           resolve();
-//         } else {
-//           resolve();
-//         }
-//       } catch (error) {
-//         if (error.data && error.data.message) {
-//           console.log(error.data.message);
-//         } else {
-//           console.log(error);
-//         }
-//         appEvents.emit('alert-error', ['Error', 'Error loading metric labels for ' + this.target.metricType]);
-//         resolve();
-//       }
-//     });
-//   }
-
-//   handleServiceChange(service) {
-//     this.target.service = service;
-//     this.metrics = this.getMetricsList();
-//     this.setMetricType();
-//     this.getLabels();
-//     if (!this.metrics.some(m => m.value === this.target.metricType)) {
-//       this.target.metricType = '';
-//     } else {
-//       this.$scope.refresh();
-//     }
-//   }
-
-//   setMetricType() {
-//     const { valueType, metricKind, unit } = this.metricDescriptors.find(
-//       m => m.type === this.templateSrv.replace(this.target.metricType)
-//     );
-//     this.target.unit = unit;
-//     this.target.valueType = valueType;
-//     this.target.metricKind = metricKind;
-//     this.$rootScope.$broadcast('metricTypeChanged');
-//   }
-
-//   async createLabelKeyElements() {
-//     await this.loadLabelsPromise;
-
-//     let elements = Object.keys(this.metricLabels || {}).map(l => {
-//       return this.uiSegmentSrv.newSegment({
-//         value: `metric.label.${l}`,
-//         expandable: false,
-//       });
-//     });
-
-//     elements = [
-//       ...elements,
-//       ...Object.keys(this.resourceLabels || {}).map(l => {
-//         return this.uiSegmentSrv.newSegment({
-//           value: `resource.label.${l}`,
-//           expandable: false,
-//         });
-//       }),
-//     ];
-
-//     if (this.resourceTypes && this.resourceTypes.length > 0) {
-//       elements = [
-//         ...elements,
-//         this.uiSegmentSrv.newSegment({
-//           value: this.resourceTypeValue,
-//           expandable: false,
-//         }),
-//       ];
-//     }
-
-//     return elements;
-//   }
-
-//   async getFilterKeys(segment, removeText?: string) {
-//     let elements = await this.createLabelKeyElements();
-
-//     if (this.target.filters.indexOf(this.resourceTypeValue) !== -1) {
-//       elements = elements.filter(e => e.value !== this.resourceTypeValue);
-//     }
-
-//     const noValueOrPlusButton = !segment || segment.type === 'plus-button';
-//     if (noValueOrPlusButton && elements.length === 0) {
-//       return [];
-//     }
-
-//     return [
-//       ...elements,
-//       this.uiSegmentSrv.newSegment({ fake: true, value: removeText || this.defaultRemoveGroupByValue }),
-//     ];
-//   }
-
-//   async getGroupBys(segment) {
-//     let elements = await this.createLabelKeyElements();
-
-//     elements = elements.filter(e => this.target.aggregation.groupBys.indexOf(e.value) === -1);
-//     const noValueOrPlusButton = !segment || segment.type === 'plus-button';
-//     if (noValueOrPlusButton && elements.length === 0) {
-//       return [];
-//     }
-
-//     this.removeSegment.value = this.defaultRemoveGroupByValue;
-//     return [...elements, this.removeSegment];
-//   }
-
-//   groupByChanged(segment, index) {
-//     if (segment.value === this.removeSegment.value) {
-//       this.groupBySegments.splice(index, 1);
-//     } else {
-//       segment.type = 'value';
-//     }
-
-//     const reducer = (memo, seg) => {
-//       if (!seg.fake) {
-//         memo.push(seg.value);
-//       }
-//       return memo;
-//     };
-
-//     this.target.aggregation.groupBys = this.groupBySegments.reduce(reducer, []);
-//     this.ensurePlusButton(this.groupBySegments);
-//     this.$rootScope.$broadcast('metricTypeChanged');
-//     this.$scope.refresh();
-//   }
-
-//   async getFilters(segment, index) {
-//     const hasNoFilterKeys = this.metricLabels && Object.keys(this.metricLabels).length === 0;
-//     return this.filterSegments.getFilters(segment, index, hasNoFilterKeys);
-//   }
-
-//   getFilterValues(index) {
-//     const filterKey = this.templateSrv.replace(this.filterSegments.filterSegments[index - 2].value);
-//     if (!filterKey || !this.metricLabels || Object.keys(this.metricLabels).length === 0) {
-//       return [];
-//     }
-
-//     const shortKey = filterKey.substring(filterKey.indexOf('.label.') + 7);
-
-//     if (filterKey.startsWith('metric.label.') && this.metricLabels.hasOwnProperty(shortKey)) {
-//       return this.metricLabels[shortKey];
-//     }
-
-//     if (filterKey.startsWith('resource.label.') && this.resourceLabels.hasOwnProperty(shortKey)) {
-//       return this.resourceLabels[shortKey];
-//     }
-
-//     if (filterKey === this.resourceTypeValue) {
-//       return this.resourceTypes;
-//     }
-
-//     return [];
-//   }
-
-//   filterSegmentUpdated(segment, index) {
-//     this.target.filters = this.filterSegments.filterSegmentUpdated(segment, index);
-//     this.$scope.refresh();
-//   }
-
-//   ensurePlusButton(segments) {
-//     const count = segments.length;
-//     const lastSegment = segments[Math.max(count - 1, 0)];
-
-//     if (!lastSegment || lastSegment.type !== 'plus-button') {
-//       segments.push(this.uiSegmentSrv.newPlusButton());
-//     }
-//   }
-// }
-
-// coreModule.directive('stackdriverFilter', StackdriverFilter);
-// coreModule.controller('StackdriverFilterCtrl', StackdriverFilterCtrl);