Browse Source

fix(metrics): restored prefix default to prod.grafana..

Torkel Ödegaard 9 years ago
parent
commit
093563ac37
4 changed files with 11 additions and 11 deletions
  1. 2 2
      conf/defaults.ini
  2. 5 5
      conf/sample.ini
  3. 1 1
      docs/sources/installation/configuration.md
  4. 3 3
      pkg/metrics/graphite_test.go

+ 2 - 2
conf/defaults.ini

@@ -350,13 +350,13 @@ global_session = -1
 # Metrics available at HTTP API Url /api/metrics
 # Metrics available at HTTP API Url /api/metrics
 [metrics]
 [metrics]
 enabled           = true
 enabled           = true
-interval_seconds  = 60
+interval_seconds  = 10
 
 
 # Send internal Grafana metrics to graphite
 # Send internal Grafana metrics to graphite
 [metrics.graphite]
 [metrics.graphite]
 # Enable by setting the address setting (ex localhost:2003)
 # Enable by setting the address setting (ex localhost:2003)
 address =
 address =
-prefix = service.grafana.%(instance_name)s.
+prefix = prod.grafana.%(instance_name)s.
 
 
 [grafana_net]
 [grafana_net]
 url = https://grafana.net
 url = https://grafana.net

+ 5 - 5
conf/sample.ini

@@ -297,18 +297,18 @@ check_for_updates = true
 # Metrics available at HTTP API Url /api/metrics
 # Metrics available at HTTP API Url /api/metrics
 [metrics]
 [metrics]
 # Disable / Enable internal metrics
 # Disable / Enable internal metrics
-enabled           = true
+;enabled           = true
 
 
 # Publish interval
 # Publish interval
-interval_seconds  = 10
+;interval_seconds  = 10
 
 
 # Send internal metrics to Graphite
 # Send internal metrics to Graphite
 [metrics.graphite]
 [metrics.graphite]
 # Enable by setting the address setting (ex localhost:2003)
 # Enable by setting the address setting (ex localhost:2003)
-address =
-prefix = service.grafana.%(instance_name)s.
+;address =
+;prefix = prod.grafana.%(instance_name)s.
 
 
 #################################### Internal Grafana Metrics ##########################
 #################################### Internal Grafana Metrics ##########################
 # Url used to to import dashboards directly from Grafana.net
 # Url used to to import dashboards directly from Grafana.net
 [grafana_net]
 [grafana_net]
-url = https://grafana.net
+;url = https://grafana.net

+ 1 - 1
docs/sources/installation/configuration.md

@@ -466,7 +466,7 @@ Enable metrics reporting. defaults true. Available via HTTP API `/api/metrics`.
 
 
 ### interval_seconds
 ### interval_seconds
 
 
-Flush/Write interval when sending metrics to external TSDB. Defaults to 60s.
+Flush/Write interval when sending metrics to external TSDB. Defaults to 10s.
 
 
 ## [metrics.graphite]
 ## [metrics.graphite]
 Include this section if you want to send internal Grafana metrics to Graphite.
 Include this section if you want to send internal Grafana metrics to Graphite.

+ 3 - 3
pkg/metrics/graphite_test.go

@@ -19,7 +19,7 @@ func TestGraphitePublisher(t *testing.T) {
 		So(err, ShouldBeNil)
 		So(err, ShouldBeNil)
 
 
 		sec, err := setting.Cfg.NewSection("metrics.graphite")
 		sec, err := setting.Cfg.NewSection("metrics.graphite")
-		sec.NewKey("prefix", "service.grafana.%(instance_name)s.")
+		sec.NewKey("prefix", "prod.grafana.%(instance_name)s.")
 		sec.NewKey("address", "localhost:2001")
 		sec.NewKey("address", "localhost:2001")
 
 
 		So(err, ShouldBeNil)
 		So(err, ShouldBeNil)
@@ -30,7 +30,7 @@ func TestGraphitePublisher(t *testing.T) {
 		So(err, ShouldBeNil)
 		So(err, ShouldBeNil)
 		So(publisher, ShouldNotBeNil)
 		So(publisher, ShouldNotBeNil)
 
 
-		So(publisher.prefix, ShouldEqual, "service.grafana.hostname_with_dots_com.")
+		So(publisher.prefix, ShouldEqual, "prod.grafana.hostname_with_dots_com.")
 		So(publisher.address, ShouldEqual, "localhost:2001")
 		So(publisher.address, ShouldEqual, "localhost:2001")
 	})
 	})
 
 
@@ -53,7 +53,7 @@ func TestGraphitePublisher(t *testing.T) {
 		So(err, ShouldBeNil)
 		So(err, ShouldBeNil)
 		So(publisher, ShouldNotBeNil)
 		So(publisher, ShouldNotBeNil)
 
 
-		So(publisher.prefix, ShouldEqual, "service.grafana.hostname_with_dots_com.")
+		So(publisher.prefix, ShouldEqual, "prod.grafana.hostname_with_dots_com.")
 		So(publisher.address, ShouldEqual, "localhost:2001")
 		So(publisher.address, ShouldEqual, "localhost:2001")
 	})
 	})