Explorar el Código

prevent explore from crashing when table is not present in response

Erik Sundell hace 7 años
padre
commit
18abd987bb
Se han modificado 2 ficheros con 6 adiciones y 11 borrados
  1. 2 3
      public/app/core/table_model.ts
  2. 4 8
      public/app/features/explore/Explore.tsx

+ 2 - 3
public/app/core/table_model.ts

@@ -86,11 +86,10 @@ export function mergeTablesIntoModel(dst?: TableModel, ...tables: TableModel[]):
   if (arguments.length === 1) {
   if (arguments.length === 1) {
     return model;
     return model;
   }
   }
-
   // Single query returns data columns and rows as is
   // Single query returns data columns and rows as is
   if (arguments.length === 2) {
   if (arguments.length === 2) {
-    model.columns = [...tables[0].columns];
-    model.rows = [...tables[0].rows];
+    model.columns = tables[0].hasOwnProperty('columns') ? [...tables[0].columns] : [];
+    model.rows = tables[0].hasOwnProperty('rows') ? [...tables[0].rows] : [];
     return model;
     return model;
   }
   }
 
 

+ 4 - 8
public/app/features/explore/Explore.tsx

@@ -784,14 +784,10 @@ export class Explore extends React.PureComponent<ExploreProps, ExploreState> {
 
 
     //Temp solution... How do detect if ds supports table format?
     //Temp solution... How do detect if ds supports table format?
     let tableResult;
     let tableResult;
-    try {
-      tableResult = mergeTablesIntoModel(
-        new TableModel(),
-        ...queryTransactions.filter(qt => qt.resultType === 'Table' && qt.done && qt.result).map(qt => qt.result)
-      );
-    } catch (error) {
-      console.log(error);
-    }
+    tableResult = mergeTablesIntoModel(
+      new TableModel(),
+      ...queryTransactions.filter(qt => qt.resultType === 'Table' && qt.done && qt.result).map(qt => qt.result)
+    );
     const logsResult =
     const logsResult =
       datasource && datasource.mergeStreams
       datasource && datasource.mergeStreams
         ? datasource.mergeStreams(
         ? datasource.mergeStreams(