Browse Source

teams: changed permission to permission type instead of int

Hugo Häggmark 7 years ago
parent
commit
246e128048
2 changed files with 3 additions and 3 deletions
  1. 1 1
      pkg/services/sqlstore/team.go
  2. 2 2
      pkg/services/sqlstore/team_test.go

+ 1 - 1
pkg/services/sqlstore/team.go

@@ -271,7 +271,7 @@ func UpdateTeamMember(cmd *m.UpdateTeamMemberCommand) error {
 			return m.ErrTeamMemberNotFound
 			return m.ErrTeamMemberNotFound
 		}
 		}
 
 
-		if cmd.Permission != int64(m.PERMISSION_ADMIN) {
+		if cmd.Permission != m.PERMISSION_ADMIN {
 			cmd.Permission = 0
 			cmd.Permission = 0
 		}
 		}
 
 

+ 2 - 2
pkg/services/sqlstore/team_test.go

@@ -114,12 +114,12 @@ func TestTeamCommandsAndQueries(t *testing.T) {
 				So(err, ShouldBeNil)
 				So(err, ShouldBeNil)
 				So(qBeforeUpdate.Result[0].Permission, ShouldEqual, 0)
 				So(qBeforeUpdate.Result[0].Permission, ShouldEqual, 0)
 
 
-				invalidPermissionLevel := 1337
+				invalidPermissionLevel := m.PERMISSION_EDIT
 				err = UpdateTeamMember(&m.UpdateTeamMemberCommand{
 				err = UpdateTeamMember(&m.UpdateTeamMemberCommand{
 					UserId:     userID,
 					UserId:     userID,
 					OrgId:      testOrgId,
 					OrgId:      testOrgId,
 					TeamId:     team.Id,
 					TeamId:     team.Id,
-					Permission: int64(invalidPermissionLevel),
+					Permission: invalidPermissionLevel,
 				})
 				})
 
 
 				So(err, ShouldBeNil)
 				So(err, ShouldBeNil)