Просмотр исходного кода

small code cleanup in grafanaGraph

Torkel Ödegaard 11 лет назад
Родитель
Сommit
347f6aed3f
2 измененных файлов с 19 добавлено и 6 удалено
  1. 3 1
      CHANGELOG.md
  2. 16 5
      src/app/directives/grafanaGraph.js

+ 3 - 1
CHANGELOG.md

@@ -1,7 +1,9 @@
 # vNext
 # vNext
 - More graphite functions
 - More graphite functions
 - Fix for Text panel, now changes take effect directly (Issue #251)
 - Fix for Text panel, now changes take effect directly (Issue #251)
-- Fix when adding functions without params that did not cause graph to update (issue #267)
+- Fix when adding functions without params that did not cause graph to update (Issue #267)
+- Graphite errors are now much easier to see and troubleshoot with the new inspector (Issue #265)
+- Use influxdb aliases to distinguish between multiple columns (Issue #283)
 
 
 # 1.5.2 (2013-03-24)
 # 1.5.2 (2013-03-24)
 ### New Features and improvements
 ### New Features and improvements

+ 16 - 5
src/app/directives/grafanaGraph.js

@@ -52,14 +52,25 @@ function (angular, $, kbn, moment, _) {
           }
           }
         }
         }
 
 
-        // Function for rendering panel
-        function render_panel() {
-          if (!data) { return; }
-          if (scope.otherPanelInFullscreenMode()) { return; }
-          if (!setElementHeight()) { return; }
+        function shouldAbortRender() {
+          if (!data) {
+            return true;
+          }
+          if ($rootScope.fullscreen && !scope.fullscreen) {
+            return true;
+          }
+
+          if (!setElementHeight()) { return true; }
 
 
           if (_.isString(data)) {
           if (_.isString(data)) {
             render_panel_as_graphite_png(data);
             render_panel_as_graphite_png(data);
+            return true;
+          }
+        }
+
+        // Function for rendering panel
+        function render_panel() {
+          if (shouldAbortRender()) {
             return;
             return;
           }
           }