Kaynağa Gözat

dasboard_history: fixed disabled attribute so it works both by disabling and fixing style, no need for disabled class and disabled attribute

Torkel Ödegaard 8 yıl önce
ebeveyn
işleme
56b3c4a3a0

+ 5 - 6
public/app/features/dashboard/history/history.html

@@ -74,22 +74,21 @@
 
 
         <div class="gf-form-group" ng-show="ctrl.mode === 'list'">
         <div class="gf-form-group" ng-show="ctrl.mode === 'list'">
           <div class="gf-form-button-row">
           <div class="gf-form-button-row">
-            <a	type="button"
+            <button	type="button"
                 class="btn gf-form-button btn-secondary"
                 class="btn gf-form-button btn-secondary"
                 ng-if="ctrl.revisions.length > 1"
                 ng-if="ctrl.revisions.length > 1"
-                ng-class="{disabled: !ctrl.canCompare}"
+                ng-disabled="!ctrl.canCompare"
                 ng-click="ctrl.getDiff(ctrl.diff)"
                 ng-click="ctrl.getDiff(ctrl.diff)"
 								bs-tooltip="ctrl.canCompare ? '' : 'Select 2 versions to start comparing'" data-placement="bottom">
 								bs-tooltip="ctrl.canCompare ? '' : 'Select 2 versions to start comparing'" data-placement="bottom">
               <i class="fa fa-code-fork" ></i>&nbsp;&nbsp;Compare versions
               <i class="fa fa-code-fork" ></i>&nbsp;&nbsp;Compare versions
-            </a>
-            <a  type="button"
+            </button>
+            <button  type="button"
                 class="btn gf-form-button btn-inverse"
                 class="btn gf-form-button btn-inverse"
                 ng-if="ctrl.revisions.length >= ctrl.limit"
                 ng-if="ctrl.revisions.length >= ctrl.limit"
                 ng-click="ctrl.addToLog()"
                 ng-click="ctrl.addToLog()"
-                ng-class="{disabled: ctrl.isLastPage()}"
                 ng-disabled="ctrl.isLastPage()">
                 ng-disabled="ctrl.isLastPage()">
               Show more versions
               Show more versions
-            </a>
+            </button>
           </div>
           </div>
         </div>
         </div>
       </div>
       </div>

+ 1 - 0
public/sass/components/_buttons.scss

@@ -41,6 +41,7 @@
   }
   }
 
 
   &.disabled,
   &.disabled,
+  &[disabled],
   &:disabled {
   &:disabled {
     cursor: $cursor-disabled;
     cursor: $cursor-disabled;
     opacity: .65;
     opacity: .65;