Jelajahi Sumber

Explore: do not show default suggestions after expressions

- an expression ends on closing braces
- exclude expressions from the default/empty suggestions
David Kaltschmidt 7 tahun lalu
induk
melakukan
6260a6d2f3
1 mengubah file dengan 4 tambahan dan 4 penghapusan
  1. 4 4
      public/app/features/explore/PromQueryField.tsx

+ 4 - 4
public/app/features/explore/PromQueryField.tsx

@@ -308,10 +308,10 @@ class PromQueryField extends React.PureComponent<PromQueryFieldProps, PromQueryF
     } else if (_.includes(wrapperClasses, 'context-aggregation')) {
     } else if (_.includes(wrapperClasses, 'context-aggregation')) {
       return this.getAggregationTypeahead.apply(this, arguments);
       return this.getAggregationTypeahead.apply(this, arguments);
     } else if (
     } else if (
-      // Non-empty but not inside known token
-      (prefix && !tokenRecognized) ||
-      (prefix === '' && !text.match(/^[)\s]+$/)) || // Empty context or after ')'
-      text.match(/[+\-*/^%]/) // After binary operator
+      // Show default suggestions in a couple of scenarios
+      (prefix && !tokenRecognized) || // Non-empty prefix, but not inside known token
+      (prefix === '' && !text.match(/^[\]})\s]+$/)) || // Empty prefix, but not following a closing brace
+      text.match(/[+\-*/^%]/) // Anything after binary operator
     ) {
     ) {
       return this.getEmptyTypeahead();
       return this.getEmptyTypeahead();
     }
     }