浏览代码

check types better

ryan 6 年之前
父节点
当前提交
68f7e046ab

+ 6 - 2
public/app/features/dashboard/dashgrid/DashboardPanel.tsx

@@ -14,6 +14,7 @@ import { PanelEditor } from '../panel_editor/PanelEditor';
 import { PanelModel, DashboardModel } from '../state';
 import { PanelPlugin } from 'app/types';
 import { PanelResizer } from './PanelResizer';
+import { PanelTypeChangedHook } from '@grafana/ui';
 
 export interface Props {
   panel: PanelModel;
@@ -91,8 +92,11 @@ export class DashboardPanel extends PureComponent<Props, State> {
 
           this.props.panel.changeType(pluginId);
         } else {
-          const { reactPanel } = plugin.exports;
-          panel.changeType(pluginId, reactPanel.panelTypeChangedHook);
+          let hook: PanelTypeChangedHook | null = null;
+          if (plugin.exports.reactPanel) {
+            hook = plugin.exports.reactPanel.panelTypeChangedHook;
+          }
+          panel.changeType(pluginId, hook);
         }
       }
 

+ 0 - 2
public/app/plugins/panel/bargauge/module.tsx

@@ -9,8 +9,6 @@ export const reactPanel = new ReactPanelPlugin<BarGaugeOptions>(BarGaugePanel);
 reactPanel.setEditor(BarGaugePanelEditor);
 reactPanel.setDefaults(defaults);
 reactPanel.setPanelTypeChangedHook((options: BarGaugeOptions, prevPluginId?: string, prevOptions?: any) => {
-  console.log('BAR Gauge', options, prevPluginId, prevOptions);
-
   if (prevOptions && prevOptions.valueOptions) {
     options.valueOptions = prevOptions.valueOptions;
     options.thresholds = prevOptions.thresholds;

+ 0 - 2
public/app/plugins/panel/gauge/module.tsx

@@ -9,8 +9,6 @@ export const reactPanel = new ReactPanelPlugin<GaugeOptions>(GaugePanel);
 reactPanel.setEditor(GaugePanelEditor);
 reactPanel.setDefaults(defaults);
 reactPanel.setPanelTypeChangedHook((options: GaugeOptions, prevPluginId?: string, prevOptions?: any) => {
-  console.log('BAR Gauge', options, prevPluginId, prevOptions);
-
   if (prevOptions && prevOptions.valueOptions) {
     options.valueOptions = prevOptions.valueOptions;
     options.thresholds = prevOptions.thresholds;