Quellcode durchsuchen

always return after errors.

woodsaj vor 10 Jahren
Ursprung
Commit
76e9ebde36
2 geänderte Dateien mit 2 neuen und 0 gelöschten Zeilen
  1. 1 0
      pkg/api/dashboard.go
  2. 1 0
      pkg/middleware/middleware.go

+ 1 - 0
pkg/api/dashboard.go

@@ -91,6 +91,7 @@ func PostDashboard(c *middleware.Context, cmd m.SaveDashboardCommand) {
 		limitReached, err := m.QuotaReached(cmd.OrgId, m.QUOTA_DASHBOARD)
 		limitReached, err := m.QuotaReached(cmd.OrgId, m.QUOTA_DASHBOARD)
 		if err != nil {
 		if err != nil {
 			c.JsonApiErr(500, "failed to get quota", err)
 			c.JsonApiErr(500, "failed to get quota", err)
+			return
 		}
 		}
 		if limitReached {
 		if limitReached {
 			c.JsonApiErr(403, "Quota reached", nil)
 			c.JsonApiErr(403, "Quota reached", nil)

+ 1 - 0
pkg/middleware/middleware.go

@@ -259,6 +259,7 @@ func LimitQuota(target m.QuotaTarget) macaron.Handler {
 		limitReached, err := m.QuotaReached(c.OrgId, target)
 		limitReached, err := m.QuotaReached(c.OrgId, target)
 		if err != nil {
 		if err != nil {
 			c.JsonApiErr(500, "failed to get quota", err)
 			c.JsonApiErr(500, "failed to get quota", err)
+			return
 		}
 		}
 		if limitReached {
 		if limitReached {
 			c.JsonApiErr(403, "Quota reached", nil)
 			c.JsonApiErr(403, "Quota reached", nil)