Bladeren bron

tech(grunt): add check for not including "only" in tests

bergquist 10 jaren geleden
bovenliggende
commit
80818f80a9
2 gewijzigde bestanden met toevoegingen van 15 en 2 verwijderingen
  1. 1 1
      public/test/core/utils/emitter_specs.ts
  2. 14 1
      tasks/default_task.js

+ 1 - 1
public/test/core/utils/emitter_specs.ts

@@ -24,7 +24,7 @@ describe("Emitter", () => {
       expect(sub2Called).to.be(true);
       expect(sub2Called).to.be(true);
     });
     });
 
 
-    it.only('should handle errors', () => {
+    it('should handle errors', () => {
       var events = new Emitter();
       var events = new Emitter();
       var sub1Called = 0;
       var sub1Called = 0;
       var sub2Called = 0;
       var sub2Called = 0;

+ 14 - 1
tasks/default_task.js

@@ -25,6 +25,19 @@ module.exports = function(grunt) {
     'typescript:build'
     'typescript:build'
   ]);
   ]);
 
 
-  grunt.registerTask('test', ['default', 'karma:test']);
+  grunt.registerTask('test', ['default', 'karma:test', 'no-only-tests']);
 
 
+  grunt.registerTask('no-only-tests', function() {
+    var files = grunt.file.expand('public/**/*_specs\.ts', 'public/**/*_specs\.js');
+
+    files.forEach(function(spec) {
+      var rows = grunt.file.read(spec).split('\n');
+      rows.forEach(function(row) {
+        if (row.indexOf('.only(') > 0) {
+          grunt.log.errorlns(row);
+          grunt.fail.warn('found only statement in test: ' + spec)
+        }
+      });
+    });
+  });
 };
 };