Browse Source

Annotations: Fix for annotations not reloaded when switching between 2 dashboards with annotations, Fixes #851

Torkel Ödegaard 11 years ago
parent
commit
81747e1623

+ 3 - 0
CHANGELOG.md

@@ -1,7 +1,10 @@
 # 1.9.0 (unreleased)
 
+# 1.8.1 (unreleased)
+
 **Fixes**
 - [Issue #847](https://github.com/grafana/grafana/issues/847). Graph: Fix for series draw order not being the same after hiding/unhiding series
+- [Issue #851](https://github.com/grafana/grafana/issues/851). Annotations: Fix for annotations not reloaded when switching between 2 dashboards with annotations
 
 # 1.8.0 (2014-09-22)
 

+ 2 - 1
src/app/services/annotationsSrv.js

@@ -13,7 +13,8 @@ define([
     var timezone;
 
     this.init = function() {
-      $rootScope.$on('refresh', this.clearCache);
+      $rootScope.onAppEvent('refresh', this.clearCache);
+      $rootScope.onAppEvent('setup-dashboard', this.clearCache);
     };
 
     this.clearCache = function() {

+ 4 - 0
src/app/services/elasticsearch/es-datasource.js

@@ -94,6 +94,10 @@ function (angular, _, config, kbn, moment) {
 
           for (var i = 0; i < fieldNames.length; i++) {
             fieldValue = fieldValue[fieldNames[i]];
+            if (!fieldValue) {
+              console.log('could not find field in annotatation: ', fieldName);
+              return '';
+            }
           }
 
           if (_.isArray(fieldValue)) {