Преглед изворни кода

Annotations: Check that timeEnd if defined before comparing to avoid false truthiness (#18903)

* Check that timeEnd if defined before comparing to avoid false truthiness

* Moved loop

Fixes #18902
Shavonn Brown пре 6 година
родитељ
комит
849d4881cd
1 измењених фајлова са 2 додато и 4 уклоњено
  1. 2 4
      public/app/features/annotations/annotations_srv.ts

+ 2 - 4
public/app/features/annotations/annotations_srv.ts

@@ -60,10 +60,6 @@ export class AnnotationsSrv {
         });
 
         annotations = dedupAnnotations(annotations);
-        for (let i = 0; i < annotations.length; i++) {
-          const a = annotations[i];
-          a.isRegion = a.time !== a.timeEnd;
-        }
 
         // look for alert state for this panel
         const alertState: any = _.find(results[1], { panelId: options.panel.id });
@@ -181,7 +177,9 @@ export class AnnotationsSrv {
 
     for (const item of results) {
       item.source = annotation;
+      item.isRegion = item.timeEnd && item.time !== item.timeEnd;
     }
+
     return results;
   }
 }