Sfoglia il codice sorgente

fix mutability bug, removed unused constructor

Peter Holmberg 7 anni fa
parent
commit
8ab2d8b0b9

+ 0 - 5
public/app/core/components/Picker/DescriptionPicker.tsx

@@ -17,11 +17,6 @@ export interface OptionWithDescription {
 }
 
 class DescriptionPicker extends Component<Props, any> {
-  constructor(props) {
-    super(props);
-    this.state = {};
-  }
-
   render() {
     const { optionsWithDesc, onSelected, value, disabled, className } = this.props;
 

+ 3 - 3
public/app/features/datasources/DataSourcePermissionsList.tsx

@@ -1,6 +1,6 @@
 import React, { PureComponent } from 'react';
-import { DataSourcePermission } from '../../types';
-import { dataSourceAclLevels, DataSourcePermissionLevel } from '../../types/acl';
+import { DataSourcePermission } from 'app/types';
+import { dataSourceAclLevels, DataSourcePermissionLevel } from 'app/types/acl';
 import DescriptionPicker from '../../core/components/Picker/DescriptionPicker';
 
 export interface Props {
@@ -41,7 +41,7 @@ export class DataSourcePermissionsList extends PureComponent<Props> {
 
   render() {
     const { items } = this.props;
-    const permissionLevels = dataSourceAclLevels;
+    const permissionLevels = [...dataSourceAclLevels];
     permissionLevels.push({ value: DataSourcePermissionLevel.Admin, label: 'Admin', description: '' });
 
     return (