Browse Source

pkg/services/alerting/notifiers/telegram.go: check error before close.

See,
$ gometalinter --vendor --deadline 6m --disable-all --enable=megacheck ./...
pkg/services/alerting/notifiers/telegram.go:130:2:warning: should check returned error before deferring imageFile.Close() (SA5001) (megacheck)
Mario Trangoni 7 years ago
parent
commit
9c44c75936
1 changed files with 7 additions and 1 deletions
  1. 7 1
      pkg/services/alerting/notifiers/telegram.go

+ 7 - 1
pkg/services/alerting/notifiers/telegram.go

@@ -127,7 +127,13 @@ func (this *TelegramNotifier) buildMessageInlineImage(evalContext *alerting.Eval
 	var err error
 
 	imageFile, err = os.Open(evalContext.ImageOnDiskPath)
-	defer imageFile.Close()
+	defer func() {
+		err := imageFile.Close()
+		if err != nil {
+			log.Error2("Could not close Telegram inline image.", "err", err)
+		}
+	}()
+
 	if err != nil {
 		return nil, err
 	}