Browse Source

dashboards as cfg: revert minor changes

bergquist 8 years ago
parent
commit
9cebb23e01
27 changed files with 20 additions and 13 deletions
  1. 7 0
      pkg/api/dashboard.go
  2. 1 1
      pkg/services/provisioning/dashboards/config_reader.go
  3. 1 1
      pkg/services/provisioning/dashboards/dashboard.go
  4. 1 1
      pkg/services/provisioning/dashboards/dashboard_test.go
  5. 1 1
      pkg/services/provisioning/dashboards/file_reader.go
  6. 1 1
      pkg/services/provisioning/dashboards/file_reader_test.go
  7. 0 0
      pkg/services/provisioning/dashboards/test-configs/dashboards-from-disk/dev-dashboards.yaml
  8. 0 0
      pkg/services/provisioning/dashboards/test-dashboards/broken-dashboards/empty-json.json
  9. 0 0
      pkg/services/provisioning/dashboards/test-dashboards/broken-dashboards/invalid.json
  10. 0 0
      pkg/services/provisioning/dashboards/test-dashboards/folder-one/dashboard1.json
  11. 0 0
      pkg/services/provisioning/dashboards/test-dashboards/folder-one/dashboard2.json
  12. 0 0
      pkg/services/provisioning/dashboards/test-dashboards/one-dashboard/dashboard1.json
  13. 1 1
      pkg/services/provisioning/dashboards/types.go
  14. 1 1
      pkg/services/provisioning/datasources/datasources.go
  15. 1 1
      pkg/services/provisioning/datasources/datasources_test.go
  16. 0 0
      pkg/services/provisioning/datasources/test-configs/all-properties/all-properties.yaml
  17. 0 0
      pkg/services/provisioning/datasources/test-configs/all-properties/not.yaml.txt
  18. 0 0
      pkg/services/provisioning/datasources/test-configs/all-properties/second.yaml
  19. 0 0
      pkg/services/provisioning/datasources/test-configs/broken-yaml/broken.yaml
  20. 0 0
      pkg/services/provisioning/datasources/test-configs/double-default/default-1.yaml
  21. 0 0
      pkg/services/provisioning/datasources/test-configs/double-default/default-2.yaml
  22. 0 0
      pkg/services/provisioning/datasources/test-configs/insert-two-delete-two/one-datasources.yaml
  23. 0 0
      pkg/services/provisioning/datasources/test-configs/insert-two-delete-two/two-datasources.yml
  24. 0 0
      pkg/services/provisioning/datasources/test-configs/two-datasources/two-datasources.yaml
  25. 0 0
      pkg/services/provisioning/datasources/test-configs/zero-datasources/placeholder-for-git
  26. 1 1
      pkg/services/provisioning/datasources/types.go
  27. 4 4
      pkg/services/provisioning/provisioning.go

+ 7 - 0
pkg/api/dashboard.go

@@ -3,6 +3,7 @@ package api
 import (
 	"encoding/json"
 	"fmt"
+	//"github.com/grafana/grafana/pkg/services/dashboards"
 	"os"
 	"path"
 	"strings"
@@ -124,6 +125,12 @@ func PostDashboard(c *middleware.Context, cmd m.SaveDashboardCommand) Response {
 
 	dash := cmd.GetDashboardModel()
 
+	// dashItem := &dashboards.SaveDashboardItem{
+	// 	Dashboard: dash,
+	// 	Message:   cmd.Message,
+	// }
+	// err := dashboards.SaveDashboard(dashItem)
+
 	// Check if Title is empty
 	if dash.Title == "" {
 		return ApiError(400, m.ErrDashboardTitleEmpty.Error(), nil)

+ 1 - 1
pkg/services/provisioning/dashboard/config_reader.go → pkg/services/provisioning/dashboards/config_reader.go

@@ -1,4 +1,4 @@
-package dashboard
+package dashboards
 
 import (
 	"io/ioutil"

+ 1 - 1
pkg/services/provisioning/dashboard/dashboard.go → pkg/services/provisioning/dashboards/dashboard.go

@@ -1,4 +1,4 @@
-package dashboard
+package dashboards
 
 import (
 	"context"

+ 1 - 1
pkg/services/provisioning/dashboard/dashboard_test.go → pkg/services/provisioning/dashboards/dashboard_test.go

@@ -1,4 +1,4 @@
-package dashboard
+package dashboards
 
 import (
 	"testing"

+ 1 - 1
pkg/services/provisioning/dashboard/file_reader.go → pkg/services/provisioning/dashboards/file_reader.go

@@ -1,4 +1,4 @@
-package dashboard
+package dashboards
 
 import (
 	"context"

+ 1 - 1
pkg/services/provisioning/dashboard/file_reader_test.go → pkg/services/provisioning/dashboards/file_reader_test.go

@@ -1,4 +1,4 @@
-package dashboard
+package dashboards
 
 import (
 	"github.com/grafana/grafana/pkg/bus"

+ 0 - 0
pkg/services/provisioning/dashboard/test-configs/dashboards-from-disk/dev-dashboards.yaml → pkg/services/provisioning/dashboards/test-configs/dashboards-from-disk/dev-dashboards.yaml


+ 0 - 0
pkg/services/provisioning/dashboard/test-dashboards/broken-dashboards/empty-json.json → pkg/services/provisioning/dashboards/test-dashboards/broken-dashboards/empty-json.json


+ 0 - 0
pkg/services/provisioning/dashboard/test-dashboards/broken-dashboards/invalid.json → pkg/services/provisioning/dashboards/test-dashboards/broken-dashboards/invalid.json


+ 0 - 0
pkg/services/provisioning/dashboard/test-dashboards/folder-one/dashboard1.json → pkg/services/provisioning/dashboards/test-dashboards/folder-one/dashboard1.json


+ 0 - 0
pkg/services/provisioning/dashboard/test-dashboards/folder-one/dashboard2.json → pkg/services/provisioning/dashboards/test-dashboards/folder-one/dashboard2.json


+ 0 - 0
pkg/services/provisioning/dashboard/test-dashboards/one-dashboard/dashboard1.json → pkg/services/provisioning/dashboards/test-dashboards/one-dashboard/dashboard1.json


+ 1 - 1
pkg/services/provisioning/dashboard/types.go → pkg/services/provisioning/dashboards/types.go

@@ -1,4 +1,4 @@
-package dashboard
+package dashboards
 
 import (
 	"github.com/grafana/grafana/pkg/components/simplejson"

+ 1 - 1
pkg/services/provisioning/datasource/datasources.go → pkg/services/provisioning/datasources/datasources.go

@@ -1,4 +1,4 @@
-package datasource
+package datasources
 
 import (
 	"errors"

+ 1 - 1
pkg/services/provisioning/datasource/datasources_test.go → pkg/services/provisioning/datasources/datasources_test.go

@@ -1,4 +1,4 @@
-package datasource
+package datasources
 
 import (
 	"testing"

+ 0 - 0
pkg/services/provisioning/datasource/test-configs/all-properties/all-properties.yaml → pkg/services/provisioning/datasources/test-configs/all-properties/all-properties.yaml


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/all-properties/not.yaml.txt → pkg/services/provisioning/datasources/test-configs/all-properties/not.yaml.txt


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/all-properties/second.yaml → pkg/services/provisioning/datasources/test-configs/all-properties/second.yaml


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/broken-yaml/broken.yaml → pkg/services/provisioning/datasources/test-configs/broken-yaml/broken.yaml


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/double-default/default-1.yaml → pkg/services/provisioning/datasources/test-configs/double-default/default-1.yaml


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/double-default/default-2.yaml → pkg/services/provisioning/datasources/test-configs/double-default/default-2.yaml


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/insert-two-delete-two/one-datasources.yaml → pkg/services/provisioning/datasources/test-configs/insert-two-delete-two/one-datasources.yaml


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/insert-two-delete-two/two-datasources.yml → pkg/services/provisioning/datasources/test-configs/insert-two-delete-two/two-datasources.yml


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/two-datasources/two-datasources.yaml → pkg/services/provisioning/datasources/test-configs/two-datasources/two-datasources.yaml


+ 0 - 0
pkg/services/provisioning/datasource/test-configs/zero-datasources/placeholder-for-git → pkg/services/provisioning/datasources/test-configs/zero-datasources/placeholder-for-git


+ 1 - 1
pkg/services/provisioning/datasource/types.go → pkg/services/provisioning/datasources/types.go

@@ -1,4 +1,4 @@
-package datasource
+package datasources
 
 import "github.com/grafana/grafana/pkg/models"
 import "github.com/grafana/grafana/pkg/components/simplejson"

+ 4 - 4
pkg/services/provisioning/provisioning.go

@@ -4,19 +4,19 @@ import (
 	"context"
 	"path/filepath"
 
-	"github.com/grafana/grafana/pkg/services/provisioning/dashboard"
-	"github.com/grafana/grafana/pkg/services/provisioning/datasource"
+	"github.com/grafana/grafana/pkg/services/provisioning/dashboards"
+	"github.com/grafana/grafana/pkg/services/provisioning/datasources"
 	ini "gopkg.in/ini.v1"
 )
 
 func Init(ctx context.Context, homePath string, cfg *ini.File) error {
 	datasourcePath := makeAbsolute(cfg.Section("paths").Key("datasources").String(), homePath)
-	if err := datasource.Provision(datasourcePath); err != nil {
+	if err := datasources.Provision(datasourcePath); err != nil {
 		return err
 	}
 
 	dashboardPath := makeAbsolute(cfg.Section("paths").Key("dashboards").String(), homePath)
-	_, err := dashboard.Provision(ctx, dashboardPath)
+	_, err := dashboards.Provision(ctx, dashboardPath)
 	if err != nil {
 		return err
 	}