Browse Source

refactor: finished timepicker to typescript and directive refactor

Torkel Ödegaard 10 years ago
parent
commit
9db6f82628

+ 1 - 1
pkg/api/api.go

@@ -17,7 +17,7 @@ func Register(r *macaron.Macaron) {
 	bind := binding.Bind
 
 	// not logged in views
-	r.Get("/", reqSignedIn, Index)
+	r.Get("/", reqSignedIn, Index)		
 	r.Get("/logout", Logout)
 	r.Post("/login", bind(dtos.LoginCommand{}), wrap(LoginPost))
 	r.Get("/login/:name", OAuthLogin)

+ 0 - 1
public/app/directives/all.js

@@ -1,6 +1,5 @@
 define([
   './dashUpload',
-  './grafanaSimplePanel',
   './dashEditLink',
   './ngModelOnBlur',
   './misc',

+ 1 - 1
public/app/features/dashboard/dashboardSrv.js

@@ -31,8 +31,8 @@ function (angular, $, kbn, _, moment) {
       this.hideControls = data.hideControls || false;
       this.sharedCrosshair = data.sharedCrosshair || false;
       this.rows = data.rows || [];
-      this.timepicker = data.timepicker || {};
       this.time = data.time || { from: 'now-6h', to: 'now' };
+      this.timepicker = data.timepicker || {};
       this.templating = this._ensureListExist(data.templating);
       this.annotations = this._ensureListExist(data.annotations);
       this.refresh = data.refresh;

+ 81 - 0
public/app/features/dashboard/timepicker/custom.html

@@ -0,0 +1,81 @@
+<div class="gf-box-header">
+	<div class="gf-box-title">
+		<i class="fa fa-clock-o"></i>
+		Custom time range
+	</div>
+	<button class="gf-box-header-close-btn" ng-click="dismiss();">
+		<i class="fa fa-remove"></i>
+	</button>
+</div>
+
+<div class="gf-box-body">
+	<style>
+		.timepicker-to-column {
+			margin-top: 10px;
+		}
+
+		.timepicker-input input {
+			outline: 0 !important;
+			border: 0px !important;
+			-webkit-box-shadow: 0;
+			-moz-box-shadow: 0;
+			box-shadow: 0;
+			position: relative;
+		}
+
+		.timepicker-input input::-webkit-outer-spin-button,
+		.timepicker-input input::-webkit-inner-spin-button {
+			-webkit-appearance: none;
+			margin: 0;
+		}
+
+		input.timepicker-date {
+			width: 90px;
+		}
+		input.timepicker-hms {
+			width: 20px;
+		}
+		input.timepicker-ms {
+			width: 25px;
+		}
+		div.timepicker-now {
+			float: right;
+		}
+	</style>
+
+	<div class="timepicker form-horizontal">
+		<form name="timeForm" style="margin-bottom: 0">
+
+			<div class="timepicker-from-column">
+				<label class="small">From</label>
+				<div class="fake-input timepicker-input">
+					<input class="timepicker-date" type="text" ng-change="validate(temptime)" ng-model="temptime.from.date" data-date-format="yyyy-mm-dd" required bs-datepicker />@
+					<input class="timepicker-hms" type="text" maxlength="2" ng-change="validate(temptime)" ng-model="temptime.from.hour" required ng-pattern="patterns.hour" onClick="this.select();"/>:
+					<input class="timepicker-hms" type="text" maxlength="2" ng-change="validate(temptime)" ng-model="temptime.from.minute" required ng-pattern="patterns.minute" onClick="this.select();"/>:
+					<input class="timepicker-hms" type="text" maxlength="2" ng-change="validate(temptime)" ng-model="temptime.from.second" required ng-pattern="patterns.second" onClick="this.select();"/>.
+					<input class="timepicker-ms" type="text" maxlength="3" ng-change="validate(temptime)" ng-model="temptime.from.millisecond" required ng-pattern="patterns.millisecond"  onClick="this.select();"/>
+				</div>
+			</div>
+
+			<div class="timepicker-to-column">
+
+				<label class="small">To (<a class="link" ng-class="{'strong':temptime.now}" ng-click="ctrl.setNow();temptime.now=true">set now</a>)</label>
+
+				<div class="fake-input timepicker-input">
+					<div ng-hide="temptime.now">
+						<input class="timepicker-date" type="text" ng-change="validate(temptime)" ng-model="temptime.to.date" data-date-format="yyyy-mm-dd" required bs-datepicker />@
+						<input class="timepicker-hms" type="text" maxlength="2" ng-change="validate(temptime)" ng-model="temptime.to.hour" required ng-pattern="patterns.hour" onClick="this.select();"/>:
+						<input class="timepicker-hms" type="text" maxlength="2" ng-change="validate(temptime)" ng-model="temptime.to.minute" required ng-pattern="patterns.minute" onClick="this.select();"/>:
+						<input class="timepicker-hms" type="text" maxlength="2" ng-change="validate(temptime)" ng-model="temptime.to.second" required ng-pattern="patterns.second" onClick="this.select();"/>.
+						<input class="timepicker-ms" type="text" maxlength="3" ng-change="validate(temptime)" ng-model="temptime.to.millisecond" required ng-pattern="patterns.millisecond" onClick="this.select();"/>
+					</div>
+					<span type="text" ng-show="temptime.now" ng-disabled="temptime.now">&nbsp <i class="pointer fa fa-remove" ng-click="ctrl.setNow();temptime.now=false;"></i> Right Now <input type="text" name="dummy" style="visibility:hidden" /></span>
+				</div>
+			</div>
+
+			<br>
+			<button ng-click="ctrl.setAbsoluteTimeFilter(ctrl.validate(temptime));dismiss();" ng-disabled="!timeForm.$valid" class="btn btn-success">Apply</button>
+			<span class="" ng-hide="input.$valid">Invalid date or range</span>
+		</form>
+	</div>
+</div>

+ 3 - 3
public/app/features/dashboard/timepicker/timepicker.html

@@ -19,7 +19,7 @@
 
 		<li class="dropdown">
 
-			<a class="dropdown-toggle timepicker-dropdown" data-toggle="dropdown" bs-tooltip="time.tooltip" data-placement="bottom" ng-click="loadTimeOptions();">
+			<a class="dropdown-toggle timepicker-dropdown" data-toggle="dropdown" bs-tooltip="time.tooltip" data-placement="bottom" ng-click="ctrl.loadTimeOptions();">
 				<i class="fa fa-clock-o"></i>
 				<span ng-bind="time.rangeString"></span>
 				<span ng-show="dashboard.refresh" class="text-warning">refreshed every {{dashboard.refresh}} </span>
@@ -29,7 +29,7 @@
 			<!-- lacy load this -->
 			<ul class="dropdown-menu" ng-if="time_options" >
 				<li bindonce ng-repeat='option in time_options'>
-					<a ng-click="setRelativeFilter(option)" bo-text="option.text"></a>
+					<a ng-click="ctrl.setRelativeFilter(option)" bo-text="option.text"></a>
 				</li>
 
 				<!-- Auto refresh submenu -->
@@ -44,7 +44,7 @@
 						</li>
 					</ul>
 				</li>
-				<li><a ng-click="customTime()">Custom</a></li>
+				<li><a ng-click="ctrl.customTime()">Custom</a></li>
 			</ul>
 
 		</li>

+ 136 - 168
public/app/features/dashboard/timepicker/timepicker.ts

@@ -7,224 +7,192 @@ import kbn = require('kbn');
 
 export class TimePickerCtrl {
 
-  constructor($scope : any, $rootScope, timeSrv) {
-    $scope.panelMeta = {
-      status  : "Stable",
-      description : ""
-    };
-
-    // Set and populate defaults
-    var _d = {
-      status        : "Stable",
-      time_options  : ['5m','15m','1h','6h','12h','24h','2d','7d','30d'],
-      refresh_intervals : ['5s','10s','30s','1m','5m','15m','30m','1h','2h','1d'],
-    };
+  static defaults = {
+    status        : "Stable",
+    time_options  : ['5m','15m','1h','6h','12h','24h','today', '2d','7d','30d'],
+    refresh_intervals : ['5s','10s','30s','1m','5m','15m','30m','1h','2h','1d'],
+  };
 
-    // ng-pattern regexs
-    $scope.patterns = {
+  static patterns = {
       date: /^[0-9]{2}\/[0-9]{2}\/[0-9]{4}$/,
       hour: /^([01]?[0-9]|2[0-3])$/,
       minute: /^[0-5][0-9]$/,
       second: /^[0-5][0-9]$/,
       millisecond: /^[0-9]*$/
-    };
+  };
 
+  constructor(private $scope : any, private $rootScope, private timeSrv) {
+    $scope.patterns = TimePickerCtrl.patterns;
     $scope.timeSrv = timeSrv;
+    $scope.ctrl = this;
 
-    $scope.$on('refresh', function() {
-      $scope.init();
-    });
-
-    $scope.init = function() {
-      $scope.panel = $scope.dashboard.timepicker;
+    $scope.$on('refresh', () => this.init());
 
-      _.defaults($scope.panel, _d);
-
-      var time = timeSrv.timeRange(true);
-      $scope.panel.now = false;
-
-      var unparsed = timeSrv.timeRange(false);
-      if (_.isString(unparsed.to) && unparsed.to.indexOf('now') === 0) {
-        $scope.panel.now = true;
-      }
+    this.init();
+  }
 
-      $scope.time = getScopeTimeObj(time.from, time.to);
+  init() {
+    this.$scope.panel = this.$scope.dashboard.timepicker;
 
-      $scope.onAppEvent('zoom-out', function() {
-        $scope.zoom(2);
-      });
-    };
+    _.defaults(this.$scope.panel, TimePickerCtrl.defaults);
 
-    $scope.loadTimeOptions = function() {
-      $scope.time_options = _.map($scope.panel.time_options, function(str) {
-        return kbn.getRelativeTimeInfo(str);
-      });
+    var time = this.timeSrv.timeRange(true);
+    this.$scope.panel.now = false;
 
-      $scope.refreshMenuLeftSide = $scope.time.rangeString.length < 10;
-    };
+    var unparsed = this.timeSrv.timeRange(false);
+    if (_.isString(unparsed.to) && unparsed.to.indexOf('now') === 0) {
+      this.$scope.panel.now = true;
+    }
 
-    $scope.customTime = function() {
-      // Assume the form is valid since we're setting it to something valid
-      $scope.input.$setValidity("dummy", true);
-      $scope.temptime = cloneTime($scope.time);
-      $scope.temptime.now = $scope.panel.now;
+    this.$scope.time = this.getScopeTimeObj(time.from, time.to);
 
-      $scope.temptime.from.date.setHours(0, 0, 0, 0);
-      $scope.temptime.to.date.setHours(0, 0, 0, 0);
+    this.$scope.onAppEvent('zoom-out', function() {
+      this.$scope.zoom(2);
+    });
+  }
 
-      // Date picker needs the date to be at the start of the day
-      if (new Date().getTimezoneOffset() < 0) {
-        $scope.temptime.from.date = moment($scope.temptime.from.date).add(1, 'days').toDate();
-        $scope.temptime.to.date = moment($scope.temptime.to.date).add(1, 'days').toDate();
-      }
+  pad(n: number, width: number, z = 0): string {
+    var str = n.toString();
+    return str.length >= width ? str : new Array(width - str.length + 1).join(z.toString()) + str;
+  }
 
-      $scope.appEvent('show-dash-editor', {src: 'app/panels/timepicker/custom.html', scope: $scope });
+  getTimeObj(date): any {
+    return {
+      date: new Date(date),
+      hour: this.pad(date.getHours(), 2),
+      minute: this.pad(date.getMinutes(), 2),
+      second: this.pad(date.getSeconds(), 2),
+      millisecond: this.pad(date.getMilliseconds(), 3)
     };
+  };
 
-    // Constantly validate the input of the fields. This function does not change any date variables
-    // outside of its own scope
-    $scope.validate = function(time) : any {
-      // Assume the form is valid. There is a hidden dummy input for invalidating it programatically.
-      $scope.input.$setValidity("dummy", true);
-
-      var _from = datepickerToLocal(time.from.date),
-        _to = datepickerToLocal(time.to.date),
-        _t = time;
-
-      if ($scope.input.$valid) {
+  getScopeTimeObj(from, to) {
+    var model : any = {from: this.getTimeObj(from), to: this.getTimeObj(to)};
 
-        _from.setHours(_t.from.hour, _t.from.minute, _t.from.second, _t.from.millisecond);
-        _to.setHours(_t.to.hour, _t.to.minute, _t.to.second, _t.to.millisecond);
+    if (model.from.date) {
+      model.tooltip = this.$scope.dashboard.formatDate(model.from.date) + ' <br>to<br>';
+      model.tooltip += this.$scope.dashboard.formatDate(model.to.date);
+    }
+    else {
+      model.tooltip = 'Click to set time filter';
+    }
 
-        // Check that the objects are valid and to is after from
-        if (isNaN(_from.getTime()) || isNaN(_to.getTime()) || _from.getTime() >= _to.getTime()) {
-          $scope.input.$setValidity("dummy", false);
-          return false;
+    if (this.timeSrv.time) {
+      if (this.$scope.panel.now) {
+        if (this.timeSrv.time.from === 'today') {
+          model.rangeString = 'Today';
+        } else {
+          model.rangeString = moment(model.from.date).fromNow() + ' to ' +
+            moment(model.to.date).fromNow();
         }
-      } else {
-        return false;
       }
+      else {
+        model.rangeString = this.$scope.dashboard.formatDate(model.from.date, 'MMM D, YYYY HH:mm:ss') + ' to ' +
+          this.$scope.dashboard.formatDate(model.to.date, 'MMM D, YYYY HH:mm:ss');
+      }
+    }
 
-      return { from: _from, to: _to, now: time.now };
-    };
-
-    $scope.setNow = function() {
-      $scope.time.to = getTimeObj(new Date());
-    };
+    return model;
+  }
 
-    $scope.setAbsoluteTimeFilter = function (time) {
-      // Create filter object
-      var _filter = _.clone(time);
+  loadTimeOptions() {
+    this.$scope.time_options = _.map(this.$scope.panel.time_options, function(str) {
+      return kbn.getRelativeTimeInfo(str);
+    });
 
-      if (time.now) {
-        _filter.to = "now";
-      }
+    this.$scope.refreshMenuLeftSide = this.$scope.time.rangeString.length < 10;
+  }
 
-      // Update our representation
-      $scope.time = getScopeTimeObj(time.from, time.to);
+  cloneTime(time) {
+    var _n = { from: _.clone(time.from), to: _.clone(time.to) };
 
-      timeSrv.setTime(_filter);
-    };
+    // Create new dates as _.clone is shallow.
+    _n.from.date = new Date(_n.from.date);
+    _n.to.date = new Date(_n.to.date);
+    return _n;
+  }
 
-    $scope.setRelativeFilter = function(timespan) {
-      $scope.panel.now = true;
+  customTime() {
+    // Assume the form is valid since we're setting it to something valid
+    this.$scope.input.$setValidity("dummy", true);
+    this.$scope.temptime = this.cloneTime(this.$scope.time);
+    this.$scope.temptime.now = this.$scope.panel.now;
 
-      var range = {from: timespan.from, to: timespan.to};
+    this.$scope.temptime.from.date.setHours(0, 0, 0, 0);
+    this.$scope.temptime.to.date.setHours(0, 0, 0, 0);
 
-      if ($scope.panel.nowDelay) {
-        range.to = 'now-' + $scope.panel.nowDelay;
-      }
+    // Date picker needs the date to be at the start of the day
+    if (new Date().getTimezoneOffset() < 0) {
+      this.$scope.temptime.from.date = moment(this.$scope.temptime.from.date).add(1, 'days').toDate();
+      this.$scope.temptime.to.date = moment(this.$scope.temptime.to.date).add(1, 'days').toDate();
+    }
 
-      timeSrv.setTime(range);
+    this.$scope.appEvent('show-dash-editor', {
+      src: 'app/features/dashboard/timepicker/custom.html',
+      scope: this.$scope
+    });
+  }
 
-      $scope.time = getScopeTimeObj(kbn.parseDate(range.from), new Date());
-    };
+  setNow() {
+    this.$scope.time.to = this.getTimeObj(new Date());
+  }
 
-    var pad : any = function(n, width, z) {
-      z = z || '0';
-      n = n.toString();
-      return n.length >= width ? n : new Array(width - n.length + 1).join(z) + n;
-    };
+  setAbsoluteTimeFilter(time) {
+    // Create filter object
+    var _filter = _.clone(time);
 
-    var cloneTime = function(time) {
-      var _n = {
-        from: _.clone(time.from),
-        to: _.clone(time.to)
-      };
-      // Create new dates as _.clone is shallow.
-      _n.from.date = new Date(_n.from.date);
-      _n.to.date = new Date(_n.to.date);
-      return _n;
-    };
+    if (time.now) {
+      _filter.to = "now";
+    }
 
-    var getScopeTimeObj = function(from, to) {
-      var model : any = {from: getTimeObj(from), to: getTimeObj(to)};
+    // Update our representation
+    this.$scope.time = this.getScopeTimeObj(time.from, time.to);
+    this.timeSrv.setTime(_filter);
+  }
 
-      if (model.from.date) {
-        model.tooltip = $scope.dashboard.formatDate(model.from.date) + ' <br>to<br>';
-        model.tooltip += $scope.dashboard.formatDate(model.to.date);
-      }
-      else {
-        model.tooltip = 'Click to set time filter';
-      }
+  setRelativeFilter(timespan) {
+    this.$scope.panel.now = true;
 
-      if (timeSrv.time) {
-        if ($scope.panel.now) {
-          if (timeSrv.time.from === 'today') {
-            model.rangeString = 'Today';
-          } else {
-            model.rangeString = moment(model.from.date).fromNow() + ' to ' +
-              moment(model.to.date).fromNow();
-          }
-        }
-        else {
-          model.rangeString = $scope.dashboard.formatDate(model.from.date, 'MMM D, YYYY HH:mm:ss') + ' to ' +
-            $scope.dashboard.formatDate(model.to.date, 'MMM D, YYYY HH:mm:ss');
-        }
-      }
+    var range = {from: timespan.from, to: timespan.to};
 
-      return model;
-    };
+    if (this.$scope.panel.nowDelay) {
+      range.to = 'now-' + this.$scope.panel.nowDelay;
+    }
 
-    var getTimeObj = function(date) {
-      return {
-        date: new Date(date),
-        hour: pad(date.getHours(), 2),
-        minute: pad(date.getMinutes(), 2),
-        second: pad(date.getSeconds(), 2),
-        millisecond: pad(date.getMilliseconds(), 3)
-      };
-    };
+    this.timeSrv.setTime(range);
 
-    // Do not use the results of this function unless you plan to use setHour/Minutes/etc on the result
-    var datepickerToLocal = function(date) {
-      date = moment(date).clone().toDate();
-      return moment(new Date(date.getTime() + date.getTimezoneOffset() * 60000)).toDate();
-    };
+    this.$scope.time = this.getScopeTimeObj(kbn.parseDate(range.from), new Date());
+  }
 
-    $scope.zoom = function(factor) {
-      var range = timeSrv.timeRange();
+  validate(time): any {
+    // Assume the form is valid. There is a hidden dummy input for invalidating it programatically.
+    this.$scope.input.$setValidity("dummy", true);
 
-      var timespan = (range.to.valueOf() - range.from.valueOf());
-      var center = range.to.valueOf() - timespan/2;
+    var _from = this.datepickerToLocal(time.from.date);
+    var _to = this.datepickerToLocal(time.to.date);
+    var _t = time;
 
-      var to = (center + (timespan*factor)/2);
-      var from = (center - (timespan*factor)/2);
+    if (this.$scope.input.$valid) {
+      _from.setHours(_t.from.hour, _t.from.minute, _t.from.second, _t.from.millisecond);
+      _to.setHours(_t.to.hour, _t.to.minute, _t.to.second, _t.to.millisecond);
 
-      if (to > Date.now() && range.to <= Date.now()) {
-        var offset = to - Date.now();
-        from = from - offset;
-        to = Date.now();
+      // Check that the objects are valid and to is after from
+      if (isNaN(_from.getTime()) || isNaN(_to.getTime()) || _from.getTime() >= _to.getTime()) {
+        this.$scope.input.$setValidity("dummy", false);
+        return false;
       }
+    } else {
+      return false;
+    }
 
-      timeSrv.setTime({
-        from: moment.utc(from).toDate(),
-        to: moment.utc(to).toDate(),
-      });
-    };
+    return { from: _from, to: _to, now: time.now };
+  }
 
-    $scope.init();
+  datepickerToLocal(date) {
+    date = moment(date).clone().toDate();
+    return moment(new Date(date.getTime() + date.getTimezoneOffset() * 60000)).toDate();
   }
+
 }
 
 export function settingsDirective() {

+ 0 - 1
public/test/specs/dashboardSrv-specs.js

@@ -31,7 +31,6 @@ define([
       it('should have default properties', function() {
         expect(model.rows.length).to.be(0);
       });
-
     });
 
     describe('when getting next panel id', function() {