always delete session cookie even if db delete fails

devenv/docker/blocks/loki/docker-compose.yaml

@@ -20,3 +20,5 @@ services:
       -config.file=/etc/promtail/docker-config.yaml
     networks:
       - loki
+    depends_on:
+      - loki

pkg/services/auth/auth_token.go

@@ -121,18 +121,10 @@ func (s *UserAuthTokenServiceImpl) SignOutUser(c *models.ReqContext) error {
 	hashedToken := hashToken(unhashedToken)
 
 	sql := `DELETE FROM user_auth_token WHERE auth_token = ?`
-	res, err := s.SQLStore.NewSession().Exec(sql, hashedToken)
-	if err != nil {
-		return err
-	}
-
-	affected, _ := res.RowsAffected()
-	if affected > 0 {
-		s.writeSessionCookie(c, "", -1)
-		return nil
-	}
+	_, err := s.SQLStore.NewSession().Exec(sql, hashedToken)
 
-	return errors.New("failed to delete session")
+	s.writeSessionCookie(c, "", -1)
+	return err
 }
 
 func (s *UserAuthTokenServiceImpl) CreateToken(userId int64, clientIP, userAgent string) (*userAuthToken, error) {

pkg/services/auth/auth_token_test.go

@@ -73,7 +73,7 @@ func TestUserAuthToken(t *testing.T) {
 
 			Convey("signing out an none existing session should return an error", func() {
 				httpreq := &http.Request{Header: make(http.Header)}
-				httpreq.AddCookie(&http.Cookie{Name: userAuthTokenService.Cfg.LoginCookieName, Value: "missing-session-cookie"})
+				httpreq.AddCookie(&http.Cookie{Name: userAuthTokenService.Cfg.LoginCookieName, Value: ""})
 
 				ctx := &models.ReqContext{Context: &macaron.Context{
 					Req:  macaron.Request{Request: httpreq},