Jelajahi Sumber

feat(alerting): avoid double logging

bergquist 9 tahun lalu
induk
melakukan
c138b04c5e
1 mengubah file dengan 4 tambahan dan 2 penghapusan
  1. 4 2
      pkg/services/alerting/extractor.go

+ 4 - 2
pkg/services/alerting/extractor.go

@@ -3,6 +3,8 @@ package alerting
 import (
 	"errors"
 
+	"fmt"
+
 	"github.com/grafana/grafana/pkg/bus"
 	"github.com/grafana/grafana/pkg/components/simplejson"
 	"github.com/grafana/grafana/pkg/log"
@@ -104,8 +106,8 @@ func (e *DashAlertExtractor) GetAlerts() ([]*m.Alert, error) {
 				panelQuery := findPanelQueryByRefId(panel, queryRefId)
 
 				if panelQuery == nil {
-					e.log.Error("Query not found", "panel", alert.PanelId, "queryRefId", queryRefId)
-					return nil, ValidationError{Reason: "Alert refers to query that cannot be found"}
+					reason := fmt.Sprintf("Alert on PanelId: %v refers to query(%s) that cannot be found", alert.PanelId, queryRefId)
+					return nil, ValidationError{Reason: reason}
 				}
 
 				dsName := ""