feat(plugins): moved http settings to directive instad of just ng-include partial

public/app/features/datasources/all.js

@@ -0,0 +1,4 @@
+define([
+  './list_ctrl',
+  './edit_ctrl',
+], function () {});

public/app/features/org/datasourceEditCtrl.js → public/app/features/datasources/edit_ctrl.js

@@ -9,9 +9,11 @@ function (angular, _, config) {
   var module = angular.module('grafana.controllers');
   var datasourceTypes = [];
 
-  module.controller('DataSourceEditCtrl', function($scope, $q, backendSrv, $routeParams, $location, datasourceSrv) {
+  module.directive('datasourceHttpSettings', function() {
+    return {templateUrl: 'app/features/datasources/partials/http_settings.html'};
+  });
 
-    $scope.httpConfigPartialSrc = 'app/features/org/partials/datasourceHttpConfig.html';
+  module.controller('DataSourceEditCtrl', function($scope, $q, backendSrv, $routeParams, $location, datasourceSrv) {
 
     var defaults = {name: '', type: 'graphite', url: '', access: 'proxy', jsonData: {}};
 
@@ -114,6 +116,5 @@ function (angular, _, config) {
     };
 
     $scope.init();
-
   });
 });

public/app/features/org/partials/datasourceHttpConfig.html → public/app/features/datasources/partials/http_settings.html

@@ -53,3 +53,5 @@
 		<div class="clearfix"></div>
 	</div>
 </div>
+
+<br>

public/app/features/org/all.js

@@ -1,9 +1,8 @@
 define([
-  './datasourcesCtrl',
-  './datasourceEditCtrl',
   './orgUsersCtrl',
   './newOrgCtrl',
   './userInviteCtrl',
   './orgApiKeysCtrl',
   './orgDetailsCtrl',
+  '../datasources/all',
 ], function () {});

public/app/plugins/datasource/elasticsearch/partials/edit_view.html

@@ -1,5 +1,4 @@
-<div ng-include="httpConfigPartialSrc"></div>
-<br>
+<datasource-http-settings></datasource-http-settings>
 
 <h5>Elasticsearch details</h5>
 

public/app/plugins/datasource/graphite/datasource.d.ts

@@ -1,3 +1,3 @@
 declare var Datasource: any;
-export {Datasource};
+export default Datasource;
 

public/app/plugins/datasource/graphite/datasource.js

@@ -4,7 +4,6 @@ define([
   'jquery',
   'app/core/config',
   'app/core/utils/datemath',
-  './directives',
   './query_ctrl',
   './func_editor',
   './add_graphite_func',
@@ -293,7 +292,5 @@ function (angular, _, $, config, dateMath) {
     };
   }
 
-  return {
-    Datasource: GraphiteDatasource
-  };
+  return GraphiteDatasource;
 });

public/app/plugins/datasource/graphite/directives.js → public/app/plugins/datasource/graphite/module.js

@@ -1,7 +1,8 @@
 define([
   'angular',
+  './datasource',
 ],
-function (angular) {
+function (angular, GraphiteDatasource) {
   'use strict';
 
   var module = angular.module('grafana.directives');
@@ -18,4 +19,7 @@ function (angular) {
     return {templateUrl: 'app/plugins/datasource/graphite/partials/annotations.editor.html'};
   });
 
+  return {
+    Datasource: GraphiteDatasource,
+  };
 });

public/app/plugins/datasource/graphite/partials/config.html

@@ -1,3 +1,2 @@
-<div ng-include="httpConfigPartialSrc"></div>
-
+<datasource-http-settings></datasource-http-settings>
 

public/app/plugins/datasource/graphite/plugin.json

@@ -3,11 +3,7 @@
   "type": "datasource",
   "id": "graphite",
 
-  "module": "app/plugins/datasource/graphite/datasource",
-
-  "partials": {
-    "config": "app/plugins/datasource/graphite/partials/config.html"
-  },
+  "module": "app/plugins/datasource/graphite/module",
 
   "defaultMatchFormat": "glob",
   "metrics": true,

public/app/plugins/datasource/graphite/specs/datasource_specs.ts

@@ -1,7 +1,7 @@
 
 import {describe, beforeEach, it, sinon, expect, angularMocks} from 'test/lib/common';
 import helpers from 'test/specs/helpers';
-import {Datasource} from "../datasource";
+import Datasource from "../datasource";
 
 describe('graphiteDatasource', function() {
   var ctx = new helpers.ServiceTestContext();

public/app/plugins/datasource/influxdb/partials/config.html

@@ -1,5 +1,4 @@
-<div ng-include="httpConfigPartialSrc"></div>
-<br>
+<datasource-http-settings></datasource-http-settings>
 
 <h5>InfluxDB Details</h5>
 

public/app/plugins/datasource/opentsdb/partials/config.html

@@ -1,4 +1,2 @@
-<div ng-include="httpConfigPartialSrc"></div>
-
-<br>
+<datasource-http-settings></datasource-http-settings>
 

public/app/plugins/datasource/prometheus/partials/config.html

@@ -1,4 +1,2 @@
-<div ng-include="httpConfigPartialSrc"></div>
-
-<br>
+<datasource-http-settings></datasource-http-settings>
 

tasks/options/watch.js

@@ -6,7 +6,7 @@ module.exports = function(config, grunt) {
 
     grunt.log.writeln('File Changed: ' + filepath);
 
-    if (/(\.html)$/.test(filepath)) {
+    if (/(\.html)|(\.json)$/.test(filepath)) {
       newPath = filepath.replace(/^public/, 'public_gen');
       grunt.log.writeln('Copying to ' + newPath);
       grunt.file.copy(filepath, newPath);