Просмотр исходного кода

feat(templating): prometheus now works with new template variable formating/escaping, #2918

Torkel Ödegaard 9 лет назад
Родитель
Сommit
d1bac6cde0

+ 1 - 1
docker/blocks/prometheus/prometheus.yml

@@ -23,4 +23,4 @@ scrape_configs:
     # scheme defaults to 'http'.
 
     target_groups:
-      - targets: ['localhost:9090', '172.17.42.1:9091']
+      - targets: ['localhost:9090', '172.17.0.1:9091']

+ 1 - 1
public/app/features/templating/templateSrv.js

@@ -50,7 +50,7 @@ function (angular, _) {
           }
 
           var escapedValues = _.map(value, regexEscape);
-          return '(' + escapedValues.join('|') + ')';
+          return escapedValues.join('|');
         }
         case "lucene": {
           if (typeof value === 'string') {

+ 1 - 1
public/app/plugins/datasource/prometheus/datasource.ts

@@ -52,7 +52,7 @@ export function PrometheusDatasource(instanceSettings, $q, backendSrv, templateS
       }
 
       var query: any = {};
-      query.expr = templateSrv.replace(target.expr, options.scopedVars);
+      query.expr = templateSrv.replace(target.expr, options.scopedVars, 'regex');
 
       var interval = target.interval || options.interval;
       var intervalFactor = target.intervalFactor || 1;

+ 1 - 2
public/app/plugins/datasource/prometheus/plugin.json

@@ -4,6 +4,5 @@
   "id": "prometheus",
 
   "metrics": true,
-  "annotations": true,
-  "defaultMatchFormat": "pipe"
+  "annotations": true
 }

+ 1 - 1
public/test/specs/templateSrv-specs.js

@@ -127,7 +127,7 @@ define([
 
       it('multi value and regex format should render regex string', function() {
         var result = _templateSrv.formatValue(['test.','test2'], 'regex');
-        expect(result).to.be('(test\\.|test2)');
+        expect(result).to.be('test\\.|test2');
       });
 
       it('multi value and pipe should render pipe string', function() {