Browse Source

check validation of interval string before converting to seconds

Mekal Zheng 9 years ago
parent
commit
e57c764410
1 changed files with 4 additions and 2 deletions
  1. 4 2
      public/app/plugins/datasource/elasticsearch/datasource.js

+ 4 - 2
public/app/plugins/datasource/elasticsearch/datasource.js

@@ -220,8 +220,10 @@ function (angular, _, moment, kbn, ElasticQueryBuilder, IndexPattern, ElasticRes
       }
       }
 
 
       // intervalSec: interval in seconds
       // intervalSec: interval in seconds
-      payload = payload.replace(/\$intervalSec/g, kbn.interval_to_seconds(options.interval));
-      payload = payload.replace(/\$intervalMs/g, kbn.interval_to_ms(options.interval));
+      if (options.interval && options.interval.match(kbn.interval_regex)) {
+        payload = payload.replace(/\$intervalSec/g, kbn.interval_to_seconds(options.interval));
+        payload = payload.replace(/\$intervalMs/g, kbn.interval_to_ms(options.interval));
+      }
       payload = payload.replace(/\$interval/g, options.interval);
       payload = payload.replace(/\$interval/g, options.interval);
       payload = payload.replace(/\$timeFrom/g, options.range.from.valueOf());
       payload = payload.replace(/\$timeFrom/g, options.range.from.valueOf());
       payload = payload.replace(/\$timeTo/g, options.range.to.valueOf());
       payload = payload.replace(/\$timeTo/g, options.range.to.valueOf());