Explorar o código

tests: migrated tests for link_srv to jest, #9666

Torkel Ödegaard %!s(int64=8) %!d(string=hai) anos
pai
achega
ec94dfa890

+ 4 - 4
public/app/features/panellinks/link_srv.ts

@@ -5,8 +5,7 @@ import kbn from 'app/core/utils/kbn';
 export class LinkSrv {
 
   /** @ngInject */
-  constructor(private templateSrv, private timeSrv) {
-  }
+  constructor(private templateSrv, private timeSrv) {}
 
   getLinkUrl(link) {
     var url = this.templateSrv.replace(link.url || '');
@@ -29,7 +28,9 @@ export class LinkSrv {
     var paramsArray = [];
 
     _.each(params, function(value, key) {
-      if (value === null) { return; }
+      if (value === null) {
+        return;
+      }
       if (value === true) {
         paramsArray.push(key);
       } else if (_.isArray(value)) {
@@ -107,7 +108,6 @@ export class LinkSrv {
 
     return info;
   }
-
 }
 
 angular.module('grafana.services').service('linkSrv', LinkSrv);

+ 0 - 46
public/app/features/panellinks/specs/link_srv_specs.ts

@@ -1,46 +0,0 @@
-import {describe, beforeEach, it, expect, angularMocks} from 'test/lib/common';
-import 'app/features/panellinks/link_srv';
-import _ from  'lodash';
-
-describe('linkSrv', function() {
-  var _linkSrv;
-
-  beforeEach(angularMocks.module('grafana.core'));
-  beforeEach(angularMocks.module('grafana.services'));
-
-  beforeEach(angularMocks.inject(function(linkSrv) {
-    _linkSrv = linkSrv;
-  }));
-
-  describe('when appending query strings', function() {
-
-    it('add ? to URL if not present', function() {
-      var url = _linkSrv.appendToQueryString('http://example.com', 'foo=bar');
-      expect(url).to.be('http://example.com?foo=bar');
-    });
-
-    it('do not add & to URL if ? is present but query string is empty', function() {
-      var url = _linkSrv.appendToQueryString('http://example.com?', 'foo=bar');
-      expect(url).to.be('http://example.com?foo=bar');
-    });
-
-    it('add & to URL if query string is present', function() {
-      var url = _linkSrv.appendToQueryString('http://example.com?foo=bar', 'hello=world');
-      expect(url).to.be('http://example.com?foo=bar&hello=world');
-    });
-
-    it('do not change the URL if there is nothing to append', function() {
-      _.each(['', undefined, null], function(toAppend) {
-        var url1 = _linkSrv.appendToQueryString('http://example.com', toAppend);
-        expect(url1).to.be('http://example.com');
-
-        var url2 = _linkSrv.appendToQueryString('http://example.com?', toAppend);
-        expect(url2).to.be('http://example.com?');
-
-        var url3 = _linkSrv.appendToQueryString('http://example.com?foo=bar', toAppend);
-        expect(url3).to.be('http://example.com?foo=bar');
-      });
-    });
-
-  });
-});