Browse Source

ensure that if the dasboardID is negative, it will not bypass the checking of the right (#12398)

Augustin 7 years ago
parent
commit
ef0bf9f701
1 changed files with 3 additions and 3 deletions
  1. 3 3
      pkg/api/annotations.go

+ 3 - 3
pkg/api/annotations.go

@@ -272,9 +272,9 @@ func canSaveByDashboardID(c *m.ReqContext, dashboardID int64) (bool, error) {
 		return false, nil
 	}
 
-	if dashboardID > 0 {
-		guardian := guardian.New(dashboardID, c.OrgId, c.SignedInUser)
-		if canEdit, err := guardian.CanEdit(); err != nil || !canEdit {
+	if dashboardID != 0 {
+		guard := guardian.New(dashboardID, c.OrgId, c.SignedInUser)
+		if canEdit, err := guard.CanEdit(); err != nil || !canEdit {
 			return false, err
 		}
 	}