Explorar el Código

avoid exporting test helpers

bergquist hace 6 años
padre
commit
f9f2d9fcf3

+ 1 - 2
pkg/infra/distcache/database_storage_integration_test.go

@@ -3,6 +3,5 @@ package distcache
 import "testing"
 
 func TestIntegrationDatabaseCacheStorage(t *testing.T) {
-
-	RunTestsForClient(t, createTestClient(t, "database"))
+	runTestsForClient(t, createTestClient(t, "database"))
 }

+ 7 - 13
pkg/infra/distcache/distcache_test.go

@@ -26,19 +26,13 @@ func createTestClient(t *testing.T, name string) cacheStorage {
 	return createClient(CacheOpts{name: name}, sqlstore)
 }
 
-func TestMemoryStorageClient(t *testing.T) {
-
-	client := createTestClient(t, "memory")
-	RunTestsForClient(t, client)
-}
-
-func RunTestsForClient(t *testing.T, client cacheStorage) {
-	CanPutGetAndDeleteCachedObjects(t, client)
-	CanNotFetchExpiredItems(t, client)
-	CanSetInfiniteCacheExpiration(t, client)
+func runTestsForClient(t *testing.T, client cacheStorage) {
+	canPutGetAndDeleteCachedObjects(t, client)
+	canNotFetchExpiredItems(t, client)
+	canSetInfiniteCacheExpiration(t, client)
 }
 
-func CanPutGetAndDeleteCachedObjects(t *testing.T, client cacheStorage) {
+func canPutGetAndDeleteCachedObjects(t *testing.T, client cacheStorage) {
 	cacheableStruct := CacheableStruct{String: "hej", Int64: 2000}
 
 	err := client.Put("key", cacheableStruct, 0)
@@ -58,7 +52,7 @@ func CanPutGetAndDeleteCachedObjects(t *testing.T, client cacheStorage) {
 	assert.Equal(t, err, ErrCacheItemNotFound)
 }
 
-func CanNotFetchExpiredItems(t *testing.T, client cacheStorage) {
+func canNotFetchExpiredItems(t *testing.T, client cacheStorage) {
 	cacheableStruct := CacheableStruct{String: "hej", Int64: 2000}
 
 	err := client.Put("key", cacheableStruct, time.Second)
@@ -72,7 +66,7 @@ func CanNotFetchExpiredItems(t *testing.T, client cacheStorage) {
 	assert.Equal(t, err, ErrCacheItemNotFound)
 }
 
-func CanSetInfiniteCacheExpiration(t *testing.T, client cacheStorage) {
+func canSetInfiniteCacheExpiration(t *testing.T, client cacheStorage) {
 	cacheableStruct := CacheableStruct{String: "hej", Int64: 2000}
 
 	// insert cache item one day back

+ 1 - 1
pkg/infra/distcache/memcached_storage_test.go

@@ -3,5 +3,5 @@ package distcache
 import "testing"
 
 func TestMemcachedCacheStorage(t *testing.T) {
-	RunTestsForClient(t, createTestClient(t, "memcache"))
+	runTestsForClient(t, createTestClient(t, "memcache"))
 }

+ 7 - 0
pkg/infra/distcache/memory_storage_test.go

@@ -0,0 +1,7 @@
+package distcache
+
+import "testing"
+
+func TestMemoryCacheStorage(t *testing.T) {
+	runTestsForClient(t, createTestClient(t, "memory"))
+}

+ 1 - 1
pkg/infra/distcache/redis_storage_test.go

@@ -3,5 +3,5 @@ package distcache
 import "testing"
 
 func TestRedisCacheStorage(t *testing.T) {
-	RunTestsForClient(t, createTestClient(t, "redis"))
+	runTestsForClient(t, createTestClient(t, "redis"))
 }