Explorar el Código

remove maxage from session token

bergquist hace 7 años
padre
commit
fd937e3d95
Se han modificado 2 ficheros con 7 adiciones y 9 borrados
  1. 4 6
      pkg/middleware/middleware.go
  2. 3 3
      pkg/services/auth/auth_token.go

+ 4 - 6
pkg/middleware/middleware.go

@@ -4,7 +4,6 @@ import (
 	"net/http"
 	"net/url"
 	"strconv"
-	"time"
 
 	"github.com/grafana/grafana/pkg/bus"
 	"github.com/grafana/grafana/pkg/components/apikeygen"
@@ -71,15 +70,14 @@ func GetContextHandler(ats *auth.UserAuthTokenService) macaron.Handler {
 
 		if rotated {
 			ctx.Logger.Info("new token", "unhashed token", ctx.UserToken.UnhashedToken)
-			//c.SetCookie("grafana_session", url.QueryEscape(ctx.UserToken.UnhashedToken), nil, setting.AppSubUrl+"/", setting.Domain, false, true)
-			// ctx.Resp.Header().Del("Set-Cookie")
+			ctx.Resp.Header().Del("Set-Cookie")
 			cookie := http.Cookie{
 				Name:     "grafana_session",
 				Value:    url.QueryEscape(ctx.UserToken.UnhashedToken),
 				HttpOnly: true,
-				MaxAge:   int(time.Minute * 10),
-				Domain:   setting.Domain,
-				Path:     setting.AppSubUrl + "/",
+				//MaxAge:   600,
+				Domain: setting.Domain,
+				Path:   setting.AppSubUrl + "/",
 			}
 
 			ctx.Resp.Header().Add("Set-Cookie", cookie.String())

+ 3 - 3
pkg/services/auth/auth_token.go

@@ -46,9 +46,9 @@ func (s *UserAuthTokenService) UserAuthenticatedHook(user *models.User, c *model
 		Name:     sessionCookieKey,
 		Value:    url.QueryEscape(userToken.UnhashedToken),
 		HttpOnly: true,
-		MaxAge:   int(time.Minute * 10),
-		Domain:   setting.Domain,
-		Path:     setting.AppSubUrl + "/",
+		//MaxAge:   600,
+		Domain: setting.Domain,
+		Path:   setting.AppSubUrl + "/",
 	}
 
 	c.Resp.Header().Add("Set-Cookie", cookie.String())