file_reader_test.go 5.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238
  1. package dashboards
  2. import (
  3. "os"
  4. "path/filepath"
  5. "testing"
  6. "time"
  7. "github.com/grafana/grafana/pkg/bus"
  8. "github.com/grafana/grafana/pkg/models"
  9. "github.com/grafana/grafana/pkg/services/dashboards"
  10. "github.com/grafana/grafana/pkg/log"
  11. . "github.com/smartystreets/goconvey/convey"
  12. )
  13. var (
  14. defaultDashboards string = "./test-dashboards/folder-one"
  15. brokenDashboards string = "./test-dashboards/broken-dashboards"
  16. oneDashboard string = "./test-dashboards/one-dashboard"
  17. fakeRepo *fakeDashboardRepo
  18. )
  19. func TestDashboardFileReader(t *testing.T) {
  20. Convey("Dashboard file reader", t, func() {
  21. bus.ClearBusHandlers()
  22. fakeRepo = &fakeDashboardRepo{}
  23. bus.AddHandler("test", mockGetDashboardQuery)
  24. dashboards.SetRepository(fakeRepo)
  25. logger := log.New("test.logger")
  26. Convey("Reading dashboards from disk", func() {
  27. cfg := &DashboardsAsConfig{
  28. Name: "Default",
  29. Type: "file",
  30. OrgId: 1,
  31. Folder: "",
  32. Options: map[string]interface{}{},
  33. }
  34. Convey("Can read default dashboard", func() {
  35. cfg.Options["folder"] = defaultDashboards
  36. cfg.Folder = "Team A"
  37. reader, err := NewDashboardFileReader(cfg, logger)
  38. So(err, ShouldBeNil)
  39. err = reader.startWalkingDisk()
  40. So(err, ShouldBeNil)
  41. folders := 0
  42. dashboards := 0
  43. for _, i := range fakeRepo.inserted {
  44. if i.Dashboard.IsFolder {
  45. folders++
  46. } else {
  47. dashboards++
  48. }
  49. }
  50. So(dashboards, ShouldEqual, 2)
  51. So(folders, ShouldEqual, 1)
  52. })
  53. Convey("Should not update dashboards when db is newer", func() {
  54. cfg.Options["folder"] = oneDashboard
  55. fakeRepo.getDashboard = append(fakeRepo.getDashboard, &models.Dashboard{
  56. Updated: time.Now().Add(time.Hour),
  57. Slug: "grafana",
  58. })
  59. reader, err := NewDashboardFileReader(cfg, logger)
  60. So(err, ShouldBeNil)
  61. err = reader.startWalkingDisk()
  62. So(err, ShouldBeNil)
  63. So(len(fakeRepo.inserted), ShouldEqual, 0)
  64. })
  65. Convey("Can read default dashboard and replace old version in database", func() {
  66. cfg.Options["folder"] = oneDashboard
  67. stat, _ := os.Stat(oneDashboard + "/dashboard1.json")
  68. fakeRepo.getDashboard = append(fakeRepo.getDashboard, &models.Dashboard{
  69. Updated: stat.ModTime().AddDate(0, 0, -1),
  70. Slug: "grafana",
  71. })
  72. reader, err := NewDashboardFileReader(cfg, logger)
  73. So(err, ShouldBeNil)
  74. err = reader.startWalkingDisk()
  75. So(err, ShouldBeNil)
  76. So(len(fakeRepo.inserted), ShouldEqual, 1)
  77. })
  78. Convey("Invalid configuration should return error", func() {
  79. cfg := &DashboardsAsConfig{
  80. Name: "Default",
  81. Type: "file",
  82. OrgId: 1,
  83. Folder: "",
  84. }
  85. _, err := NewDashboardFileReader(cfg, logger)
  86. So(err, ShouldNotBeNil)
  87. })
  88. Convey("Broken dashboards should not cause error", func() {
  89. cfg.Options["folder"] = brokenDashboards
  90. _, err := NewDashboardFileReader(cfg, logger)
  91. So(err, ShouldBeNil)
  92. })
  93. })
  94. Convey("Should not create new folder if folder name is missing", func() {
  95. cfg := &DashboardsAsConfig{
  96. Name: "Default",
  97. Type: "file",
  98. OrgId: 1,
  99. Folder: "",
  100. Options: map[string]interface{}{
  101. "folder": defaultDashboards,
  102. },
  103. }
  104. _, err := getOrCreateFolderId(cfg, fakeRepo)
  105. So(err, ShouldEqual, ErrFolderNameMissing)
  106. })
  107. Convey("can get or Create dashboard folder", func() {
  108. cfg := &DashboardsAsConfig{
  109. Name: "Default",
  110. Type: "file",
  111. OrgId: 1,
  112. Folder: "TEAM A",
  113. Options: map[string]interface{}{
  114. "folder": defaultDashboards,
  115. },
  116. }
  117. folderId, err := getOrCreateFolderId(cfg, fakeRepo)
  118. So(err, ShouldBeNil)
  119. inserted := false
  120. for _, d := range fakeRepo.inserted {
  121. if d.Dashboard.IsFolder && d.Dashboard.Id == folderId {
  122. inserted = true
  123. }
  124. }
  125. So(len(fakeRepo.inserted), ShouldEqual, 1)
  126. So(inserted, ShouldBeTrue)
  127. })
  128. Convey("Walking the folder with dashboards", func() {
  129. cfg := &DashboardsAsConfig{
  130. Name: "Default",
  131. Type: "file",
  132. OrgId: 1,
  133. Folder: "",
  134. Options: map[string]interface{}{
  135. "folder": defaultDashboards,
  136. },
  137. }
  138. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  139. So(err, ShouldBeNil)
  140. Convey("should skip dirs that starts with .", func() {
  141. shouldSkip := reader.createWalk(reader, 0)("path", &FakeFileInfo{isDirectory: true, name: ".folder"}, nil)
  142. So(shouldSkip, ShouldEqual, filepath.SkipDir)
  143. })
  144. Convey("should keep walking if file is not .json", func() {
  145. shouldSkip := reader.createWalk(reader, 0)("path", &FakeFileInfo{isDirectory: true, name: "folder"}, nil)
  146. So(shouldSkip, ShouldBeNil)
  147. })
  148. })
  149. })
  150. }
  151. type FakeFileInfo struct {
  152. isDirectory bool
  153. name string
  154. }
  155. func (ffi *FakeFileInfo) IsDir() bool {
  156. return ffi.isDirectory
  157. }
  158. func (ffi FakeFileInfo) Size() int64 {
  159. return 1
  160. }
  161. func (ffi FakeFileInfo) Mode() os.FileMode {
  162. return 0777
  163. }
  164. func (ffi FakeFileInfo) Name() string {
  165. return ffi.name
  166. }
  167. func (ffi FakeFileInfo) ModTime() time.Time {
  168. return time.Time{}
  169. }
  170. func (ffi FakeFileInfo) Sys() interface{} {
  171. return nil
  172. }
  173. type fakeDashboardRepo struct {
  174. inserted []*dashboards.SaveDashboardItem
  175. getDashboard []*models.Dashboard
  176. }
  177. func (repo *fakeDashboardRepo) SaveDashboard(json *dashboards.SaveDashboardItem) (*models.Dashboard, error) {
  178. repo.inserted = append(repo.inserted, json)
  179. return json.Dashboard, nil
  180. }
  181. func mockGetDashboardQuery(cmd *models.GetDashboardQuery) error {
  182. for _, d := range fakeRepo.getDashboard {
  183. if d.Slug == cmd.Slug {
  184. cmd.Result = d
  185. return nil
  186. }
  187. }
  188. return models.ErrDashboardNotFound
  189. }