alert_rule_test.go 5.0 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211
  1. package sqlstore
  2. import (
  3. "testing"
  4. m "github.com/grafana/grafana/pkg/models"
  5. . "github.com/smartystreets/goconvey/convey"
  6. )
  7. func TestAlertingDataAccess(t *testing.T) {
  8. Convey("Testing Alerting data access", t, func() {
  9. InitTestDB(t)
  10. testDash := insertTestDashboard("dashboard with alerts", 1, "alert")
  11. items := []m.AlertRule{
  12. {
  13. PanelId: 1,
  14. DashboardId: testDash.Id,
  15. OrgId: testDash.OrgId,
  16. Query: "Query",
  17. QueryRefId: "A",
  18. WarnLevel: "> 30",
  19. CritLevel: "> 50",
  20. Interval: "10",
  21. Title: "Alerting title",
  22. Description: "Alerting description",
  23. QueryRange: "5m",
  24. Aggregator: "avg",
  25. State: "OK",
  26. },
  27. }
  28. cmd := m.SaveAlertsCommand{
  29. Alerts: &items,
  30. DashboardId: testDash.Id,
  31. OrgId: 1,
  32. UserId: 1,
  33. }
  34. err := SaveAlerts(&cmd)
  35. Convey("Can create one alert", func() {
  36. So(err, ShouldBeNil)
  37. query := &m.GetAlertChangesQuery{OrgId: 1}
  38. er := GetAlertRuleChanges(query)
  39. So(er, ShouldBeNil)
  40. So(len(query.Result), ShouldEqual, 1)
  41. })
  42. Convey("Can read properties", func() {
  43. alert, err2 := GetAlertsByDashboardAndPanelId(testDash.Id, 1)
  44. So(err2, ShouldBeNil)
  45. So(alert.Interval, ShouldEqual, "10")
  46. So(alert.WarnLevel, ShouldEqual, "> 30")
  47. So(alert.CritLevel, ShouldEqual, "> 50")
  48. So(alert.Query, ShouldEqual, "Query")
  49. So(alert.QueryRefId, ShouldEqual, "A")
  50. So(alert.Title, ShouldEqual, "Alerting title")
  51. So(alert.Description, ShouldEqual, "Alerting description")
  52. So(alert.QueryRange, ShouldEqual, "5m")
  53. So(alert.Aggregator, ShouldEqual, "avg")
  54. So(alert.State, ShouldEqual, "OK")
  55. })
  56. Convey("Alerts with same dashboard id and panel id should update", func() {
  57. modifiedItems := items
  58. modifiedItems[0].Query = "Updated Query"
  59. modifiedItems[0].State = "ALERT"
  60. modifiedCmd := m.SaveAlertsCommand{
  61. DashboardId: testDash.Id,
  62. OrgId: 1,
  63. UserId: 1,
  64. Alerts: &modifiedItems,
  65. }
  66. err := SaveAlerts(&modifiedCmd)
  67. Convey("Can save alerts with same dashboard and panel id", func() {
  68. So(err, ShouldBeNil)
  69. })
  70. Convey("Alerts should be updated", func() {
  71. alerts, err2 := GetAlertsByDashboardId(testDash.Id)
  72. So(err2, ShouldBeNil)
  73. So(len(alerts), ShouldEqual, 1)
  74. So(alerts[0].Query, ShouldEqual, "Updated Query")
  75. Convey("Alert state should not be updated", func() {
  76. So(alerts[0].State, ShouldEqual, "OK")
  77. })
  78. })
  79. Convey("Updates without changes should be ignored", func() {
  80. err3 := SaveAlerts(&modifiedCmd)
  81. So(err3, ShouldBeNil)
  82. query := &m.GetAlertChangesQuery{OrgId: 1}
  83. er := GetAlertRuleChanges(query)
  84. So(er, ShouldBeNil)
  85. So(len(query.Result), ShouldEqual, 2)
  86. })
  87. })
  88. Convey("Multiple alerts per dashboard", func() {
  89. multipleItems := []m.AlertRule{
  90. {
  91. DashboardId: testDash.Id,
  92. PanelId: 1,
  93. Query: "1",
  94. OrgId: 1,
  95. },
  96. {
  97. DashboardId: testDash.Id,
  98. PanelId: 2,
  99. Query: "2",
  100. OrgId: 1,
  101. },
  102. {
  103. DashboardId: testDash.Id,
  104. PanelId: 3,
  105. Query: "3",
  106. OrgId: 1,
  107. },
  108. }
  109. cmd.Alerts = &multipleItems
  110. err = SaveAlerts(&cmd)
  111. Convey("Should save 3 dashboards", func() {
  112. So(err, ShouldBeNil)
  113. alerts, err2 := GetAlertsByDashboardId(testDash.Id)
  114. So(err2, ShouldBeNil)
  115. So(len(alerts), ShouldEqual, 3)
  116. query := &m.GetAlertChangesQuery{OrgId: 1}
  117. er := GetAlertRuleChanges(query)
  118. So(er, ShouldBeNil)
  119. So(len(query.Result), ShouldEqual, 4)
  120. })
  121. Convey("should updated two dashboards and delete one", func() {
  122. missingOneAlert := multipleItems[:2]
  123. cmd.Alerts = &missingOneAlert
  124. err = SaveAlerts(&cmd)
  125. Convey("should delete the missing alert", func() {
  126. alerts, err2 := GetAlertsByDashboardId(testDash.Id)
  127. So(err2, ShouldBeNil)
  128. So(len(alerts), ShouldEqual, 2)
  129. })
  130. Convey("should add one more alert_rule_change", func() {
  131. query := &m.GetAlertChangesQuery{OrgId: 1}
  132. er := GetAlertRuleChanges(query)
  133. So(er, ShouldBeNil)
  134. So(len(query.Result), ShouldEqual, 6)
  135. })
  136. })
  137. })
  138. Convey("When dashboard is removed", func() {
  139. items := []m.AlertRule{
  140. {
  141. PanelId: 1,
  142. DashboardId: testDash.Id,
  143. Query: "Query",
  144. QueryRefId: "A",
  145. WarnLevel: "> 30",
  146. CritLevel: "> 50",
  147. Interval: "10",
  148. Title: "Alerting title",
  149. Description: "Alerting description",
  150. QueryRange: "5m",
  151. Aggregator: "avg",
  152. },
  153. }
  154. cmd := m.SaveAlertsCommand{
  155. Alerts: &items,
  156. DashboardId: testDash.Id,
  157. OrgId: 1,
  158. UserId: 1,
  159. }
  160. SaveAlerts(&cmd)
  161. err = DeleteDashboard(&m.DeleteDashboardCommand{
  162. OrgId: 1,
  163. Slug: testDash.Slug,
  164. })
  165. So(err, ShouldBeNil)
  166. Convey("Alerts should be removed", func() {
  167. alerts, err2 := GetAlertsByDashboardId(testDash.Id)
  168. So(testDash.Id, ShouldEqual, 1)
  169. So(err2, ShouldBeNil)
  170. So(len(alerts), ShouldEqual, 0)
  171. })
  172. })
  173. })
  174. }