file_reader_test.go 7.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295
  1. package dashboards
  2. import (
  3. "os"
  4. "path/filepath"
  5. "runtime"
  6. "testing"
  7. "time"
  8. "github.com/grafana/grafana/pkg/bus"
  9. "github.com/grafana/grafana/pkg/models"
  10. "github.com/grafana/grafana/pkg/services/dashboards"
  11. "github.com/grafana/grafana/pkg/log"
  12. . "github.com/smartystreets/goconvey/convey"
  13. )
  14. var (
  15. defaultDashboards = "testdata/test-dashboards/folder-one"
  16. brokenDashboards = "testdata/test-dashboards/broken-dashboards"
  17. oneDashboard = "testdata/test-dashboards/one-dashboard"
  18. containingId = "testdata/test-dashboards/containing-id"
  19. fakeService *fakeDashboardProvisioningService
  20. )
  21. func TestCreatingNewDashboardFileReader(t *testing.T) {
  22. Convey("creating new dashboard file reader", t, func() {
  23. cfg := &DashboardsAsConfig{
  24. Name: "Default",
  25. Type: "file",
  26. OrgId: 1,
  27. Folder: "",
  28. Options: map[string]interface{}{},
  29. }
  30. Convey("using path parameter", func() {
  31. cfg.Options["path"] = defaultDashboards
  32. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  33. So(err, ShouldBeNil)
  34. So(reader.Path, ShouldNotEqual, "")
  35. })
  36. Convey("using folder as options", func() {
  37. cfg.Options["folder"] = defaultDashboards
  38. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  39. So(err, ShouldBeNil)
  40. So(reader.Path, ShouldNotEqual, "")
  41. })
  42. Convey("using full path", func() {
  43. fullPath := "/var/lib/grafana/dashboards"
  44. if runtime.GOOS == "windows" {
  45. fullPath = `c:\var\lib\grafana`
  46. }
  47. cfg.Options["folder"] = fullPath
  48. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  49. So(err, ShouldBeNil)
  50. So(reader.Path, ShouldEqual, fullPath)
  51. So(filepath.IsAbs(reader.Path), ShouldBeTrue)
  52. })
  53. Convey("using relative path", func() {
  54. cfg.Options["folder"] = defaultDashboards
  55. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  56. So(err, ShouldBeNil)
  57. So(filepath.IsAbs(reader.Path), ShouldBeTrue)
  58. })
  59. })
  60. }
  61. func TestDashboardFileReader(t *testing.T) {
  62. Convey("Dashboard file reader", t, func() {
  63. bus.ClearBusHandlers()
  64. origNewDashboardProvisioningService := dashboards.NewProvisioningService
  65. fakeService = mockDashboardProvisioningService()
  66. bus.AddHandler("test", mockGetDashboardQuery)
  67. logger := log.New("test.logger")
  68. Convey("Reading dashboards from disk", func() {
  69. cfg := &DashboardsAsConfig{
  70. Name: "Default",
  71. Type: "file",
  72. OrgId: 1,
  73. Folder: "",
  74. Options: map[string]interface{}{},
  75. }
  76. Convey("Can read default dashboard", func() {
  77. cfg.Options["path"] = defaultDashboards
  78. cfg.Folder = "Team A"
  79. reader, err := NewDashboardFileReader(cfg, logger)
  80. So(err, ShouldBeNil)
  81. err = reader.startWalkingDisk()
  82. So(err, ShouldBeNil)
  83. folders := 0
  84. dashboards := 0
  85. for _, i := range fakeService.inserted {
  86. if i.Dashboard.IsFolder {
  87. folders++
  88. } else {
  89. dashboards++
  90. }
  91. }
  92. So(folders, ShouldEqual, 1)
  93. So(dashboards, ShouldEqual, 2)
  94. })
  95. Convey("Can read default dashboard and replace old version in database", func() {
  96. cfg.Options["path"] = oneDashboard
  97. stat, _ := os.Stat(oneDashboard + "/dashboard1.json")
  98. fakeService.getDashboard = append(fakeService.getDashboard, &models.Dashboard{
  99. Updated: stat.ModTime().AddDate(0, 0, -1),
  100. Slug: "grafana",
  101. })
  102. reader, err := NewDashboardFileReader(cfg, logger)
  103. So(err, ShouldBeNil)
  104. err = reader.startWalkingDisk()
  105. So(err, ShouldBeNil)
  106. So(len(fakeService.inserted), ShouldEqual, 1)
  107. })
  108. Convey("Overrides id from dashboard.json files", func() {
  109. cfg.Options["path"] = containingId
  110. reader, err := NewDashboardFileReader(cfg, logger)
  111. So(err, ShouldBeNil)
  112. err = reader.startWalkingDisk()
  113. So(err, ShouldBeNil)
  114. So(len(fakeService.inserted), ShouldEqual, 1)
  115. })
  116. Convey("Invalid configuration should return error", func() {
  117. cfg := &DashboardsAsConfig{
  118. Name: "Default",
  119. Type: "file",
  120. OrgId: 1,
  121. Folder: "",
  122. }
  123. _, err := NewDashboardFileReader(cfg, logger)
  124. So(err, ShouldNotBeNil)
  125. })
  126. Convey("Broken dashboards should not cause error", func() {
  127. cfg.Options["path"] = brokenDashboards
  128. _, err := NewDashboardFileReader(cfg, logger)
  129. So(err, ShouldBeNil)
  130. })
  131. })
  132. Convey("Should not create new folder if folder name is missing", func() {
  133. cfg := &DashboardsAsConfig{
  134. Name: "Default",
  135. Type: "file",
  136. OrgId: 1,
  137. Folder: "",
  138. Options: map[string]interface{}{
  139. "folder": defaultDashboards,
  140. },
  141. }
  142. _, err := getOrCreateFolderId(cfg, fakeService)
  143. So(err, ShouldEqual, ErrFolderNameMissing)
  144. })
  145. Convey("can get or Create dashboard folder", func() {
  146. cfg := &DashboardsAsConfig{
  147. Name: "Default",
  148. Type: "file",
  149. OrgId: 1,
  150. Folder: "TEAM A",
  151. Options: map[string]interface{}{
  152. "folder": defaultDashboards,
  153. },
  154. }
  155. folderId, err := getOrCreateFolderId(cfg, fakeService)
  156. So(err, ShouldBeNil)
  157. inserted := false
  158. for _, d := range fakeService.inserted {
  159. if d.Dashboard.IsFolder && d.Dashboard.Id == folderId {
  160. inserted = true
  161. }
  162. }
  163. So(len(fakeService.inserted), ShouldEqual, 1)
  164. So(inserted, ShouldBeTrue)
  165. })
  166. Convey("Walking the folder with dashboards", func() {
  167. noFiles := map[string]os.FileInfo{}
  168. Convey("should skip dirs that starts with .", func() {
  169. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: ".folder"}, nil)
  170. So(shouldSkip, ShouldEqual, filepath.SkipDir)
  171. })
  172. Convey("should keep walking if file is not .json", func() {
  173. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: "folder"}, nil)
  174. So(shouldSkip, ShouldBeNil)
  175. })
  176. })
  177. Reset(func() {
  178. dashboards.NewProvisioningService = origNewDashboardProvisioningService
  179. })
  180. })
  181. }
  182. type FakeFileInfo struct {
  183. isDirectory bool
  184. name string
  185. }
  186. func (ffi *FakeFileInfo) IsDir() bool {
  187. return ffi.isDirectory
  188. }
  189. func (ffi FakeFileInfo) Size() int64 {
  190. return 1
  191. }
  192. func (ffi FakeFileInfo) Mode() os.FileMode {
  193. return 0777
  194. }
  195. func (ffi FakeFileInfo) Name() string {
  196. return ffi.name
  197. }
  198. func (ffi FakeFileInfo) ModTime() time.Time {
  199. return time.Time{}
  200. }
  201. func (ffi FakeFileInfo) Sys() interface{} {
  202. return nil
  203. }
  204. func mockDashboardProvisioningService() *fakeDashboardProvisioningService {
  205. mock := fakeDashboardProvisioningService{}
  206. dashboards.NewProvisioningService = func() dashboards.DashboardProvisioningService {
  207. return &mock
  208. }
  209. return &mock
  210. }
  211. type fakeDashboardProvisioningService struct {
  212. inserted []*dashboards.SaveDashboardDTO
  213. provisioned []*models.DashboardProvisioning
  214. getDashboard []*models.Dashboard
  215. }
  216. func (s *fakeDashboardProvisioningService) GetProvisionedDashboardData(name string) ([]*models.DashboardProvisioning, error) {
  217. return s.provisioned, nil
  218. }
  219. func (s *fakeDashboardProvisioningService) SaveProvisionedDashboard(dto *dashboards.SaveDashboardDTO, provisioning *models.DashboardProvisioning) (*models.Dashboard, error) {
  220. s.inserted = append(s.inserted, dto)
  221. s.provisioned = append(s.provisioned, provisioning)
  222. return dto.Dashboard, nil
  223. }
  224. func (s *fakeDashboardProvisioningService) SaveFolderForProvisionedDashboards(dto *dashboards.SaveDashboardDTO) (*models.Dashboard, error) {
  225. s.inserted = append(s.inserted, dto)
  226. return dto.Dashboard, nil
  227. }
  228. func mockGetDashboardQuery(cmd *models.GetDashboardQuery) error {
  229. for _, d := range fakeService.getDashboard {
  230. if d.Slug == cmd.Slug {
  231. cmd.Result = d
  232. return nil
  233. }
  234. }
  235. return models.ErrDashboardNotFound
  236. }