team_test.go 8.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233
  1. package sqlstore
  2. import (
  3. "context"
  4. "fmt"
  5. "testing"
  6. . "github.com/smartystreets/goconvey/convey"
  7. m "github.com/grafana/grafana/pkg/models"
  8. )
  9. func TestTeamCommandsAndQueries(t *testing.T) {
  10. Convey("Testing Team commands & queries", t, func() {
  11. InitTestDB(t)
  12. Convey("Given saved users and two teams", func() {
  13. var userIds []int64
  14. for i := 0; i < 5; i++ {
  15. userCmd := &m.CreateUserCommand{
  16. Email: fmt.Sprint("user", i, "@test.com"),
  17. Name: fmt.Sprint("user", i),
  18. Login: fmt.Sprint("loginuser", i),
  19. }
  20. err := CreateUser(context.Background(), userCmd)
  21. So(err, ShouldBeNil)
  22. userIds = append(userIds, userCmd.Result.Id)
  23. }
  24. var testOrgId int64 = 1
  25. group1 := m.CreateTeamCommand{OrgId: testOrgId, Name: "group1 name", Email: "test1@test.com"}
  26. group2 := m.CreateTeamCommand{OrgId: testOrgId, Name: "group2 name", Email: "test2@test.com"}
  27. err := CreateTeam(&group1)
  28. So(err, ShouldBeNil)
  29. err = CreateTeam(&group2)
  30. So(err, ShouldBeNil)
  31. Convey("Should be able to create teams and add users", func() {
  32. query := &m.SearchTeamsQuery{OrgId: testOrgId, Name: "group1 name", Page: 1, Limit: 10}
  33. err = SearchTeams(query)
  34. So(err, ShouldBeNil)
  35. So(query.Page, ShouldEqual, 1)
  36. team1 := query.Result.Teams[0]
  37. So(team1.Name, ShouldEqual, "group1 name")
  38. So(team1.Email, ShouldEqual, "test1@test.com")
  39. So(team1.OrgId, ShouldEqual, testOrgId)
  40. err = AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team1.Id, UserId: userIds[0]})
  41. So(err, ShouldBeNil)
  42. err = AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team1.Id, UserId: userIds[1], External: true})
  43. So(err, ShouldBeNil)
  44. q1 := &m.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team1.Id}
  45. err = GetTeamMembers(q1)
  46. So(err, ShouldBeNil)
  47. So(q1.Result, ShouldHaveLength, 2)
  48. So(q1.Result[0].TeamId, ShouldEqual, team1.Id)
  49. So(q1.Result[0].Login, ShouldEqual, "loginuser0")
  50. So(q1.Result[0].OrgId, ShouldEqual, testOrgId)
  51. So(q1.Result[1].TeamId, ShouldEqual, team1.Id)
  52. So(q1.Result[1].Login, ShouldEqual, "loginuser1")
  53. So(q1.Result[1].OrgId, ShouldEqual, testOrgId)
  54. So(q1.Result[1].External, ShouldEqual, true)
  55. q2 := &m.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team1.Id, External: true}
  56. err = GetTeamMembers(q2)
  57. So(err, ShouldBeNil)
  58. So(q2.Result, ShouldHaveLength, 1)
  59. So(q2.Result[0].TeamId, ShouldEqual, team1.Id)
  60. So(q2.Result[0].Login, ShouldEqual, "loginuser1")
  61. So(q2.Result[0].OrgId, ShouldEqual, testOrgId)
  62. So(q2.Result[0].External, ShouldEqual, true)
  63. })
  64. Convey("Should be able to update users in a team", func() {
  65. userId := userIds[0]
  66. team := group1.Result
  67. addMemberCmd := m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team.Id, UserId: userId}
  68. err = AddTeamMember(&addMemberCmd)
  69. So(err, ShouldBeNil)
  70. qBeforeUpdate := &m.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team.Id}
  71. err = GetTeamMembers(qBeforeUpdate)
  72. So(err, ShouldBeNil)
  73. So(qBeforeUpdate.Result[0].Permission, ShouldEqual, 0)
  74. err = UpdateTeamMember(&m.UpdateTeamMemberCommand{
  75. UserId: userId,
  76. OrgId: testOrgId,
  77. TeamId: team.Id,
  78. Permission: m.PERMISSION_ADMIN,
  79. })
  80. So(err, ShouldBeNil)
  81. qAfterUpdate := &m.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team.Id}
  82. err = GetTeamMembers(qAfterUpdate)
  83. So(err, ShouldBeNil)
  84. So(qAfterUpdate.Result[0].Permission, ShouldEqual, m.PERMISSION_ADMIN)
  85. })
  86. Convey("Should default to member permission level when updating a user with invalid permission level", func() {
  87. userID := userIds[0]
  88. team := group1.Result
  89. addMemberCmd := m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team.Id, UserId: userID}
  90. err = AddTeamMember(&addMemberCmd)
  91. So(err, ShouldBeNil)
  92. qBeforeUpdate := &m.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team.Id}
  93. err = GetTeamMembers(qBeforeUpdate)
  94. So(err, ShouldBeNil)
  95. So(qBeforeUpdate.Result[0].Permission, ShouldEqual, 0)
  96. invalidPermissionLevel := m.PERMISSION_EDIT
  97. err = UpdateTeamMember(&m.UpdateTeamMemberCommand{
  98. UserId: userID,
  99. OrgId: testOrgId,
  100. TeamId: team.Id,
  101. Permission: invalidPermissionLevel,
  102. })
  103. So(err, ShouldBeNil)
  104. qAfterUpdate := &m.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team.Id}
  105. err = GetTeamMembers(qAfterUpdate)
  106. So(err, ShouldBeNil)
  107. So(qAfterUpdate.Result[0].Permission, ShouldEqual, 0)
  108. })
  109. Convey("Shouldn't be able to update a user not in the team.", func() {
  110. err = UpdateTeamMember(&m.UpdateTeamMemberCommand{
  111. UserId: 1,
  112. OrgId: testOrgId,
  113. TeamId: group1.Result.Id,
  114. Permission: m.PERMISSION_ADMIN,
  115. })
  116. So(err, ShouldEqual, m.ErrTeamMemberNotFound)
  117. })
  118. Convey("Should be able to search for teams", func() {
  119. query := &m.SearchTeamsQuery{OrgId: testOrgId, Query: "group", Page: 1}
  120. err = SearchTeams(query)
  121. So(err, ShouldBeNil)
  122. So(len(query.Result.Teams), ShouldEqual, 2)
  123. So(query.Result.TotalCount, ShouldEqual, 2)
  124. query2 := &m.SearchTeamsQuery{OrgId: testOrgId, Query: ""}
  125. err = SearchTeams(query2)
  126. So(err, ShouldBeNil)
  127. So(len(query2.Result.Teams), ShouldEqual, 2)
  128. })
  129. Convey("Should be able to return all teams a user is member of", func() {
  130. groupId := group2.Result.Id
  131. err := AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: groupId, UserId: userIds[0]})
  132. So(err, ShouldBeNil)
  133. query := &m.GetTeamsByUserQuery{OrgId: testOrgId, UserId: userIds[0]}
  134. err = GetTeamsByUser(query)
  135. So(err, ShouldBeNil)
  136. So(len(query.Result), ShouldEqual, 1)
  137. So(query.Result[0].Name, ShouldEqual, "group2 name")
  138. So(query.Result[0].Email, ShouldEqual, "test2@test.com")
  139. })
  140. Convey("Should be able to remove users from a group", func() {
  141. err = AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0]})
  142. So(err, ShouldBeNil)
  143. err = RemoveTeamMember(&m.RemoveTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0]})
  144. So(err, ShouldBeNil)
  145. q2 := &m.GetTeamMembersQuery{OrgId: testOrgId, TeamId: group1.Result.Id}
  146. err = GetTeamMembers(q2)
  147. So(err, ShouldBeNil)
  148. So(len(q2.Result), ShouldEqual, 0)
  149. })
  150. Convey("When ProtectLastAdmin is set to true", func() {
  151. err = AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], Permission: m.PERMISSION_ADMIN})
  152. So(err, ShouldBeNil)
  153. Convey("A user should not be able to remove the last admin", func() {
  154. err = RemoveTeamMember(&m.RemoveTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], ProtectLastAdmin: true})
  155. So(err, ShouldEqual, m.ErrLastTeamAdmin)
  156. })
  157. Convey("A user should be able to remove an admin if there are other admins", func() {
  158. AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[1], Permission: m.PERMISSION_ADMIN})
  159. err = RemoveTeamMember(&m.RemoveTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], ProtectLastAdmin: true})
  160. So(err, ShouldEqual, nil)
  161. })
  162. Convey("A user should not be able to remove the admin permission for the last admin", func() {
  163. err = UpdateTeamMember(&m.UpdateTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], Permission: 0, ProtectLastAdmin: true})
  164. So(err, ShouldEqual, m.ErrLastTeamAdmin)
  165. })
  166. Convey("A user should be able to remove the admin permission if there are other admins", func() {
  167. AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[1], Permission: m.PERMISSION_ADMIN})
  168. err = UpdateTeamMember(&m.UpdateTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], Permission: 0, ProtectLastAdmin: true})
  169. So(err, ShouldEqual, nil)
  170. })
  171. })
  172. Convey("Should be able to remove a group with users and permissions", func() {
  173. groupId := group2.Result.Id
  174. err := AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: groupId, UserId: userIds[1]})
  175. So(err, ShouldBeNil)
  176. err = AddTeamMember(&m.AddTeamMemberCommand{OrgId: testOrgId, TeamId: groupId, UserId: userIds[2]})
  177. So(err, ShouldBeNil)
  178. err = testHelperUpdateDashboardAcl(1, m.DashboardAcl{DashboardId: 1, OrgId: testOrgId, Permission: m.PERMISSION_EDIT, TeamId: groupId})
  179. So(err, ShouldBeNil)
  180. err = DeleteTeam(&m.DeleteTeamCommand{OrgId: testOrgId, Id: groupId})
  181. So(err, ShouldBeNil)
  182. query := &m.GetTeamByIdQuery{OrgId: testOrgId, Id: groupId}
  183. err = GetTeamById(query)
  184. So(err, ShouldEqual, m.ErrTeamNotFound)
  185. permQuery := &m.GetDashboardAclInfoListQuery{DashboardId: 1, OrgId: testOrgId}
  186. err = GetDashboardAclInfoList(permQuery)
  187. So(err, ShouldBeNil)
  188. So(len(permQuery.Result), ShouldEqual, 0)
  189. })
  190. })
  191. })
  192. }