alert_rule_test.go 5.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226
  1. package sqlstore
  2. import (
  3. "testing"
  4. m "github.com/grafana/grafana/pkg/models"
  5. . "github.com/smartystreets/goconvey/convey"
  6. )
  7. func TestAlertingDataAccess(t *testing.T) {
  8. Convey("Testing Alerting data access", t, func() {
  9. InitTestDB(t)
  10. testDash := insertTestDashboard("dashboard with alerts", 1, "alert")
  11. items := []m.AlertRule{
  12. {
  13. PanelId: 1,
  14. DashboardId: testDash.Id,
  15. OrgId: testDash.OrgId,
  16. Query: "Query",
  17. QueryRefId: "A",
  18. WarnLevel: 30,
  19. CritLevel: 50,
  20. WarnOperator: ">",
  21. CritOperator: ">",
  22. Interval: "10",
  23. Title: "Alerting title",
  24. Description: "Alerting description",
  25. QueryRange: "5m",
  26. Aggregator: "avg",
  27. State: "OK",
  28. },
  29. }
  30. cmd := m.SaveAlertsCommand{
  31. Alerts: &items,
  32. DashboardId: testDash.Id,
  33. OrgId: 1,
  34. UserId: 1,
  35. }
  36. err := SaveAlerts(&cmd)
  37. Convey("Can create one alert", func() {
  38. So(err, ShouldBeNil)
  39. query := &m.GetAlertChangesQuery{OrgId: 1}
  40. er := GetAlertRuleChanges(query)
  41. So(er, ShouldBeNil)
  42. So(len(query.Result), ShouldEqual, 1)
  43. })
  44. Convey("Can read properties", func() {
  45. query := m.GetAlertForPanelQuery{
  46. DashboardId: testDash.Id,
  47. PanelId: 1,
  48. }
  49. err2 := GetAlertsByDashboardAndPanelId(&query)
  50. So(err2, ShouldBeNil)
  51. So(query.Result.Interval, ShouldEqual, "10")
  52. So(query.Result.WarnLevel, ShouldEqual, 30)
  53. So(query.Result.CritLevel, ShouldEqual, 50)
  54. So(query.Result.WarnOperator, ShouldEqual, ">")
  55. So(query.Result.CritOperator, ShouldEqual, ">")
  56. So(query.Result.Query, ShouldEqual, "Query")
  57. So(query.Result.QueryRefId, ShouldEqual, "A")
  58. So(query.Result.Title, ShouldEqual, "Alerting title")
  59. So(query.Result.Description, ShouldEqual, "Alerting description")
  60. So(query.Result.QueryRange, ShouldEqual, "5m")
  61. So(query.Result.Aggregator, ShouldEqual, "avg")
  62. So(query.Result.State, ShouldEqual, "OK")
  63. })
  64. Convey("Alerts with same dashboard id and panel id should update", func() {
  65. modifiedItems := items
  66. modifiedItems[0].Query = "Updated Query"
  67. modifiedItems[0].State = "ALERT"
  68. modifiedCmd := m.SaveAlertsCommand{
  69. DashboardId: testDash.Id,
  70. OrgId: 1,
  71. UserId: 1,
  72. Alerts: &modifiedItems,
  73. }
  74. err := SaveAlerts(&modifiedCmd)
  75. Convey("Can save alerts with same dashboard and panel id", func() {
  76. So(err, ShouldBeNil)
  77. })
  78. Convey("Alerts should be updated", func() {
  79. query := m.GetAlertsForDashboardQuery{DashboardId: testDash.Id}
  80. err2 := GetAlertsByDashboardId(&query)
  81. So(err2, ShouldBeNil)
  82. So(len(query.Result), ShouldEqual, 1)
  83. So(query.Result[0].Query, ShouldEqual, "Updated Query")
  84. Convey("Alert state should not be updated", func() {
  85. So(query.Result[0].State, ShouldEqual, "OK")
  86. })
  87. })
  88. Convey("Updates without changes should be ignored", func() {
  89. err3 := SaveAlerts(&modifiedCmd)
  90. So(err3, ShouldBeNil)
  91. query := &m.GetAlertChangesQuery{OrgId: 1}
  92. er := GetAlertRuleChanges(query)
  93. So(er, ShouldBeNil)
  94. So(len(query.Result), ShouldEqual, 2)
  95. })
  96. })
  97. Convey("Multiple alerts per dashboard", func() {
  98. multipleItems := []m.AlertRule{
  99. {
  100. DashboardId: testDash.Id,
  101. PanelId: 1,
  102. Query: "1",
  103. OrgId: 1,
  104. },
  105. {
  106. DashboardId: testDash.Id,
  107. PanelId: 2,
  108. Query: "2",
  109. OrgId: 1,
  110. },
  111. {
  112. DashboardId: testDash.Id,
  113. PanelId: 3,
  114. Query: "3",
  115. OrgId: 1,
  116. },
  117. }
  118. cmd.Alerts = &multipleItems
  119. err = SaveAlerts(&cmd)
  120. Convey("Should save 3 dashboards", func() {
  121. So(err, ShouldBeNil)
  122. queryForDashboard := m.GetAlertsForDashboardQuery{DashboardId: testDash.Id}
  123. err2 := GetAlertsByDashboardId(&queryForDashboard)
  124. So(err2, ShouldBeNil)
  125. So(len(queryForDashboard.Result), ShouldEqual, 3)
  126. query := &m.GetAlertChangesQuery{OrgId: 1}
  127. er := GetAlertRuleChanges(query)
  128. So(er, ShouldBeNil)
  129. So(len(query.Result), ShouldEqual, 4)
  130. })
  131. Convey("should updated two dashboards and delete one", func() {
  132. missingOneAlert := multipleItems[:2]
  133. cmd.Alerts = &missingOneAlert
  134. err = SaveAlerts(&cmd)
  135. Convey("should delete the missing alert", func() {
  136. query := m.GetAlertsForDashboardQuery{DashboardId: testDash.Id}
  137. err2 := GetAlertsByDashboardId(&query)
  138. So(err2, ShouldBeNil)
  139. So(len(query.Result), ShouldEqual, 2)
  140. })
  141. Convey("should add one more alert_rule_change", func() {
  142. query := &m.GetAlertChangesQuery{OrgId: 1}
  143. er := GetAlertRuleChanges(query)
  144. So(er, ShouldBeNil)
  145. So(len(query.Result), ShouldEqual, 6)
  146. })
  147. })
  148. })
  149. Convey("When dashboard is removed", func() {
  150. items := []m.AlertRule{
  151. {
  152. PanelId: 1,
  153. DashboardId: testDash.Id,
  154. Query: "Query",
  155. QueryRefId: "A",
  156. WarnLevel: 30,
  157. CritLevel: 50,
  158. WarnOperator: ">",
  159. CritOperator: ">",
  160. Interval: "10",
  161. Title: "Alerting title",
  162. Description: "Alerting description",
  163. QueryRange: "5m",
  164. Aggregator: "avg",
  165. },
  166. }
  167. cmd := m.SaveAlertsCommand{
  168. Alerts: &items,
  169. DashboardId: testDash.Id,
  170. OrgId: 1,
  171. UserId: 1,
  172. }
  173. SaveAlerts(&cmd)
  174. err = DeleteDashboard(&m.DeleteDashboardCommand{
  175. OrgId: 1,
  176. Slug: testDash.Slug,
  177. })
  178. So(err, ShouldBeNil)
  179. Convey("Alerts should be removed", func() {
  180. query := m.GetAlertsForDashboardQuery{DashboardId: testDash.Id}
  181. err2 := GetAlertsByDashboardId(&query)
  182. So(testDash.Id, ShouldEqual, 1)
  183. So(err2, ShouldBeNil)
  184. So(len(query.Result), ShouldEqual, 0)
  185. })
  186. })
  187. })
  188. }