ldap_debug_test.go 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566
  1. package api
  2. import (
  3. "context"
  4. "errors"
  5. "net/http"
  6. "net/http/httptest"
  7. "testing"
  8. "github.com/grafana/grafana/pkg/bus"
  9. "github.com/grafana/grafana/pkg/models"
  10. "github.com/grafana/grafana/pkg/services/ldap"
  11. "github.com/grafana/grafana/pkg/services/multildap"
  12. "github.com/grafana/grafana/pkg/setting"
  13. "github.com/stretchr/testify/assert"
  14. "github.com/stretchr/testify/require"
  15. )
  16. type LDAPMock struct {
  17. Results []*models.ExternalUserInfo
  18. }
  19. type TokenServiceMock struct {
  20. }
  21. var userSearchResult *models.ExternalUserInfo
  22. var userSearchConfig ldap.ServerConfig
  23. var userSearchError error
  24. var pingResult []*multildap.ServerStatus
  25. var pingError error
  26. func (m *LDAPMock) Ping() ([]*multildap.ServerStatus, error) {
  27. return pingResult, pingError
  28. }
  29. func (m *LDAPMock) Login(query *models.LoginUserQuery) (*models.ExternalUserInfo, error) {
  30. return &models.ExternalUserInfo{}, nil
  31. }
  32. func (m *LDAPMock) Users(logins []string) ([]*models.ExternalUserInfo, error) {
  33. s := []*models.ExternalUserInfo{}
  34. return s, nil
  35. }
  36. func (m *LDAPMock) User(login string) (*models.ExternalUserInfo, ldap.ServerConfig, error) {
  37. return userSearchResult, userSearchConfig, userSearchError
  38. }
  39. func (ts *TokenServiceMock) RevokeAllUserTokens(ctx context.Context, userId int64) error {
  40. return nil
  41. }
  42. //***
  43. // GetUserFromLDAP tests
  44. //***
  45. func getUserFromLDAPContext(t *testing.T, requestURL string) *scenarioContext {
  46. t.Helper()
  47. sc := setupScenarioContext(requestURL)
  48. ldap := setting.LDAPEnabled
  49. setting.LDAPEnabled = true
  50. defer func() { setting.LDAPEnabled = ldap }()
  51. hs := &HTTPServer{Cfg: setting.NewCfg()}
  52. sc.defaultHandler = Wrap(func(c *models.ReqContext) Response {
  53. sc.context = c
  54. return hs.GetUserFromLDAP(c)
  55. })
  56. sc.m.Get("/api/admin/ldap/:username", sc.defaultHandler)
  57. sc.resp = httptest.NewRecorder()
  58. req, _ := http.NewRequest(http.MethodGet, requestURL, nil)
  59. sc.req = req
  60. sc.exec()
  61. return sc
  62. }
  63. func TestGetUserFromLDAPApiEndpoint_UserNotFound(t *testing.T) {
  64. getLDAPConfig = func() (*ldap.Config, error) {
  65. return &ldap.Config{}, nil
  66. }
  67. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  68. return &LDAPMock{}
  69. }
  70. userSearchResult = nil
  71. sc := getUserFromLDAPContext(t, "/api/admin/ldap/user-that-does-not-exist")
  72. require.Equal(t, sc.resp.Code, http.StatusNotFound)
  73. assert.JSONEq(t, "{\"message\":\"No user was found on the LDAP server(s)\"}", sc.resp.Body.String())
  74. }
  75. func TestGetUserFromLDAPApiEndpoint_OrgNotfound(t *testing.T) {
  76. isAdmin := true
  77. userSearchResult = &models.ExternalUserInfo{
  78. Name: "John Doe",
  79. Email: "john.doe@example.com",
  80. Login: "johndoe",
  81. OrgRoles: map[int64]models.RoleType{1: models.ROLE_ADMIN, 2: models.ROLE_VIEWER},
  82. IsGrafanaAdmin: &isAdmin,
  83. }
  84. userSearchConfig = ldap.ServerConfig{
  85. Attr: ldap.AttributeMap{
  86. Name: "ldap-name",
  87. Surname: "ldap-surname",
  88. Email: "ldap-email",
  89. Username: "ldap-username",
  90. },
  91. Groups: []*ldap.GroupToOrgRole{
  92. {
  93. GroupDN: "cn=admins,ou=groups,dc=grafana,dc=org",
  94. OrgID: 1,
  95. OrgRole: models.ROLE_ADMIN,
  96. },
  97. {
  98. GroupDN: "cn=admins,ou=groups,dc=grafana2,dc=org",
  99. OrgID: 2,
  100. OrgRole: models.ROLE_VIEWER,
  101. },
  102. },
  103. }
  104. mockOrgSearchResult := []*models.OrgDTO{
  105. {Id: 1, Name: "Main Org."},
  106. }
  107. bus.AddHandler("test", func(query *models.SearchOrgsQuery) error {
  108. query.Result = mockOrgSearchResult
  109. return nil
  110. })
  111. getLDAPConfig = func() (*ldap.Config, error) {
  112. return &ldap.Config{}, nil
  113. }
  114. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  115. return &LDAPMock{}
  116. }
  117. sc := getUserFromLDAPContext(t, "/api/admin/ldap/johndoe")
  118. require.Equal(t, sc.resp.Code, http.StatusBadRequest)
  119. expected := `
  120. {
  121. "error": "Unable to find organization with ID '2'",
  122. "message": "An oganization was not found - Please verify your LDAP configuration"
  123. }
  124. `
  125. assert.JSONEq(t, expected, sc.resp.Body.String())
  126. }
  127. func TestGetUserFromLDAPApiEndpoint(t *testing.T) {
  128. isAdmin := true
  129. userSearchResult = &models.ExternalUserInfo{
  130. Name: "John Doe",
  131. Email: "john.doe@example.com",
  132. Login: "johndoe",
  133. OrgRoles: map[int64]models.RoleType{1: models.ROLE_ADMIN},
  134. IsGrafanaAdmin: &isAdmin,
  135. }
  136. userSearchConfig = ldap.ServerConfig{
  137. Attr: ldap.AttributeMap{
  138. Name: "ldap-name",
  139. Surname: "ldap-surname",
  140. Email: "ldap-email",
  141. Username: "ldap-username",
  142. },
  143. Groups: []*ldap.GroupToOrgRole{
  144. {
  145. GroupDN: "cn=admins,ou=groups,dc=grafana,dc=org",
  146. OrgID: 1,
  147. OrgRole: models.ROLE_ADMIN,
  148. },
  149. },
  150. }
  151. mockOrgSearchResult := []*models.OrgDTO{
  152. {Id: 1, Name: "Main Org."},
  153. }
  154. bus.AddHandler("test", func(query *models.SearchOrgsQuery) error {
  155. query.Result = mockOrgSearchResult
  156. return nil
  157. })
  158. getLDAPConfig = func() (*ldap.Config, error) {
  159. return &ldap.Config{}, nil
  160. }
  161. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  162. return &LDAPMock{}
  163. }
  164. sc := getUserFromLDAPContext(t, "/api/admin/ldap/johndoe")
  165. require.Equal(t, sc.resp.Code, http.StatusOK)
  166. expected := `
  167. {
  168. "name": {
  169. "cfgAttrValue": "ldap-name", "ldapValue": "John"
  170. },
  171. "surname": {
  172. "cfgAttrValue": "ldap-surname", "ldapValue": "Doe"
  173. },
  174. "email": {
  175. "cfgAttrValue": "ldap-email", "ldapValue": "john.doe@example.com"
  176. },
  177. "login": {
  178. "cfgAttrValue": "ldap-username", "ldapValue": "johndoe"
  179. },
  180. "isGrafanaAdmin": true,
  181. "isDisabled": false,
  182. "roles": [
  183. { "orgId": 1, "orgRole": "Admin", "orgName": "Main Org.", "groupDN": "cn=admins,ou=groups,dc=grafana,dc=org" }
  184. ],
  185. "teams": null
  186. }
  187. `
  188. assert.JSONEq(t, expected, sc.resp.Body.String())
  189. }
  190. func TestGetUserFromLDAPApiEndpoint_WithTeamHandler(t *testing.T) {
  191. isAdmin := true
  192. userSearchResult = &models.ExternalUserInfo{
  193. Name: "John Doe",
  194. Email: "john.doe@example.com",
  195. Login: "johndoe",
  196. OrgRoles: map[int64]models.RoleType{1: models.ROLE_ADMIN},
  197. IsGrafanaAdmin: &isAdmin,
  198. }
  199. userSearchConfig = ldap.ServerConfig{
  200. Attr: ldap.AttributeMap{
  201. Name: "ldap-name",
  202. Surname: "ldap-surname",
  203. Email: "ldap-email",
  204. Username: "ldap-username",
  205. },
  206. Groups: []*ldap.GroupToOrgRole{
  207. {
  208. GroupDN: "cn=admins,ou=groups,dc=grafana,dc=org",
  209. OrgID: 1,
  210. OrgRole: models.ROLE_ADMIN,
  211. },
  212. },
  213. }
  214. mockOrgSearchResult := []*models.OrgDTO{
  215. {Id: 1, Name: "Main Org."},
  216. }
  217. bus.AddHandler("test", func(query *models.SearchOrgsQuery) error {
  218. query.Result = mockOrgSearchResult
  219. return nil
  220. })
  221. bus.AddHandler("test", func(cmd *models.GetTeamsForLDAPGroupCommand) error {
  222. cmd.Result = []models.TeamOrgGroupDTO{}
  223. return nil
  224. })
  225. getLDAPConfig = func() (*ldap.Config, error) {
  226. return &ldap.Config{}, nil
  227. }
  228. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  229. return &LDAPMock{}
  230. }
  231. sc := getUserFromLDAPContext(t, "/api/admin/ldap/johndoe")
  232. require.Equal(t, sc.resp.Code, http.StatusOK)
  233. expected := `
  234. {
  235. "name": {
  236. "cfgAttrValue": "ldap-name", "ldapValue": "John"
  237. },
  238. "surname": {
  239. "cfgAttrValue": "ldap-surname", "ldapValue": "Doe"
  240. },
  241. "email": {
  242. "cfgAttrValue": "ldap-email", "ldapValue": "john.doe@example.com"
  243. },
  244. "login": {
  245. "cfgAttrValue": "ldap-username", "ldapValue": "johndoe"
  246. },
  247. "isGrafanaAdmin": true,
  248. "isDisabled": false,
  249. "roles": [
  250. { "orgId": 1, "orgRole": "Admin", "orgName": "Main Org.", "groupDN": "cn=admins,ou=groups,dc=grafana,dc=org" }
  251. ],
  252. "teams": []
  253. }
  254. `
  255. assert.JSONEq(t, expected, sc.resp.Body.String())
  256. }
  257. //***
  258. // GetLDAPStatus tests
  259. //***
  260. func getLDAPStatusContext(t *testing.T) *scenarioContext {
  261. t.Helper()
  262. requestURL := "/api/admin/ldap/status"
  263. sc := setupScenarioContext(requestURL)
  264. ldap := setting.LDAPEnabled
  265. setting.LDAPEnabled = true
  266. defer func() { setting.LDAPEnabled = ldap }()
  267. hs := &HTTPServer{Cfg: setting.NewCfg()}
  268. sc.defaultHandler = Wrap(func(c *models.ReqContext) Response {
  269. sc.context = c
  270. return hs.GetLDAPStatus(c)
  271. })
  272. sc.m.Get("/api/admin/ldap/status", sc.defaultHandler)
  273. sc.resp = httptest.NewRecorder()
  274. req, _ := http.NewRequest(http.MethodGet, requestURL, nil)
  275. sc.req = req
  276. sc.exec()
  277. return sc
  278. }
  279. func TestGetLDAPStatusApiEndpoint(t *testing.T) {
  280. pingResult = []*multildap.ServerStatus{
  281. {Host: "10.0.0.3", Port: 361, Available: true, Error: nil},
  282. {Host: "10.0.0.3", Port: 362, Available: true, Error: nil},
  283. {Host: "10.0.0.5", Port: 361, Available: false, Error: errors.New("something is awfully wrong")},
  284. }
  285. getLDAPConfig = func() (*ldap.Config, error) {
  286. return &ldap.Config{}, nil
  287. }
  288. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  289. return &LDAPMock{}
  290. }
  291. sc := getLDAPStatusContext(t)
  292. require.Equal(t, http.StatusOK, sc.resp.Code)
  293. expected := `
  294. [
  295. { "host": "10.0.0.3", "port": 361, "available": true, "error": "" },
  296. { "host": "10.0.0.3", "port": 362, "available": true, "error": "" },
  297. { "host": "10.0.0.5", "port": 361, "available": false, "error": "something is awfully wrong" }
  298. ]
  299. `
  300. assert.JSONEq(t, expected, sc.resp.Body.String())
  301. }
  302. //***
  303. // PostSyncUserWithLDAP tests
  304. //***
  305. func postSyncUserWithLDAPContext(t *testing.T, requestURL string) *scenarioContext {
  306. t.Helper()
  307. sc := setupScenarioContext(requestURL)
  308. ldap := setting.LDAPEnabled
  309. setting.LDAPEnabled = true
  310. defer func() { setting.LDAPEnabled = ldap }()
  311. hs := &HTTPServer{Cfg: setting.NewCfg()}
  312. sc.defaultHandler = Wrap(func(c *models.ReqContext) Response {
  313. sc.context = c
  314. return hs.PostSyncUserWithLDAP(c)
  315. })
  316. sc.m.Post("/api/admin/ldap/sync/:id", sc.defaultHandler)
  317. sc.resp = httptest.NewRecorder()
  318. req, _ := http.NewRequest(http.MethodPost, requestURL, nil)
  319. sc.req = req
  320. sc.exec()
  321. return sc
  322. }
  323. func TestPostSyncUserWithLDAPAPIEndpoint_Success(t *testing.T) {
  324. getLDAPConfig = func() (*ldap.Config, error) {
  325. return &ldap.Config{}, nil
  326. }
  327. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  328. return &LDAPMock{}
  329. }
  330. userSearchResult = &models.ExternalUserInfo{
  331. Login: "ldap-daniel",
  332. }
  333. bus.AddHandler("test", func(cmd *models.UpsertUserCommand) error {
  334. require.Equal(t, "ldap-daniel", cmd.ExternalUser.Login)
  335. return nil
  336. })
  337. bus.AddHandler("test", func(q *models.GetUserByIdQuery) error {
  338. require.Equal(t, q.Id, int64(34))
  339. q.Result = &models.User{Login: "ldap-daniel", Id: 34}
  340. return nil
  341. })
  342. bus.AddHandler("test", func(q *models.GetAuthInfoQuery) error {
  343. require.Equal(t, q.UserId, int64(34))
  344. require.Equal(t, q.AuthModule, models.AuthModuleLDAP)
  345. return nil
  346. })
  347. sc := postSyncUserWithLDAPContext(t, "/api/admin/ldap/sync/34")
  348. assert.Equal(t, http.StatusOK, sc.resp.Code)
  349. expected := `
  350. {
  351. "message": "User synced successfully"
  352. }
  353. `
  354. assert.JSONEq(t, expected, sc.resp.Body.String())
  355. }
  356. func TestPostSyncUserWithLDAPAPIEndpoint_WhenUserNotFound(t *testing.T) {
  357. getLDAPConfig = func() (*ldap.Config, error) {
  358. return &ldap.Config{}, nil
  359. }
  360. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  361. return &LDAPMock{}
  362. }
  363. bus.AddHandler("test", func(q *models.GetUserByIdQuery) error {
  364. require.Equal(t, q.Id, int64(34))
  365. return models.ErrUserNotFound
  366. })
  367. sc := postSyncUserWithLDAPContext(t, "/api/admin/ldap/sync/34")
  368. assert.Equal(t, http.StatusNotFound, sc.resp.Code)
  369. expected := `
  370. {
  371. "message": "User not found"
  372. }
  373. `
  374. assert.JSONEq(t, expected, sc.resp.Body.String())
  375. }
  376. func TestPostSyncUserWithLDAPAPIEndpoint_WhenGrafanaAdmin(t *testing.T) {
  377. getLDAPConfig = func() (*ldap.Config, error) {
  378. return &ldap.Config{}, nil
  379. }
  380. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  381. return &LDAPMock{}
  382. }
  383. userSearchError = ldap.ErrCouldNotFindUser
  384. admin := setting.AdminUser
  385. setting.AdminUser = "ldap-daniel"
  386. defer func() { setting.AdminUser = admin }()
  387. bus.AddHandler("test", func(q *models.GetUserByIdQuery) error {
  388. require.Equal(t, q.Id, int64(34))
  389. q.Result = &models.User{Login: "ldap-daniel", Id: 34}
  390. return nil
  391. })
  392. bus.AddHandler("test", func(q *models.GetAuthInfoQuery) error {
  393. require.Equal(t, q.UserId, int64(34))
  394. require.Equal(t, q.AuthModule, models.AuthModuleLDAP)
  395. return nil
  396. })
  397. sc := postSyncUserWithLDAPContext(t, "/api/admin/ldap/sync/34")
  398. assert.Equal(t, http.StatusBadRequest, sc.resp.Code)
  399. expected := `
  400. {
  401. "error": "Can't find user in LDAP",
  402. "message": "Refusing to sync grafana super admin \"ldap-daniel\" - it would be disabled"
  403. }
  404. `
  405. assert.JSONEq(t, expected, sc.resp.Body.String())
  406. }
  407. func TestPostSyncUserWithLDAPAPIEndpoint_WhenUserNotInLDAP(t *testing.T) {
  408. getLDAPConfig = func() (*ldap.Config, error) {
  409. return &ldap.Config{}, nil
  410. }
  411. tokenService = &TokenServiceMock{}
  412. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  413. return &LDAPMock{}
  414. }
  415. userSearchResult = nil
  416. bus.AddHandler("test", func(cmd *models.UpsertUserCommand) error {
  417. require.Equal(t, "ldap-daniel", cmd.ExternalUser.Login)
  418. return nil
  419. })
  420. bus.AddHandler("test", func(q *models.GetUserByIdQuery) error {
  421. require.Equal(t, q.Id, int64(34))
  422. q.Result = &models.User{Login: "ldap-daniel", Id: 34}
  423. return nil
  424. })
  425. bus.AddHandler("test", func(q *models.GetExternalUserInfoByLoginQuery) error {
  426. assert.Equal(t, "ldap-daniel", q.LoginOrEmail)
  427. q.Result = &models.ExternalUserInfo{IsDisabled: true, UserId: 34}
  428. return nil
  429. })
  430. bus.AddHandler("test", func(cmd *models.DisableUserCommand) error {
  431. assert.Equal(t, 34, cmd.UserId)
  432. return nil
  433. })
  434. sc := postSyncUserWithLDAPContext(t, "/api/admin/ldap/sync/34")
  435. assert.Equal(t, http.StatusOK, sc.resp.Code)
  436. expected := `
  437. {
  438. "message": "User disabled without any updates in the information"
  439. }
  440. `
  441. assert.JSONEq(t, expected, sc.resp.Body.String())
  442. }