ldap_debug_test.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569
  1. package api
  2. import (
  3. "context"
  4. "errors"
  5. "net/http"
  6. "net/http/httptest"
  7. "testing"
  8. "github.com/grafana/grafana/pkg/bus"
  9. "github.com/grafana/grafana/pkg/models"
  10. "github.com/grafana/grafana/pkg/services/ldap"
  11. "github.com/grafana/grafana/pkg/services/multildap"
  12. "github.com/grafana/grafana/pkg/setting"
  13. "github.com/stretchr/testify/assert"
  14. "github.com/stretchr/testify/require"
  15. )
  16. type LDAPMock struct {
  17. Results []*models.ExternalUserInfo
  18. }
  19. type TokenServiceMock struct {
  20. }
  21. var userSearchResult *models.ExternalUserInfo
  22. var userSearchConfig ldap.ServerConfig
  23. var userSearchError error
  24. var pingResult []*multildap.ServerStatus
  25. var pingError error
  26. func (m *LDAPMock) Ping() ([]*multildap.ServerStatus, error) {
  27. return pingResult, pingError
  28. }
  29. func (m *LDAPMock) Login(query *models.LoginUserQuery) (*models.ExternalUserInfo, error) {
  30. return &models.ExternalUserInfo{}, nil
  31. }
  32. func (m *LDAPMock) Users(logins []string) ([]*models.ExternalUserInfo, error) {
  33. s := []*models.ExternalUserInfo{}
  34. return s, nil
  35. }
  36. func (m *LDAPMock) User(login string) (*models.ExternalUserInfo, ldap.ServerConfig, error) {
  37. return userSearchResult, userSearchConfig, userSearchError
  38. }
  39. func (ts *TokenServiceMock) RevokeAllUserTokens(ctx context.Context, userId int64) error {
  40. return nil
  41. }
  42. //***
  43. // GetUserFromLDAP tests
  44. //***
  45. func getUserFromLDAPContext(t *testing.T, requestURL string) *scenarioContext {
  46. t.Helper()
  47. sc := setupScenarioContext(requestURL)
  48. ldap := setting.LDAPEnabled
  49. setting.LDAPEnabled = true
  50. defer func() { setting.LDAPEnabled = ldap }()
  51. hs := &HTTPServer{Cfg: setting.NewCfg()}
  52. sc.defaultHandler = Wrap(func(c *models.ReqContext) Response {
  53. sc.context = c
  54. return hs.GetUserFromLDAP(c)
  55. })
  56. sc.m.Get("/api/admin/ldap/:username", sc.defaultHandler)
  57. sc.resp = httptest.NewRecorder()
  58. req, _ := http.NewRequest(http.MethodGet, requestURL, nil)
  59. sc.req = req
  60. sc.exec()
  61. return sc
  62. }
  63. func TestGetUserFromLDAPApiEndpoint_UserNotFound(t *testing.T) {
  64. getLDAPConfig = func() (*ldap.Config, error) {
  65. return &ldap.Config{}, nil
  66. }
  67. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  68. return &LDAPMock{}
  69. }
  70. userSearchResult = nil
  71. sc := getUserFromLDAPContext(t, "/api/admin/ldap/user-that-does-not-exist")
  72. require.Equal(t, sc.resp.Code, http.StatusNotFound)
  73. assert.JSONEq(t, "{\"message\":\"No user was found in the LDAP server(s) with that username\"}", sc.resp.Body.String())
  74. }
  75. func TestGetUserFromLDAPApiEndpoint_OrgNotfound(t *testing.T) {
  76. isAdmin := true
  77. userSearchResult = &models.ExternalUserInfo{
  78. Name: "John Doe",
  79. Email: "john.doe@example.com",
  80. Login: "johndoe",
  81. Groups: []string{"cn=admins,ou=groups,dc=grafana,dc=org"},
  82. OrgRoles: map[int64]models.RoleType{1: models.ROLE_ADMIN, 2: models.ROLE_VIEWER},
  83. IsGrafanaAdmin: &isAdmin,
  84. }
  85. userSearchConfig = ldap.ServerConfig{
  86. Attr: ldap.AttributeMap{
  87. Name: "ldap-name",
  88. Surname: "ldap-surname",
  89. Email: "ldap-email",
  90. Username: "ldap-username",
  91. },
  92. Groups: []*ldap.GroupToOrgRole{
  93. {
  94. GroupDN: "cn=admins,ou=groups,dc=grafana,dc=org",
  95. OrgId: 1,
  96. OrgRole: models.ROLE_ADMIN,
  97. },
  98. {
  99. GroupDN: "cn=admins,ou=groups,dc=grafana2,dc=org",
  100. OrgId: 2,
  101. OrgRole: models.ROLE_VIEWER,
  102. },
  103. },
  104. }
  105. mockOrgSearchResult := []*models.OrgDTO{
  106. {Id: 1, Name: "Main Org."},
  107. }
  108. bus.AddHandler("test", func(query *models.SearchOrgsQuery) error {
  109. query.Result = mockOrgSearchResult
  110. return nil
  111. })
  112. getLDAPConfig = func() (*ldap.Config, error) {
  113. return &ldap.Config{}, nil
  114. }
  115. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  116. return &LDAPMock{}
  117. }
  118. sc := getUserFromLDAPContext(t, "/api/admin/ldap/johndoe")
  119. require.Equal(t, sc.resp.Code, http.StatusBadRequest)
  120. expected := `
  121. {
  122. "error": "Unable to find organization with ID '2'",
  123. "message": "An oganization was not found - Please verify your LDAP configuration"
  124. }
  125. `
  126. assert.JSONEq(t, expected, sc.resp.Body.String())
  127. }
  128. func TestGetUserFromLDAPApiEndpoint(t *testing.T) {
  129. isAdmin := true
  130. userSearchResult = &models.ExternalUserInfo{
  131. Name: "John Doe",
  132. Email: "john.doe@example.com",
  133. Login: "johndoe",
  134. Groups: []string{"cn=admins,ou=groups,dc=grafana,dc=org", "another-group-not-matched"},
  135. OrgRoles: map[int64]models.RoleType{1: models.ROLE_ADMIN},
  136. IsGrafanaAdmin: &isAdmin,
  137. }
  138. userSearchConfig = ldap.ServerConfig{
  139. Attr: ldap.AttributeMap{
  140. Name: "ldap-name",
  141. Surname: "ldap-surname",
  142. Email: "ldap-email",
  143. Username: "ldap-username",
  144. },
  145. Groups: []*ldap.GroupToOrgRole{
  146. {
  147. GroupDN: "cn=admins,ou=groups,dc=grafana,dc=org",
  148. OrgId: 1,
  149. OrgRole: models.ROLE_ADMIN,
  150. },
  151. },
  152. }
  153. mockOrgSearchResult := []*models.OrgDTO{
  154. {Id: 1, Name: "Main Org."},
  155. }
  156. bus.AddHandler("test", func(query *models.SearchOrgsQuery) error {
  157. query.Result = mockOrgSearchResult
  158. return nil
  159. })
  160. getLDAPConfig = func() (*ldap.Config, error) {
  161. return &ldap.Config{}, nil
  162. }
  163. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  164. return &LDAPMock{}
  165. }
  166. sc := getUserFromLDAPContext(t, "/api/admin/ldap/johndoe")
  167. assert.Equal(t, sc.resp.Code, http.StatusOK)
  168. expected := `
  169. {
  170. "name": {
  171. "cfgAttrValue": "ldap-name", "ldapValue": "John"
  172. },
  173. "surname": {
  174. "cfgAttrValue": "ldap-surname", "ldapValue": "Doe"
  175. },
  176. "email": {
  177. "cfgAttrValue": "ldap-email", "ldapValue": "john.doe@example.com"
  178. },
  179. "login": {
  180. "cfgAttrValue": "ldap-username", "ldapValue": "johndoe"
  181. },
  182. "isGrafanaAdmin": true,
  183. "isDisabled": false,
  184. "roles": [
  185. { "orgId": 1, "orgRole": "Admin", "orgName": "Main Org.", "groupDN": "cn=admins,ou=groups,dc=grafana,dc=org" },
  186. { "orgId": 0, "orgRole": "", "orgName": "", "groupDN": "another-group-not-matched" }
  187. ],
  188. "teams": null
  189. }
  190. `
  191. assert.JSONEq(t, expected, sc.resp.Body.String())
  192. }
  193. func TestGetUserFromLDAPApiEndpoint_WithTeamHandler(t *testing.T) {
  194. isAdmin := true
  195. userSearchResult = &models.ExternalUserInfo{
  196. Name: "John Doe",
  197. Email: "john.doe@example.com",
  198. Login: "johndoe",
  199. OrgRoles: map[int64]models.RoleType{1: models.ROLE_ADMIN},
  200. IsGrafanaAdmin: &isAdmin,
  201. }
  202. userSearchConfig = ldap.ServerConfig{
  203. Attr: ldap.AttributeMap{
  204. Name: "ldap-name",
  205. Surname: "ldap-surname",
  206. Email: "ldap-email",
  207. Username: "ldap-username",
  208. },
  209. Groups: []*ldap.GroupToOrgRole{
  210. {
  211. GroupDN: "cn=admins,ou=groups,dc=grafana,dc=org",
  212. OrgId: 1,
  213. OrgRole: models.ROLE_ADMIN,
  214. },
  215. },
  216. }
  217. mockOrgSearchResult := []*models.OrgDTO{
  218. {Id: 1, Name: "Main Org."},
  219. }
  220. bus.AddHandler("test", func(query *models.SearchOrgsQuery) error {
  221. query.Result = mockOrgSearchResult
  222. return nil
  223. })
  224. bus.AddHandler("test", func(cmd *models.GetTeamsForLDAPGroupCommand) error {
  225. cmd.Result = []models.TeamOrgGroupDTO{}
  226. return nil
  227. })
  228. getLDAPConfig = func() (*ldap.Config, error) {
  229. return &ldap.Config{}, nil
  230. }
  231. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  232. return &LDAPMock{}
  233. }
  234. sc := getUserFromLDAPContext(t, "/api/admin/ldap/johndoe")
  235. require.Equal(t, sc.resp.Code, http.StatusOK)
  236. expected := `
  237. {
  238. "name": {
  239. "cfgAttrValue": "ldap-name", "ldapValue": "John"
  240. },
  241. "surname": {
  242. "cfgAttrValue": "ldap-surname", "ldapValue": "Doe"
  243. },
  244. "email": {
  245. "cfgAttrValue": "ldap-email", "ldapValue": "john.doe@example.com"
  246. },
  247. "login": {
  248. "cfgAttrValue": "ldap-username", "ldapValue": "johndoe"
  249. },
  250. "isGrafanaAdmin": true,
  251. "isDisabled": false,
  252. "roles": [
  253. { "orgId": 1, "orgRole": "Admin", "orgName": "Main Org.", "groupDN": "cn=admins,ou=groups,dc=grafana,dc=org" }
  254. ],
  255. "teams": []
  256. }
  257. `
  258. assert.JSONEq(t, expected, sc.resp.Body.String())
  259. }
  260. //***
  261. // GetLDAPStatus tests
  262. //***
  263. func getLDAPStatusContext(t *testing.T) *scenarioContext {
  264. t.Helper()
  265. requestURL := "/api/admin/ldap/status"
  266. sc := setupScenarioContext(requestURL)
  267. ldap := setting.LDAPEnabled
  268. setting.LDAPEnabled = true
  269. defer func() { setting.LDAPEnabled = ldap }()
  270. hs := &HTTPServer{Cfg: setting.NewCfg()}
  271. sc.defaultHandler = Wrap(func(c *models.ReqContext) Response {
  272. sc.context = c
  273. return hs.GetLDAPStatus(c)
  274. })
  275. sc.m.Get("/api/admin/ldap/status", sc.defaultHandler)
  276. sc.resp = httptest.NewRecorder()
  277. req, _ := http.NewRequest(http.MethodGet, requestURL, nil)
  278. sc.req = req
  279. sc.exec()
  280. return sc
  281. }
  282. func TestGetLDAPStatusApiEndpoint(t *testing.T) {
  283. pingResult = []*multildap.ServerStatus{
  284. {Host: "10.0.0.3", Port: 361, Available: true, Error: nil},
  285. {Host: "10.0.0.3", Port: 362, Available: true, Error: nil},
  286. {Host: "10.0.0.5", Port: 361, Available: false, Error: errors.New("something is awfully wrong")},
  287. }
  288. getLDAPConfig = func() (*ldap.Config, error) {
  289. return &ldap.Config{}, nil
  290. }
  291. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  292. return &LDAPMock{}
  293. }
  294. sc := getLDAPStatusContext(t)
  295. require.Equal(t, http.StatusOK, sc.resp.Code)
  296. expected := `
  297. [
  298. { "host": "10.0.0.3", "port": 361, "available": true, "error": "" },
  299. { "host": "10.0.0.3", "port": 362, "available": true, "error": "" },
  300. { "host": "10.0.0.5", "port": 361, "available": false, "error": "something is awfully wrong" }
  301. ]
  302. `
  303. assert.JSONEq(t, expected, sc.resp.Body.String())
  304. }
  305. //***
  306. // PostSyncUserWithLDAP tests
  307. //***
  308. func postSyncUserWithLDAPContext(t *testing.T, requestURL string) *scenarioContext {
  309. t.Helper()
  310. sc := setupScenarioContext(requestURL)
  311. ldap := setting.LDAPEnabled
  312. setting.LDAPEnabled = true
  313. defer func() { setting.LDAPEnabled = ldap }()
  314. hs := &HTTPServer{Cfg: setting.NewCfg()}
  315. sc.defaultHandler = Wrap(func(c *models.ReqContext) Response {
  316. sc.context = c
  317. return hs.PostSyncUserWithLDAP(c)
  318. })
  319. sc.m.Post("/api/admin/ldap/sync/:id", sc.defaultHandler)
  320. sc.resp = httptest.NewRecorder()
  321. req, _ := http.NewRequest(http.MethodPost, requestURL, nil)
  322. sc.req = req
  323. sc.exec()
  324. return sc
  325. }
  326. func TestPostSyncUserWithLDAPAPIEndpoint_Success(t *testing.T) {
  327. getLDAPConfig = func() (*ldap.Config, error) {
  328. return &ldap.Config{}, nil
  329. }
  330. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  331. return &LDAPMock{}
  332. }
  333. userSearchResult = &models.ExternalUserInfo{
  334. Login: "ldap-daniel",
  335. }
  336. bus.AddHandler("test", func(cmd *models.UpsertUserCommand) error {
  337. require.Equal(t, "ldap-daniel", cmd.ExternalUser.Login)
  338. return nil
  339. })
  340. bus.AddHandler("test", func(q *models.GetUserByIdQuery) error {
  341. require.Equal(t, q.Id, int64(34))
  342. q.Result = &models.User{Login: "ldap-daniel", Id: 34}
  343. return nil
  344. })
  345. bus.AddHandler("test", func(q *models.GetAuthInfoQuery) error {
  346. require.Equal(t, q.UserId, int64(34))
  347. require.Equal(t, q.AuthModule, models.AuthModuleLDAP)
  348. return nil
  349. })
  350. sc := postSyncUserWithLDAPContext(t, "/api/admin/ldap/sync/34")
  351. assert.Equal(t, http.StatusOK, sc.resp.Code)
  352. expected := `
  353. {
  354. "message": "User synced successfully"
  355. }
  356. `
  357. assert.JSONEq(t, expected, sc.resp.Body.String())
  358. }
  359. func TestPostSyncUserWithLDAPAPIEndpoint_WhenUserNotFound(t *testing.T) {
  360. getLDAPConfig = func() (*ldap.Config, error) {
  361. return &ldap.Config{}, nil
  362. }
  363. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  364. return &LDAPMock{}
  365. }
  366. bus.AddHandler("test", func(q *models.GetUserByIdQuery) error {
  367. require.Equal(t, q.Id, int64(34))
  368. return models.ErrUserNotFound
  369. })
  370. sc := postSyncUserWithLDAPContext(t, "/api/admin/ldap/sync/34")
  371. assert.Equal(t, http.StatusNotFound, sc.resp.Code)
  372. expected := `
  373. {
  374. "message": "User not found"
  375. }
  376. `
  377. assert.JSONEq(t, expected, sc.resp.Body.String())
  378. }
  379. func TestPostSyncUserWithLDAPAPIEndpoint_WhenGrafanaAdmin(t *testing.T) {
  380. getLDAPConfig = func() (*ldap.Config, error) {
  381. return &ldap.Config{}, nil
  382. }
  383. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  384. return &LDAPMock{}
  385. }
  386. userSearchError = ldap.ErrCouldNotFindUser
  387. admin := setting.AdminUser
  388. setting.AdminUser = "ldap-daniel"
  389. defer func() { setting.AdminUser = admin }()
  390. bus.AddHandler("test", func(q *models.GetUserByIdQuery) error {
  391. require.Equal(t, q.Id, int64(34))
  392. q.Result = &models.User{Login: "ldap-daniel", Id: 34}
  393. return nil
  394. })
  395. bus.AddHandler("test", func(q *models.GetAuthInfoQuery) error {
  396. require.Equal(t, q.UserId, int64(34))
  397. require.Equal(t, q.AuthModule, models.AuthModuleLDAP)
  398. return nil
  399. })
  400. sc := postSyncUserWithLDAPContext(t, "/api/admin/ldap/sync/34")
  401. assert.Equal(t, http.StatusBadRequest, sc.resp.Code)
  402. expected := `
  403. {
  404. "error": "Can't find user in LDAP",
  405. "message": "Refusing to sync grafana super admin \"ldap-daniel\" - it would be disabled"
  406. }
  407. `
  408. assert.JSONEq(t, expected, sc.resp.Body.String())
  409. }
  410. func TestPostSyncUserWithLDAPAPIEndpoint_WhenUserNotInLDAP(t *testing.T) {
  411. getLDAPConfig = func() (*ldap.Config, error) {
  412. return &ldap.Config{}, nil
  413. }
  414. tokenService = &TokenServiceMock{}
  415. newLDAP = func(_ []*ldap.ServerConfig) multildap.IMultiLDAP {
  416. return &LDAPMock{}
  417. }
  418. userSearchResult = nil
  419. bus.AddHandler("test", func(cmd *models.UpsertUserCommand) error {
  420. require.Equal(t, "ldap-daniel", cmd.ExternalUser.Login)
  421. return nil
  422. })
  423. bus.AddHandler("test", func(q *models.GetUserByIdQuery) error {
  424. require.Equal(t, q.Id, int64(34))
  425. q.Result = &models.User{Login: "ldap-daniel", Id: 34}
  426. return nil
  427. })
  428. bus.AddHandler("test", func(q *models.GetExternalUserInfoByLoginQuery) error {
  429. assert.Equal(t, "ldap-daniel", q.LoginOrEmail)
  430. q.Result = &models.ExternalUserInfo{IsDisabled: true, UserId: 34}
  431. return nil
  432. })
  433. bus.AddHandler("test", func(cmd *models.DisableUserCommand) error {
  434. assert.Equal(t, 34, cmd.UserId)
  435. return nil
  436. })
  437. sc := postSyncUserWithLDAPContext(t, "/api/admin/ldap/sync/34")
  438. assert.Equal(t, http.StatusOK, sc.resp.Code)
  439. expected := `
  440. {
  441. "message": "User disabled without any updates in the information"
  442. }
  443. `
  444. assert.JSONEq(t, expected, sc.resp.Body.String())
  445. }