| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241 |
- package api
- import (
- "testing"
- "github.com/grafana/grafana/pkg/api/dtos"
- "github.com/grafana/grafana/pkg/bus"
- m "github.com/grafana/grafana/pkg/models"
- "github.com/grafana/grafana/pkg/services/annotations"
- . "github.com/smartystreets/goconvey/convey"
- )
- func TestAnnotationsApiEndpoint(t *testing.T) {
- Convey("Given an annotation without a dashboard id", t, func() {
- cmd := dtos.PostAnnotationsCmd{
- Time: 1000,
- Text: "annotation text",
- Tags: []string{"tag1", "tag2"},
- IsRegion: false,
- }
- updateCmd := dtos.UpdateAnnotationsCmd{
- Time: 1000,
- Text: "annotation text",
- Tags: []string{"tag1", "tag2"},
- IsRegion: false,
- }
- Convey("When user is an Org Viewer", func() {
- role := m.ROLE_VIEWER
- Convey("Should not be allowed to save an annotation", func() {
- postAnnotationScenario("When calling POST on", "/api/annotations", "/api/annotations", role, cmd, func(sc *scenarioContext) {
- sc.fakeReqWithParams("POST", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 403)
- })
- putAnnotationScenario("When calling PUT on", "/api/annotations/1", "/api/annotations/:annotationId", role, updateCmd, func(sc *scenarioContext) {
- sc.fakeReqWithParams("PUT", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 403)
- })
- loggedInUserScenarioWithRole("When calling DELETE on", "DELETE", "/api/annotations/1", "/api/annotations/:annotationId", role, func(sc *scenarioContext) {
- sc.handlerFunc = DeleteAnnotationById
- sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 403)
- })
- loggedInUserScenarioWithRole("When calling DELETE on", "DELETE", "/api/annotations/region/1", "/api/annotations/region/:regionId", role, func(sc *scenarioContext) {
- sc.handlerFunc = DeleteAnnotationRegion
- sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 403)
- })
- })
- })
- Convey("When user is an Org Editor", func() {
- role := m.ROLE_EDITOR
- Convey("Should be able to save an annotation", func() {
- postAnnotationScenario("When calling POST on", "/api/annotations", "/api/annotations", role, cmd, func(sc *scenarioContext) {
- sc.fakeReqWithParams("POST", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 200)
- })
- putAnnotationScenario("When calling PUT on", "/api/annotations/1", "/api/annotations/:annotationId", role, updateCmd, func(sc *scenarioContext) {
- sc.fakeReqWithParams("PUT", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 200)
- })
- loggedInUserScenarioWithRole("When calling DELETE on", "DELETE", "/api/annotations/1", "/api/annotations/:annotationId", role, func(sc *scenarioContext) {
- sc.handlerFunc = DeleteAnnotationById
- sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 200)
- })
- loggedInUserScenarioWithRole("When calling DELETE on", "DELETE", "/api/annotations/region/1", "/api/annotations/region/:regionId", role, func(sc *scenarioContext) {
- sc.handlerFunc = DeleteAnnotationRegion
- sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 200)
- })
- })
- })
- })
- Convey("Given an annotation with a dashboard id and the dashboard does not have an acl", t, func() {
- cmd := dtos.PostAnnotationsCmd{
- Time: 1000,
- Text: "annotation text",
- Tags: []string{"tag1", "tag2"},
- IsRegion: false,
- DashboardId: 1,
- PanelId: 1,
- }
- updateCmd := dtos.UpdateAnnotationsCmd{
- Time: 1000,
- Text: "annotation text",
- Tags: []string{"tag1", "tag2"},
- IsRegion: false,
- Id: 1,
- }
- viewerRole := m.ROLE_VIEWER
- editorRole := m.ROLE_EDITOR
- aclMockResp := []*m.DashboardAclInfoDTO{
- {Role: &viewerRole, Permission: m.PERMISSION_VIEW},
- {Role: &editorRole, Permission: m.PERMISSION_EDIT},
- }
- bus.AddHandler("test", func(query *m.GetDashboardAclInfoListQuery) error {
- query.Result = aclMockResp
- return nil
- })
- bus.AddHandler("test", func(query *m.GetTeamsByUserQuery) error {
- query.Result = []*m.Team{}
- return nil
- })
- Convey("When user is an Org Viewer", func() {
- role := m.ROLE_VIEWER
- Convey("Should not be allowed to save an annotation", func() {
- postAnnotationScenario("When calling POST on", "/api/annotations", "/api/annotations", role, cmd, func(sc *scenarioContext) {
- sc.fakeReqWithParams("POST", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 403)
- })
- putAnnotationScenario("When calling PUT on", "/api/annotations/1", "/api/annotations/:annotationId", role, updateCmd, func(sc *scenarioContext) {
- sc.fakeReqWithParams("PUT", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 403)
- })
- loggedInUserScenarioWithRole("When calling DELETE on", "DELETE", "/api/annotations/1", "/api/annotations/:annotationId", role, func(sc *scenarioContext) {
- sc.handlerFunc = DeleteAnnotationById
- sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 403)
- })
- loggedInUserScenarioWithRole("When calling DELETE on", "DELETE", "/api/annotations/region/1", "/api/annotations/region/:regionId", role, func(sc *scenarioContext) {
- sc.handlerFunc = DeleteAnnotationRegion
- sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 403)
- })
- })
- })
- Convey("When user is an Org Editor", func() {
- role := m.ROLE_EDITOR
- Convey("Should be able to save an annotation", func() {
- postAnnotationScenario("When calling POST on", "/api/annotations", "/api/annotations", role, cmd, func(sc *scenarioContext) {
- sc.fakeReqWithParams("POST", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 200)
- })
- putAnnotationScenario("When calling PUT on", "/api/annotations/1", "/api/annotations/:annotationId", role, updateCmd, func(sc *scenarioContext) {
- sc.fakeReqWithParams("PUT", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 200)
- })
- loggedInUserScenarioWithRole("When calling DELETE on", "DELETE", "/api/annotations/1", "/api/annotations/:annotationId", role, func(sc *scenarioContext) {
- sc.handlerFunc = DeleteAnnotationById
- sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 200)
- })
- loggedInUserScenarioWithRole("When calling DELETE on", "DELETE", "/api/annotations/region/1", "/api/annotations/region/:regionId", role, func(sc *scenarioContext) {
- sc.handlerFunc = DeleteAnnotationRegion
- sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
- So(sc.resp.Code, ShouldEqual, 200)
- })
- })
- })
- })
- }
- type fakeAnnotationsRepo struct {
- }
- func (repo *fakeAnnotationsRepo) Delete(params *annotations.DeleteParams) error {
- return nil
- }
- func (repo *fakeAnnotationsRepo) Save(item *annotations.Item) error {
- item.Id = 1
- return nil
- }
- func (repo *fakeAnnotationsRepo) Update(item *annotations.Item) error {
- return nil
- }
- func (repo *fakeAnnotationsRepo) Find(query *annotations.ItemQuery) ([]*annotations.ItemDTO, error) {
- annotations := []*annotations.ItemDTO{{Id: 1}}
- return annotations, nil
- }
- var fakeAnnoRepo *fakeAnnotationsRepo
- func postAnnotationScenario(desc string, url string, routePattern string, role m.RoleType, cmd dtos.PostAnnotationsCmd, fn scenarioFunc) {
- Convey(desc+" "+url, func() {
- defer bus.ClearBusHandlers()
- sc := setupScenarioContext(url)
- sc.defaultHandler = wrap(func(c *m.ReqContext) Response {
- sc.context = c
- sc.context.UserId = TestUserID
- sc.context.OrgId = TestOrgID
- sc.context.OrgRole = role
- return PostAnnotation(c, cmd)
- })
- fakeAnnoRepo = &fakeAnnotationsRepo{}
- annotations.SetRepository(fakeAnnoRepo)
- sc.m.Post(routePattern, sc.defaultHandler)
- fn(sc)
- })
- }
- func putAnnotationScenario(desc string, url string, routePattern string, role m.RoleType, cmd dtos.UpdateAnnotationsCmd, fn scenarioFunc) {
- Convey(desc+" "+url, func() {
- defer bus.ClearBusHandlers()
- sc := setupScenarioContext(url)
- sc.defaultHandler = wrap(func(c *m.ReqContext) Response {
- sc.context = c
- sc.context.UserId = TestUserID
- sc.context.OrgId = TestOrgID
- sc.context.OrgRole = role
- return UpdateAnnotation(c, cmd)
- })
- fakeAnnoRepo = &fakeAnnotationsRepo{}
- annotations.SetRepository(fakeAnnoRepo)
- sc.m.Put(routePattern, sc.defaultHandler)
- fn(sc)
- })
- }
|