team_test.go 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277
  1. package sqlstore
  2. import (
  3. "context"
  4. "fmt"
  5. "testing"
  6. . "github.com/smartystreets/goconvey/convey"
  7. "github.com/grafana/grafana/pkg/models"
  8. )
  9. func TestTeamCommandsAndQueries(t *testing.T) {
  10. Convey("Testing Team commands & queries", t, func() {
  11. InitTestDB(t)
  12. Convey("Given saved users and two teams", func() {
  13. var userIds []int64
  14. for i := 0; i < 5; i++ {
  15. userCmd := &models.CreateUserCommand{
  16. Email: fmt.Sprint("user", i, "@test.com"),
  17. Name: fmt.Sprint("user", i),
  18. Login: fmt.Sprint("loginuser", i),
  19. }
  20. err := CreateUser(context.Background(), userCmd)
  21. So(err, ShouldBeNil)
  22. userIds = append(userIds, userCmd.Result.Id)
  23. }
  24. var testOrgId int64 = 1
  25. group1 := models.CreateTeamCommand{OrgId: testOrgId, Name: "group1 name", Email: "test1@test.com"}
  26. group2 := models.CreateTeamCommand{OrgId: testOrgId, Name: "group2 name", Email: "test2@test.com"}
  27. err := CreateTeam(&group1)
  28. So(err, ShouldBeNil)
  29. err = CreateTeam(&group2)
  30. So(err, ShouldBeNil)
  31. Convey("Should be able to create teams and add users", func() {
  32. query := &models.SearchTeamsQuery{OrgId: testOrgId, Name: "group1 name", Page: 1, Limit: 10}
  33. err = SearchTeams(query)
  34. So(err, ShouldBeNil)
  35. So(query.Page, ShouldEqual, 1)
  36. team1 := query.Result.Teams[0]
  37. So(team1.Name, ShouldEqual, "group1 name")
  38. So(team1.Email, ShouldEqual, "test1@test.com")
  39. So(team1.OrgId, ShouldEqual, testOrgId)
  40. err = AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team1.Id, UserId: userIds[0]})
  41. So(err, ShouldBeNil)
  42. err = AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team1.Id, UserId: userIds[1], External: true})
  43. So(err, ShouldBeNil)
  44. q1 := &models.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team1.Id}
  45. err = GetTeamMembers(q1)
  46. So(err, ShouldBeNil)
  47. So(q1.Result, ShouldHaveLength, 2)
  48. So(q1.Result[0].TeamId, ShouldEqual, team1.Id)
  49. So(q1.Result[0].Login, ShouldEqual, "loginuser0")
  50. So(q1.Result[0].OrgId, ShouldEqual, testOrgId)
  51. So(q1.Result[1].TeamId, ShouldEqual, team1.Id)
  52. So(q1.Result[1].Login, ShouldEqual, "loginuser1")
  53. So(q1.Result[1].OrgId, ShouldEqual, testOrgId)
  54. So(q1.Result[1].External, ShouldEqual, true)
  55. q2 := &models.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team1.Id, External: true}
  56. err = GetTeamMembers(q2)
  57. So(err, ShouldBeNil)
  58. So(q2.Result, ShouldHaveLength, 1)
  59. So(q2.Result[0].TeamId, ShouldEqual, team1.Id)
  60. So(q2.Result[0].Login, ShouldEqual, "loginuser1")
  61. So(q2.Result[0].OrgId, ShouldEqual, testOrgId)
  62. So(q2.Result[0].External, ShouldEqual, true)
  63. })
  64. Convey("Should return latest auth module for users when getting team members", func() {
  65. userId := userIds[1]
  66. err := SetAuthInfo(&models.SetAuthInfoCommand{UserId: userId, AuthModule: "oauth_github", AuthId: "1234567"})
  67. So(err, ShouldBeNil)
  68. teamQuery := &models.SearchTeamsQuery{OrgId: testOrgId, Name: "group1 name", Page: 1, Limit: 10}
  69. err = SearchTeams(teamQuery)
  70. So(err, ShouldBeNil)
  71. So(teamQuery.Page, ShouldEqual, 1)
  72. team1 := teamQuery.Result.Teams[0]
  73. err = AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team1.Id, UserId: userId, External: true})
  74. So(err, ShouldBeNil)
  75. memberQuery := &models.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team1.Id, External: true}
  76. err = GetTeamMembers(memberQuery)
  77. So(err, ShouldBeNil)
  78. So(memberQuery.Result, ShouldHaveLength, 1)
  79. So(memberQuery.Result[0].TeamId, ShouldEqual, team1.Id)
  80. So(memberQuery.Result[0].Login, ShouldEqual, "loginuser1")
  81. So(memberQuery.Result[0].OrgId, ShouldEqual, testOrgId)
  82. So(memberQuery.Result[0].External, ShouldEqual, true)
  83. So(memberQuery.Result[0].AuthModule, ShouldEqual, "oauth_github")
  84. })
  85. Convey("Should be able to update users in a team", func() {
  86. userId := userIds[0]
  87. team := group1.Result
  88. addMemberCmd := models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team.Id, UserId: userId}
  89. err = AddTeamMember(&addMemberCmd)
  90. So(err, ShouldBeNil)
  91. qBeforeUpdate := &models.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team.Id}
  92. err = GetTeamMembers(qBeforeUpdate)
  93. So(err, ShouldBeNil)
  94. So(qBeforeUpdate.Result[0].Permission, ShouldEqual, 0)
  95. err = UpdateTeamMember(&models.UpdateTeamMemberCommand{
  96. UserId: userId,
  97. OrgId: testOrgId,
  98. TeamId: team.Id,
  99. Permission: models.PERMISSION_ADMIN,
  100. })
  101. So(err, ShouldBeNil)
  102. qAfterUpdate := &models.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team.Id}
  103. err = GetTeamMembers(qAfterUpdate)
  104. So(err, ShouldBeNil)
  105. So(qAfterUpdate.Result[0].Permission, ShouldEqual, models.PERMISSION_ADMIN)
  106. })
  107. Convey("Should default to member permission level when updating a user with invalid permission level", func() {
  108. userID := userIds[0]
  109. team := group1.Result
  110. addMemberCmd := models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: team.Id, UserId: userID}
  111. err = AddTeamMember(&addMemberCmd)
  112. So(err, ShouldBeNil)
  113. qBeforeUpdate := &models.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team.Id}
  114. err = GetTeamMembers(qBeforeUpdate)
  115. So(err, ShouldBeNil)
  116. So(qBeforeUpdate.Result[0].Permission, ShouldEqual, 0)
  117. invalidPermissionLevel := models.PERMISSION_EDIT
  118. err = UpdateTeamMember(&models.UpdateTeamMemberCommand{
  119. UserId: userID,
  120. OrgId: testOrgId,
  121. TeamId: team.Id,
  122. Permission: invalidPermissionLevel,
  123. })
  124. So(err, ShouldBeNil)
  125. qAfterUpdate := &models.GetTeamMembersQuery{OrgId: testOrgId, TeamId: team.Id}
  126. err = GetTeamMembers(qAfterUpdate)
  127. So(err, ShouldBeNil)
  128. So(qAfterUpdate.Result[0].Permission, ShouldEqual, 0)
  129. })
  130. Convey("Shouldn't be able to update a user not in the team.", func() {
  131. err = UpdateTeamMember(&models.UpdateTeamMemberCommand{
  132. UserId: 1,
  133. OrgId: testOrgId,
  134. TeamId: group1.Result.Id,
  135. Permission: models.PERMISSION_ADMIN,
  136. })
  137. So(err, ShouldEqual, models.ErrTeamMemberNotFound)
  138. })
  139. Convey("Should be able to search for teams", func() {
  140. query := &models.SearchTeamsQuery{OrgId: testOrgId, Query: "group", Page: 1}
  141. err = SearchTeams(query)
  142. So(err, ShouldBeNil)
  143. So(len(query.Result.Teams), ShouldEqual, 2)
  144. So(query.Result.TotalCount, ShouldEqual, 2)
  145. query2 := &models.SearchTeamsQuery{OrgId: testOrgId, Query: ""}
  146. err = SearchTeams(query2)
  147. So(err, ShouldBeNil)
  148. So(len(query2.Result.Teams), ShouldEqual, 2)
  149. })
  150. Convey("Should be able to return all teams a user is member of", func() {
  151. groupId := group2.Result.Id
  152. err := AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: groupId, UserId: userIds[0]})
  153. So(err, ShouldBeNil)
  154. query := &models.GetTeamsByUserQuery{OrgId: testOrgId, UserId: userIds[0]}
  155. err = GetTeamsByUser(query)
  156. So(err, ShouldBeNil)
  157. So(len(query.Result), ShouldEqual, 1)
  158. So(query.Result[0].Name, ShouldEqual, "group2 name")
  159. So(query.Result[0].Email, ShouldEqual, "test2@test.com")
  160. })
  161. Convey("Should be able to remove users from a group", func() {
  162. err = AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0]})
  163. So(err, ShouldBeNil)
  164. err = RemoveTeamMember(&models.RemoveTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0]})
  165. So(err, ShouldBeNil)
  166. q2 := &models.GetTeamMembersQuery{OrgId: testOrgId, TeamId: group1.Result.Id}
  167. err = GetTeamMembers(q2)
  168. So(err, ShouldBeNil)
  169. So(len(q2.Result), ShouldEqual, 0)
  170. })
  171. Convey("When ProtectLastAdmin is set to true", func() {
  172. err = AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], Permission: models.PERMISSION_ADMIN})
  173. So(err, ShouldBeNil)
  174. Convey("A user should not be able to remove the last admin", func() {
  175. err = RemoveTeamMember(&models.RemoveTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], ProtectLastAdmin: true})
  176. So(err, ShouldEqual, models.ErrLastTeamAdmin)
  177. })
  178. Convey("A user should be able to remove an admin if there are other admins", func() {
  179. AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[1], Permission: models.PERMISSION_ADMIN})
  180. err = RemoveTeamMember(&models.RemoveTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], ProtectLastAdmin: true})
  181. So(err, ShouldEqual, nil)
  182. })
  183. Convey("A user should not be able to remove the admin permission for the last admin", func() {
  184. err = UpdateTeamMember(&models.UpdateTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], Permission: 0, ProtectLastAdmin: true})
  185. So(err, ShouldEqual, models.ErrLastTeamAdmin)
  186. })
  187. Convey("A user should be able to remove the admin permission if there are other admins", func() {
  188. AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[1], Permission: models.PERMISSION_ADMIN})
  189. err = UpdateTeamMember(&models.UpdateTeamMemberCommand{OrgId: testOrgId, TeamId: group1.Result.Id, UserId: userIds[0], Permission: 0, ProtectLastAdmin: true})
  190. So(err, ShouldEqual, nil)
  191. })
  192. })
  193. Convey("Should be able to remove a group with users and permissions", func() {
  194. groupId := group2.Result.Id
  195. err := AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: groupId, UserId: userIds[1]})
  196. So(err, ShouldBeNil)
  197. err = AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: groupId, UserId: userIds[2]})
  198. So(err, ShouldBeNil)
  199. err = testHelperUpdateDashboardAcl(1, models.DashboardAcl{DashboardId: 1, OrgId: testOrgId, Permission: models.PERMISSION_EDIT, TeamId: groupId})
  200. So(err, ShouldBeNil)
  201. err = DeleteTeam(&models.DeleteTeamCommand{OrgId: testOrgId, Id: groupId})
  202. So(err, ShouldBeNil)
  203. query := &models.GetTeamByIdQuery{OrgId: testOrgId, Id: groupId}
  204. err = GetTeamById(query)
  205. So(err, ShouldEqual, models.ErrTeamNotFound)
  206. permQuery := &models.GetDashboardAclInfoListQuery{DashboardId: 1, OrgId: testOrgId}
  207. err = GetDashboardAclInfoList(permQuery)
  208. So(err, ShouldBeNil)
  209. So(len(permQuery.Result), ShouldEqual, 0)
  210. })
  211. Convey("Should be able to return if user is admin of teams or not", func() {
  212. groupId := group2.Result.Id
  213. err := AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: groupId, UserId: userIds[0]})
  214. So(err, ShouldBeNil)
  215. err = AddTeamMember(&models.AddTeamMemberCommand{OrgId: testOrgId, TeamId: groupId, UserId: userIds[1], Permission: models.PERMISSION_ADMIN})
  216. So(err, ShouldBeNil)
  217. query := &models.IsAdminOfTeamsQuery{SignedInUser: &models.SignedInUser{OrgId: testOrgId, UserId: userIds[0]}}
  218. err = IsAdminOfTeams(query)
  219. So(err, ShouldBeNil)
  220. So(query.Result, ShouldBeFalse)
  221. query = &models.IsAdminOfTeamsQuery{SignedInUser: &models.SignedInUser{OrgId: testOrgId, UserId: userIds[1]}}
  222. err = IsAdminOfTeams(query)
  223. So(err, ShouldBeNil)
  224. So(query.Result, ShouldBeTrue)
  225. })
  226. })
  227. })
  228. }