auth_token_test.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481
  1. package authtoken
  2. import (
  3. "encoding/json"
  4. "testing"
  5. "time"
  6. "github.com/grafana/grafana/pkg/components/simplejson"
  7. "github.com/grafana/grafana/pkg/setting"
  8. "github.com/grafana/grafana/pkg/log"
  9. "github.com/grafana/grafana/pkg/services/auth"
  10. "github.com/grafana/grafana/pkg/services/sqlstore"
  11. . "github.com/smartystreets/goconvey/convey"
  12. )
  13. func TestUserAuthToken(t *testing.T) {
  14. Convey("Test user auth token", t, func() {
  15. ctx := createTestContext(t)
  16. userAuthTokenService := ctx.tokenService
  17. userID := int64(10)
  18. t := time.Date(2018, 12, 13, 13, 45, 0, 0, time.UTC)
  19. getTime = func() time.Time {
  20. return t
  21. }
  22. Convey("When creating token", func() {
  23. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  24. So(err, ShouldBeNil)
  25. So(userToken, ShouldNotBeNil)
  26. So(userToken.AuthTokenSeen, ShouldBeFalse)
  27. Convey("When lookup unhashed token should return user auth token", func() {
  28. userToken, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  29. So(err, ShouldBeNil)
  30. So(userToken, ShouldNotBeNil)
  31. So(userToken.UserId, ShouldEqual, userID)
  32. So(userToken.AuthTokenSeen, ShouldBeTrue)
  33. storedAuthToken, err := ctx.getAuthTokenByID(userToken.Id)
  34. So(err, ShouldBeNil)
  35. So(storedAuthToken, ShouldNotBeNil)
  36. So(storedAuthToken.AuthTokenSeen, ShouldBeTrue)
  37. })
  38. Convey("When lookup hashed token should return user auth token not found error", func() {
  39. userToken, err := userAuthTokenService.LookupToken(userToken.AuthToken)
  40. So(err, ShouldEqual, ErrAuthTokenNotFound)
  41. So(userToken, ShouldBeNil)
  42. })
  43. Convey("revoking existing token should delete token", func() {
  44. err = userAuthTokenService.RevokeToken(userToken)
  45. So(err, ShouldBeNil)
  46. model, err := ctx.getAuthTokenByID(userToken.Id)
  47. So(err, ShouldBeNil)
  48. So(model, ShouldBeNil)
  49. })
  50. Convey("revoking nil token should return error", func() {
  51. err = userAuthTokenService.RevokeToken(nil)
  52. So(err, ShouldEqual, ErrAuthTokenNotFound)
  53. })
  54. Convey("revoking non-existing token should return error", func() {
  55. userToken.Id = 1000
  56. err = userAuthTokenService.RevokeToken(userToken)
  57. So(err, ShouldEqual, ErrAuthTokenNotFound)
  58. })
  59. })
  60. Convey("expires correctly", func() {
  61. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  62. So(err, ShouldBeNil)
  63. userToken, err = userAuthTokenService.LookupToken(userToken.UnhashedToken)
  64. So(err, ShouldBeNil)
  65. getTime = func() time.Time {
  66. return t.Add(time.Hour)
  67. }
  68. rotated, err := userAuthTokenService.TryRotateToken(userToken, "192.168.10.11:1234", "some user agent")
  69. So(err, ShouldBeNil)
  70. So(rotated, ShouldBeTrue)
  71. userToken, err = userAuthTokenService.LookupToken(userToken.UnhashedToken)
  72. So(err, ShouldBeNil)
  73. stillGood, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  74. So(err, ShouldBeNil)
  75. So(stillGood, ShouldNotBeNil)
  76. model, err := ctx.getAuthTokenByID(userToken.Id)
  77. So(err, ShouldBeNil)
  78. Convey("when rotated_at is 6:59:59 ago should find token", func() {
  79. getTime = func() time.Time {
  80. return time.Unix(model.RotatedAt, 0).Add(24 * 7 * time.Hour).Add(-time.Second)
  81. }
  82. stillGood, err = userAuthTokenService.LookupToken(stillGood.UnhashedToken)
  83. So(err, ShouldBeNil)
  84. So(stillGood, ShouldNotBeNil)
  85. })
  86. Convey("when rotated_at is 7:00:00 ago should not find token", func() {
  87. getTime = func() time.Time {
  88. return time.Unix(model.RotatedAt, 0).Add(24 * 7 * time.Hour)
  89. }
  90. notGood, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  91. So(err, ShouldEqual, ErrAuthTokenNotFound)
  92. So(notGood, ShouldBeNil)
  93. })
  94. Convey("when rotated_at is 5 days ago and created_at is 29 days and 23:59:59 ago should not find token", func() {
  95. updated, err := ctx.updateRotatedAt(model.Id, time.Unix(model.CreatedAt, 0).Add(24*25*time.Hour).Unix())
  96. So(err, ShouldBeNil)
  97. So(updated, ShouldBeTrue)
  98. getTime = func() time.Time {
  99. return time.Unix(model.CreatedAt, 0).Add(24 * 30 * time.Hour).Add(-time.Second)
  100. }
  101. stillGood, err = userAuthTokenService.LookupToken(stillGood.UnhashedToken)
  102. So(err, ShouldBeNil)
  103. So(stillGood, ShouldNotBeNil)
  104. })
  105. Convey("when rotated_at is 5 days ago and created_at is 30 days ago should not find token", func() {
  106. updated, err := ctx.updateRotatedAt(model.Id, time.Unix(model.CreatedAt, 0).Add(24*25*time.Hour).Unix())
  107. So(err, ShouldBeNil)
  108. So(updated, ShouldBeTrue)
  109. getTime = func() time.Time {
  110. return time.Unix(model.CreatedAt, 0).Add(24 * 30 * time.Hour)
  111. }
  112. notGood, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  113. So(err, ShouldEqual, ErrAuthTokenNotFound)
  114. So(notGood, ShouldBeNil)
  115. })
  116. })
  117. Convey("can properly rotate tokens", func() {
  118. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  119. So(err, ShouldBeNil)
  120. prevToken := userToken.AuthToken
  121. unhashedPrev := userToken.UnhashedToken
  122. rotated, err := userAuthTokenService.TryRotateToken(userToken, "192.168.10.12:1234", "a new user agent")
  123. So(err, ShouldBeNil)
  124. So(rotated, ShouldBeFalse)
  125. updated, err := ctx.markAuthTokenAsSeen(userToken.Id)
  126. So(err, ShouldBeNil)
  127. So(updated, ShouldBeTrue)
  128. model, err := ctx.getAuthTokenByID(userToken.Id)
  129. So(err, ShouldBeNil)
  130. var tok auth.UserToken
  131. model.toUserToken(&tok)
  132. getTime = func() time.Time {
  133. return t.Add(time.Hour)
  134. }
  135. rotated, err = userAuthTokenService.TryRotateToken(&tok, "192.168.10.12:1234", "a new user agent")
  136. So(err, ShouldBeNil)
  137. So(rotated, ShouldBeTrue)
  138. unhashedToken := tok.UnhashedToken
  139. model, err = ctx.getAuthTokenByID(tok.Id)
  140. So(err, ShouldBeNil)
  141. model.UnhashedToken = unhashedToken
  142. So(model.RotatedAt, ShouldEqual, getTime().Unix())
  143. So(model.ClientIp, ShouldEqual, "192.168.10.12")
  144. So(model.UserAgent, ShouldEqual, "a new user agent")
  145. So(model.AuthTokenSeen, ShouldBeFalse)
  146. So(model.SeenAt, ShouldEqual, 0)
  147. So(model.PrevAuthToken, ShouldEqual, prevToken)
  148. // ability to auth using an old token
  149. lookedUpUserToken, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  150. So(err, ShouldBeNil)
  151. So(lookedUpUserToken, ShouldNotBeNil)
  152. So(lookedUpUserToken.AuthTokenSeen, ShouldBeTrue)
  153. So(lookedUpUserToken.SeenAt, ShouldEqual, getTime().Unix())
  154. lookedUpUserToken, err = userAuthTokenService.LookupToken(unhashedPrev)
  155. So(err, ShouldBeNil)
  156. So(lookedUpUserToken, ShouldNotBeNil)
  157. So(lookedUpUserToken.Id, ShouldEqual, model.Id)
  158. So(lookedUpUserToken.AuthTokenSeen, ShouldBeTrue)
  159. getTime = func() time.Time {
  160. return t.Add(time.Hour + (2 * time.Minute))
  161. }
  162. lookedUpUserToken, err = userAuthTokenService.LookupToken(unhashedPrev)
  163. So(err, ShouldBeNil)
  164. So(lookedUpUserToken, ShouldNotBeNil)
  165. So(lookedUpUserToken.AuthTokenSeen, ShouldBeTrue)
  166. lookedUpModel, err := ctx.getAuthTokenByID(lookedUpUserToken.Id)
  167. So(err, ShouldBeNil)
  168. So(lookedUpModel, ShouldNotBeNil)
  169. So(lookedUpModel.AuthTokenSeen, ShouldBeFalse)
  170. rotated, err = userAuthTokenService.TryRotateToken(userToken, "192.168.10.12:1234", "a new user agent")
  171. So(err, ShouldBeNil)
  172. So(rotated, ShouldBeTrue)
  173. model, err = ctx.getAuthTokenByID(userToken.Id)
  174. So(err, ShouldBeNil)
  175. So(model, ShouldNotBeNil)
  176. So(model.SeenAt, ShouldEqual, 0)
  177. })
  178. Convey("keeps prev token valid for 1 minute after it is confirmed", func() {
  179. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  180. So(err, ShouldBeNil)
  181. So(userToken, ShouldNotBeNil)
  182. lookedUpUserToken, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  183. So(err, ShouldBeNil)
  184. So(lookedUpUserToken, ShouldNotBeNil)
  185. getTime = func() time.Time {
  186. return t.Add(10 * time.Minute)
  187. }
  188. prevToken := userToken.UnhashedToken
  189. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  190. So(err, ShouldBeNil)
  191. So(rotated, ShouldBeTrue)
  192. getTime = func() time.Time {
  193. return t.Add(20 * time.Minute)
  194. }
  195. currentUserToken, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  196. So(err, ShouldBeNil)
  197. So(currentUserToken, ShouldNotBeNil)
  198. prevUserToken, err := userAuthTokenService.LookupToken(prevToken)
  199. So(err, ShouldBeNil)
  200. So(prevUserToken, ShouldNotBeNil)
  201. })
  202. Convey("will not mark token unseen when prev and current are the same", func() {
  203. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  204. So(err, ShouldBeNil)
  205. So(userToken, ShouldNotBeNil)
  206. lookedUpUserToken, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  207. So(err, ShouldBeNil)
  208. So(lookedUpUserToken, ShouldNotBeNil)
  209. lookedUpUserToken, err = userAuthTokenService.LookupToken(userToken.UnhashedToken)
  210. So(err, ShouldBeNil)
  211. So(lookedUpUserToken, ShouldNotBeNil)
  212. lookedUpModel, err := ctx.getAuthTokenByID(lookedUpUserToken.Id)
  213. So(err, ShouldBeNil)
  214. So(lookedUpModel, ShouldNotBeNil)
  215. So(lookedUpModel.AuthTokenSeen, ShouldBeTrue)
  216. })
  217. Convey("Rotate token", func() {
  218. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  219. So(err, ShouldBeNil)
  220. So(userToken, ShouldNotBeNil)
  221. prevToken := userToken.AuthToken
  222. Convey("Should rotate current token and previous token when auth token seen", func() {
  223. updated, err := ctx.markAuthTokenAsSeen(userToken.Id)
  224. So(err, ShouldBeNil)
  225. So(updated, ShouldBeTrue)
  226. getTime = func() time.Time {
  227. return t.Add(10 * time.Minute)
  228. }
  229. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  230. So(err, ShouldBeNil)
  231. So(rotated, ShouldBeTrue)
  232. storedToken, err := ctx.getAuthTokenByID(userToken.Id)
  233. So(err, ShouldBeNil)
  234. So(storedToken, ShouldNotBeNil)
  235. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  236. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  237. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  238. prevToken = storedToken.AuthToken
  239. updated, err = ctx.markAuthTokenAsSeen(userToken.Id)
  240. So(err, ShouldBeNil)
  241. So(updated, ShouldBeTrue)
  242. getTime = func() time.Time {
  243. return t.Add(20 * time.Minute)
  244. }
  245. rotated, err = userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  246. So(err, ShouldBeNil)
  247. So(rotated, ShouldBeTrue)
  248. storedToken, err = ctx.getAuthTokenByID(userToken.Id)
  249. So(err, ShouldBeNil)
  250. So(storedToken, ShouldNotBeNil)
  251. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  252. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  253. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  254. })
  255. Convey("Should rotate current token, but keep previous token when auth token not seen", func() {
  256. userToken.RotatedAt = getTime().Add(-2 * time.Minute).Unix()
  257. getTime = func() time.Time {
  258. return t.Add(2 * time.Minute)
  259. }
  260. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  261. So(err, ShouldBeNil)
  262. So(rotated, ShouldBeTrue)
  263. storedToken, err := ctx.getAuthTokenByID(userToken.Id)
  264. So(err, ShouldBeNil)
  265. So(storedToken, ShouldNotBeNil)
  266. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  267. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  268. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  269. })
  270. })
  271. Convey("When populating userAuthToken from UserToken should copy all properties", func() {
  272. ut := auth.UserToken{
  273. Id: 1,
  274. UserId: 2,
  275. AuthToken: "a",
  276. PrevAuthToken: "b",
  277. UserAgent: "c",
  278. ClientIp: "d",
  279. AuthTokenSeen: true,
  280. SeenAt: 3,
  281. RotatedAt: 4,
  282. CreatedAt: 5,
  283. UpdatedAt: 6,
  284. UnhashedToken: "e",
  285. }
  286. utBytes, err := json.Marshal(ut)
  287. So(err, ShouldBeNil)
  288. utJSON, err := simplejson.NewJson(utBytes)
  289. So(err, ShouldBeNil)
  290. utMap := utJSON.MustMap()
  291. var uat userAuthToken
  292. uat.fromUserToken(&ut)
  293. uatBytes, err := json.Marshal(uat)
  294. So(err, ShouldBeNil)
  295. uatJSON, err := simplejson.NewJson(uatBytes)
  296. So(err, ShouldBeNil)
  297. uatMap := uatJSON.MustMap()
  298. So(uatMap, ShouldResemble, utMap)
  299. })
  300. Convey("When populating userToken from userAuthToken should copy all properties", func() {
  301. uat := userAuthToken{
  302. Id: 1,
  303. UserId: 2,
  304. AuthToken: "a",
  305. PrevAuthToken: "b",
  306. UserAgent: "c",
  307. ClientIp: "d",
  308. AuthTokenSeen: true,
  309. SeenAt: 3,
  310. RotatedAt: 4,
  311. CreatedAt: 5,
  312. UpdatedAt: 6,
  313. UnhashedToken: "e",
  314. }
  315. uatBytes, err := json.Marshal(uat)
  316. So(err, ShouldBeNil)
  317. uatJSON, err := simplejson.NewJson(uatBytes)
  318. So(err, ShouldBeNil)
  319. uatMap := uatJSON.MustMap()
  320. var ut auth.UserToken
  321. err = uat.toUserToken(&ut)
  322. So(err, ShouldBeNil)
  323. utBytes, err := json.Marshal(ut)
  324. So(err, ShouldBeNil)
  325. utJSON, err := simplejson.NewJson(utBytes)
  326. So(err, ShouldBeNil)
  327. utMap := utJSON.MustMap()
  328. So(utMap, ShouldResemble, uatMap)
  329. })
  330. Reset(func() {
  331. getTime = time.Now
  332. })
  333. })
  334. }
  335. func createTestContext(t *testing.T) *testContext {
  336. t.Helper()
  337. sqlstore := sqlstore.InitTestDB(t)
  338. tokenService := &UserAuthTokenServiceImpl{
  339. SQLStore: sqlstore,
  340. Cfg: &setting.Cfg{
  341. LoginMaxInactiveLifetimeDays: 7,
  342. LoginMaxLifetimeDays: 30,
  343. TokenRotationIntervalMinutes: 10,
  344. ExpiredTokensCleanupIntervalDays: 1,
  345. },
  346. log: log.New("test-logger"),
  347. }
  348. return &testContext{
  349. sqlstore: sqlstore,
  350. tokenService: tokenService,
  351. }
  352. }
  353. type testContext struct {
  354. sqlstore *sqlstore.SqlStore
  355. tokenService *UserAuthTokenServiceImpl
  356. }
  357. func (c *testContext) getAuthTokenByID(id int64) (*userAuthToken, error) {
  358. sess := c.sqlstore.NewSession()
  359. var t userAuthToken
  360. found, err := sess.ID(id).Get(&t)
  361. if err != nil || !found {
  362. return nil, err
  363. }
  364. return &t, nil
  365. }
  366. func (c *testContext) markAuthTokenAsSeen(id int64) (bool, error) {
  367. sess := c.sqlstore.NewSession()
  368. res, err := sess.Exec("UPDATE user_auth_token SET auth_token_seen = ? WHERE id = ?", c.sqlstore.Dialect.BooleanStr(true), id)
  369. if err != nil {
  370. return false, err
  371. }
  372. rowsAffected, err := res.RowsAffected()
  373. if err != nil {
  374. return false, err
  375. }
  376. return rowsAffected == 1, nil
  377. }
  378. func (c *testContext) updateRotatedAt(id, rotatedAt int64) (bool, error) {
  379. sess := c.sqlstore.NewSession()
  380. res, err := sess.Exec("UPDATE user_auth_token SET rotated_at = ? WHERE id = ?", rotatedAt, id)
  381. if err != nil {
  382. return false, err
  383. }
  384. rowsAffected, err := res.RowsAffected()
  385. if err != nil {
  386. return false, err
  387. }
  388. return rowsAffected == 1, nil
  389. }