folder_test.go 7.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250
  1. package api
  2. import (
  3. "encoding/json"
  4. "fmt"
  5. "testing"
  6. "github.com/grafana/grafana/pkg/api/dtos"
  7. "github.com/grafana/grafana/pkg/bus"
  8. m "github.com/grafana/grafana/pkg/models"
  9. "github.com/grafana/grafana/pkg/services/dashboards"
  10. "github.com/grafana/grafana/pkg/setting"
  11. . "github.com/smartystreets/goconvey/convey"
  12. )
  13. func TestFoldersApiEndpoint(t *testing.T) {
  14. Convey("Create/update folder response tests", t, func() {
  15. Convey("Given a correct request for creating a folder", func() {
  16. cmd := m.CreateFolderCommand{
  17. Uid: "uid",
  18. Title: "Folder",
  19. }
  20. mock := &fakeFolderService{
  21. CreateFolderResult: &m.Folder{Id: 1, Uid: "uid", Title: "Folder"},
  22. }
  23. createFolderScenario("When calling POST on", "/api/folders", "/api/folders", mock, cmd, func(sc *scenarioContext) {
  24. callCreateFolder(sc)
  25. Convey("It should return correct response data", func() {
  26. folder := dtos.Folder{}
  27. err := json.NewDecoder(sc.resp.Body).Decode(&folder)
  28. So(err, ShouldBeNil)
  29. So(folder.Id, ShouldEqual, 1)
  30. So(folder.Uid, ShouldEqual, "uid")
  31. So(folder.Title, ShouldEqual, "Folder")
  32. })
  33. })
  34. })
  35. Convey("Given incorrect requests for creating a folder", func() {
  36. testCases := []struct {
  37. Error error
  38. ExpectedStatusCode int
  39. }{
  40. {Error: m.ErrFolderWithSameUIDExists, ExpectedStatusCode: 400},
  41. {Error: m.ErrFolderTitleEmpty, ExpectedStatusCode: 400},
  42. {Error: m.ErrFolderSameNameExists, ExpectedStatusCode: 400},
  43. {Error: m.ErrDashboardInvalidUid, ExpectedStatusCode: 400},
  44. {Error: m.ErrDashboardUidToLong, ExpectedStatusCode: 400},
  45. {Error: m.ErrFolderAccessDenied, ExpectedStatusCode: 403},
  46. {Error: m.ErrFolderNotFound, ExpectedStatusCode: 404},
  47. {Error: m.ErrFolderVersionMismatch, ExpectedStatusCode: 412},
  48. {Error: m.ErrFolderFailedGenerateUniqueUid, ExpectedStatusCode: 500},
  49. }
  50. cmd := m.CreateFolderCommand{
  51. Uid: "uid",
  52. Title: "Folder",
  53. }
  54. for _, tc := range testCases {
  55. mock := &fakeFolderService{
  56. CreateFolderError: tc.Error,
  57. }
  58. createFolderScenario(fmt.Sprintf("Expect '%s' error when calling POST on", tc.Error.Error()), "/api/folders", "/api/folders", mock, cmd, func(sc *scenarioContext) {
  59. callCreateFolder(sc)
  60. if sc.resp.Code != tc.ExpectedStatusCode {
  61. t.Errorf("For error '%s' expected status code %d, actual %d", tc.Error, tc.ExpectedStatusCode, sc.resp.Code)
  62. }
  63. })
  64. }
  65. })
  66. Convey("Given a correct request for updating a folder", func() {
  67. cmd := m.UpdateFolderCommand{
  68. Title: "Folder upd",
  69. }
  70. mock := &fakeFolderService{
  71. UpdateFolderResult: &m.Folder{Id: 1, Uid: "uid", Title: "Folder upd"},
  72. }
  73. updateFolderScenario("When calling PUT on", "/api/folders/uid", "/api/folders/:uid", mock, cmd, func(sc *scenarioContext) {
  74. callUpdateFolder(sc)
  75. Convey("It should return correct response data", func() {
  76. folder := dtos.Folder{}
  77. err := json.NewDecoder(sc.resp.Body).Decode(&folder)
  78. So(err, ShouldBeNil)
  79. So(folder.Id, ShouldEqual, 1)
  80. So(folder.Uid, ShouldEqual, "uid")
  81. So(folder.Title, ShouldEqual, "Folder upd")
  82. })
  83. })
  84. })
  85. Convey("Given incorrect requests for updating a folder", func() {
  86. testCases := []struct {
  87. Error error
  88. ExpectedStatusCode int
  89. }{
  90. {Error: m.ErrFolderWithSameUIDExists, ExpectedStatusCode: 400},
  91. {Error: m.ErrFolderTitleEmpty, ExpectedStatusCode: 400},
  92. {Error: m.ErrFolderSameNameExists, ExpectedStatusCode: 400},
  93. {Error: m.ErrDashboardInvalidUid, ExpectedStatusCode: 400},
  94. {Error: m.ErrDashboardUidToLong, ExpectedStatusCode: 400},
  95. {Error: m.ErrFolderAccessDenied, ExpectedStatusCode: 403},
  96. {Error: m.ErrFolderNotFound, ExpectedStatusCode: 404},
  97. {Error: m.ErrFolderVersionMismatch, ExpectedStatusCode: 412},
  98. {Error: m.ErrFolderFailedGenerateUniqueUid, ExpectedStatusCode: 500},
  99. }
  100. cmd := m.UpdateFolderCommand{
  101. Title: "Folder upd",
  102. }
  103. for _, tc := range testCases {
  104. mock := &fakeFolderService{
  105. UpdateFolderError: tc.Error,
  106. }
  107. updateFolderScenario(fmt.Sprintf("Expect '%s' error when calling PUT on", tc.Error.Error()), "/api/folders/uid", "/api/folders/:uid", mock, cmd, func(sc *scenarioContext) {
  108. callUpdateFolder(sc)
  109. if sc.resp.Code != tc.ExpectedStatusCode {
  110. t.Errorf("For error '%s' expected status code %d, actual %d", tc.Error, tc.ExpectedStatusCode, sc.resp.Code)
  111. }
  112. })
  113. }
  114. })
  115. })
  116. }
  117. func callCreateFolder(sc *scenarioContext) {
  118. sc.fakeReqWithParams("POST", sc.url, map[string]string{}).exec()
  119. }
  120. func createFolderScenario(desc string, url string, routePattern string, mock *fakeFolderService, cmd m.CreateFolderCommand, fn scenarioFunc) {
  121. Convey(desc+" "+url, func() {
  122. defer bus.ClearBusHandlers()
  123. cfg := setting.NewCfg()
  124. cfg.EditorsCanAdmin = true
  125. hs := HTTPServer{
  126. Bus: bus.GetBus(),
  127. Cfg: cfg,
  128. }
  129. sc := setupScenarioContext(url)
  130. sc.defaultHandler = Wrap(func(c *m.ReqContext) Response {
  131. sc.context = c
  132. sc.context.SignedInUser = &m.SignedInUser{OrgId: TestOrgID, UserId: TestUserID}
  133. return hs.CreateFolder(c, cmd)
  134. })
  135. origNewFolderService := dashboards.NewFolderService
  136. mockFolderService(mock)
  137. sc.m.Post(routePattern, sc.defaultHandler)
  138. defer func() {
  139. dashboards.NewFolderService = origNewFolderService
  140. }()
  141. fn(sc)
  142. })
  143. }
  144. func callUpdateFolder(sc *scenarioContext) {
  145. sc.fakeReqWithParams("PUT", sc.url, map[string]string{}).exec()
  146. }
  147. func updateFolderScenario(desc string, url string, routePattern string, mock *fakeFolderService, cmd m.UpdateFolderCommand, fn scenarioFunc) {
  148. Convey(desc+" "+url, func() {
  149. defer bus.ClearBusHandlers()
  150. sc := setupScenarioContext(url)
  151. sc.defaultHandler = Wrap(func(c *m.ReqContext) Response {
  152. sc.context = c
  153. sc.context.SignedInUser = &m.SignedInUser{OrgId: TestOrgID, UserId: TestUserID}
  154. return UpdateFolder(c, cmd)
  155. })
  156. origNewFolderService := dashboards.NewFolderService
  157. mockFolderService(mock)
  158. sc.m.Put(routePattern, sc.defaultHandler)
  159. defer func() {
  160. dashboards.NewFolderService = origNewFolderService
  161. }()
  162. fn(sc)
  163. })
  164. }
  165. type fakeFolderService struct {
  166. GetFoldersResult []*m.Folder
  167. GetFoldersError error
  168. GetFolderByUIDResult *m.Folder
  169. GetFolderByUIDError error
  170. GetFolderByIDResult *m.Folder
  171. GetFolderByIDError error
  172. CreateFolderResult *m.Folder
  173. CreateFolderError error
  174. UpdateFolderResult *m.Folder
  175. UpdateFolderError error
  176. DeleteFolderResult *m.Folder
  177. DeleteFolderError error
  178. DeletedFolderUids []string
  179. }
  180. func (s *fakeFolderService) GetFolders(limit int) ([]*m.Folder, error) {
  181. return s.GetFoldersResult, s.GetFoldersError
  182. }
  183. func (s *fakeFolderService) GetFolderByID(id int64) (*m.Folder, error) {
  184. return s.GetFolderByIDResult, s.GetFolderByIDError
  185. }
  186. func (s *fakeFolderService) GetFolderByUID(uid string) (*m.Folder, error) {
  187. return s.GetFolderByUIDResult, s.GetFolderByUIDError
  188. }
  189. func (s *fakeFolderService) CreateFolder(cmd *m.CreateFolderCommand) error {
  190. cmd.Result = s.CreateFolderResult
  191. return s.CreateFolderError
  192. }
  193. func (s *fakeFolderService) UpdateFolder(existingUID string, cmd *m.UpdateFolderCommand) error {
  194. cmd.Result = s.UpdateFolderResult
  195. return s.UpdateFolderError
  196. }
  197. func (s *fakeFolderService) DeleteFolder(uid string) (*m.Folder, error) {
  198. s.DeletedFolderUids = append(s.DeletedFolderUids, uid)
  199. return s.DeleteFolderResult, s.DeleteFolderError
  200. }
  201. func mockFolderService(mock *fakeFolderService) {
  202. dashboards.NewFolderService = func(orgId int64, user *m.SignedInUser) dashboards.FolderService {
  203. return mock
  204. }
  205. }