config_reader_test.go 7.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252
  1. package datasources
  2. import (
  3. "testing"
  4. "github.com/grafana/grafana/pkg/bus"
  5. "github.com/grafana/grafana/pkg/log"
  6. "github.com/grafana/grafana/pkg/models"
  7. . "github.com/smartystreets/goconvey/convey"
  8. )
  9. var (
  10. logger log.Logger = log.New("fake.log")
  11. twoDatasourcesConfig = "./test-configs/two-datasources"
  12. twoDatasourcesConfigPurgeOthers = "./test-configs/insert-two-delete-two"
  13. doubleDatasourcesConfig = "./test-configs/double-default"
  14. allProperties = "./test-configs/all-properties"
  15. versionZero = "./test-configs/version-0"
  16. brokenYaml = "./test-configs/broken-yaml"
  17. fakeRepo *fakeRepository
  18. )
  19. func TestDatasourceAsConfig(t *testing.T) {
  20. Convey("Testing datasource as configuration", t, func() {
  21. fakeRepo = &fakeRepository{}
  22. bus.ClearBusHandlers()
  23. bus.AddHandler("test", mockDelete)
  24. bus.AddHandler("test", mockInsert)
  25. bus.AddHandler("test", mockUpdate)
  26. bus.AddHandler("test", mockGet)
  27. bus.AddHandler("test", mockGetAll)
  28. Convey("One configured datasource", func() {
  29. Convey("no datasource in database", func() {
  30. dc := newDatasourceProvisioner(logger)
  31. err := dc.applyChanges(twoDatasourcesConfig)
  32. if err != nil {
  33. t.Fatalf("applyChanges return an error %v", err)
  34. }
  35. So(len(fakeRepo.deleted), ShouldEqual, 0)
  36. So(len(fakeRepo.inserted), ShouldEqual, 2)
  37. So(len(fakeRepo.updated), ShouldEqual, 0)
  38. })
  39. Convey("One datasource in database with same name", func() {
  40. fakeRepo.loadAll = []*models.DataSource{
  41. {Name: "Graphite", OrgId: 1, Id: 1},
  42. }
  43. Convey("should update one datasource", func() {
  44. dc := newDatasourceProvisioner(logger)
  45. err := dc.applyChanges(twoDatasourcesConfig)
  46. if err != nil {
  47. t.Fatalf("applyChanges return an error %v", err)
  48. }
  49. So(len(fakeRepo.deleted), ShouldEqual, 0)
  50. So(len(fakeRepo.inserted), ShouldEqual, 1)
  51. So(len(fakeRepo.updated), ShouldEqual, 1)
  52. })
  53. })
  54. Convey("Two datasources with is_default", func() {
  55. dc := newDatasourceProvisioner(logger)
  56. err := dc.applyChanges(doubleDatasourcesConfig)
  57. Convey("should raise error", func() {
  58. So(err, ShouldEqual, ErrInvalidConfigToManyDefault)
  59. })
  60. })
  61. })
  62. Convey("Two configured datasource and purge others ", func() {
  63. Convey("two other datasources in database", func() {
  64. fakeRepo.loadAll = []*models.DataSource{
  65. {Name: "old-graphite", OrgId: 1, Id: 1},
  66. {Name: "old-graphite2", OrgId: 1, Id: 2},
  67. }
  68. Convey("should have two new datasources", func() {
  69. dc := newDatasourceProvisioner(logger)
  70. err := dc.applyChanges(twoDatasourcesConfigPurgeOthers)
  71. if err != nil {
  72. t.Fatalf("applyChanges return an error %v", err)
  73. }
  74. So(len(fakeRepo.deleted), ShouldEqual, 2)
  75. So(len(fakeRepo.inserted), ShouldEqual, 2)
  76. So(len(fakeRepo.updated), ShouldEqual, 0)
  77. })
  78. })
  79. })
  80. Convey("Two configured datasource and purge others = false", func() {
  81. Convey("two other datasources in database", func() {
  82. fakeRepo.loadAll = []*models.DataSource{
  83. {Name: "Graphite", OrgId: 1, Id: 1},
  84. {Name: "old-graphite2", OrgId: 1, Id: 2},
  85. }
  86. Convey("should have two new datasources", func() {
  87. dc := newDatasourceProvisioner(logger)
  88. err := dc.applyChanges(twoDatasourcesConfig)
  89. if err != nil {
  90. t.Fatalf("applyChanges return an error %v", err)
  91. }
  92. So(len(fakeRepo.deleted), ShouldEqual, 0)
  93. So(len(fakeRepo.inserted), ShouldEqual, 1)
  94. So(len(fakeRepo.updated), ShouldEqual, 1)
  95. })
  96. })
  97. })
  98. Convey("broken yaml should return error", func() {
  99. reader := &configReader{}
  100. _, err := reader.readConfig(brokenYaml)
  101. So(err, ShouldNotBeNil)
  102. })
  103. Convey("skip invalid directory", func() {
  104. cfgProvifer := &configReader{log: log.New("test logger")}
  105. cfg, err := cfgProvifer.readConfig("./invalid-directory")
  106. if err != nil {
  107. t.Fatalf("readConfig return an error %v", err)
  108. }
  109. So(len(cfg), ShouldEqual, 0)
  110. })
  111. Convey("can read all properties from version 1", func() {
  112. cfgProvifer := &configReader{log: log.New("test logger")}
  113. cfg, err := cfgProvifer.readConfig(allProperties)
  114. if err != nil {
  115. t.Fatalf("readConfig return an error %v", err)
  116. }
  117. So(len(cfg), ShouldEqual, 3)
  118. dsCfg := cfg[0]
  119. So(dsCfg.ApiVersion, ShouldEqual, 1)
  120. validateDatasource(dsCfg)
  121. validateDeleteDatasources(dsCfg)
  122. dsCount := 0
  123. delDsCount := 0
  124. for _, c := range cfg {
  125. dsCount += len(c.Datasources)
  126. delDsCount += len(c.DeleteDatasources)
  127. }
  128. So(dsCount, ShouldEqual, 2)
  129. So(delDsCount, ShouldEqual, 1)
  130. })
  131. Convey("can read all properties from version 0", func() {
  132. cfgProvifer := &configReader{log: log.New("test logger")}
  133. cfg, err := cfgProvifer.readConfig(versionZero)
  134. if err != nil {
  135. t.Fatalf("readConfig return an error %v", err)
  136. }
  137. So(len(cfg), ShouldEqual, 1)
  138. dsCfg := cfg[0]
  139. So(dsCfg.ApiVersion, ShouldEqual, 0)
  140. validateDatasource(dsCfg)
  141. validateDeleteDatasources(dsCfg)
  142. })
  143. })
  144. }
  145. func validateDeleteDatasources(dsCfg *DatasourcesAsConfig) {
  146. So(len(dsCfg.DeleteDatasources), ShouldEqual, 1)
  147. deleteDs := dsCfg.DeleteDatasources[0]
  148. So(deleteDs.Name, ShouldEqual, "old-graphite3")
  149. So(deleteDs.OrgId, ShouldEqual, 2)
  150. }
  151. func validateDatasource(dsCfg *DatasourcesAsConfig) {
  152. ds := dsCfg.Datasources[0]
  153. So(ds.Name, ShouldEqual, "name")
  154. So(ds.Type, ShouldEqual, "type")
  155. So(ds.Access, ShouldEqual, models.DS_ACCESS_PROXY)
  156. So(ds.OrgId, ShouldEqual, 2)
  157. So(ds.Url, ShouldEqual, "url")
  158. So(ds.User, ShouldEqual, "user")
  159. So(ds.Password, ShouldEqual, "password")
  160. So(ds.Database, ShouldEqual, "database")
  161. So(ds.BasicAuth, ShouldBeTrue)
  162. So(ds.BasicAuthUser, ShouldEqual, "basic_auth_user")
  163. So(ds.BasicAuthPassword, ShouldEqual, "basic_auth_password")
  164. So(ds.WithCredentials, ShouldBeTrue)
  165. So(ds.IsDefault, ShouldBeTrue)
  166. So(ds.Editable, ShouldBeTrue)
  167. So(ds.Version, ShouldEqual, 10)
  168. So(len(ds.JsonData), ShouldBeGreaterThan, 2)
  169. So(ds.JsonData["graphiteVersion"], ShouldEqual, "1.1")
  170. So(ds.JsonData["tlsAuth"], ShouldEqual, true)
  171. So(ds.JsonData["tlsAuthWithCACert"], ShouldEqual, true)
  172. So(len(ds.SecureJsonData), ShouldBeGreaterThan, 2)
  173. So(ds.SecureJsonData["tlsCACert"], ShouldEqual, "MjNOcW9RdkbUDHZmpco2HCYzVq9dE+i6Yi+gmUJotq5CDA==")
  174. So(ds.SecureJsonData["tlsClientCert"], ShouldEqual, "ckN0dGlyMXN503YNfjTcf9CV+GGQneN+xmAclQ==")
  175. So(ds.SecureJsonData["tlsClientKey"], ShouldEqual, "ZkN4aG1aNkja/gKAB1wlnKFIsy2SRDq4slrM0A==")
  176. }
  177. type fakeRepository struct {
  178. inserted []*models.AddDataSourceCommand
  179. deleted []*models.DeleteDataSourceByNameCommand
  180. updated []*models.UpdateDataSourceCommand
  181. loadAll []*models.DataSource
  182. }
  183. func mockDelete(cmd *models.DeleteDataSourceByNameCommand) error {
  184. fakeRepo.deleted = append(fakeRepo.deleted, cmd)
  185. return nil
  186. }
  187. func mockUpdate(cmd *models.UpdateDataSourceCommand) error {
  188. fakeRepo.updated = append(fakeRepo.updated, cmd)
  189. return nil
  190. }
  191. func mockInsert(cmd *models.AddDataSourceCommand) error {
  192. fakeRepo.inserted = append(fakeRepo.inserted, cmd)
  193. return nil
  194. }
  195. func mockGetAll(cmd *models.GetAllDataSourcesQuery) error {
  196. cmd.Result = fakeRepo.loadAll
  197. return nil
  198. }
  199. func mockGet(cmd *models.GetDataSourceByNameQuery) error {
  200. for _, v := range fakeRepo.loadAll {
  201. if cmd.Name == v.Name && cmd.OrgId == v.OrgId {
  202. cmd.Result = v
  203. return nil
  204. }
  205. }
  206. return models.ErrDataSourceNotFound
  207. }