alert_rule_test.go 5.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220
  1. package sqlstore
  2. import (
  3. "testing"
  4. m "github.com/grafana/grafana/pkg/models"
  5. . "github.com/smartystreets/goconvey/convey"
  6. )
  7. func TestAlertingDataAccess(t *testing.T) {
  8. Convey("Testing Alerting data access", t, func() {
  9. InitTestDB(t)
  10. testDash := insertTestDashboard("dashboard with alerts", 1, "alert")
  11. items := []m.AlertRule{
  12. {
  13. PanelId: 1,
  14. DashboardId: testDash.Id,
  15. OrgId: testDash.OrgId,
  16. Query: "Query",
  17. QueryRefId: "A",
  18. WarnLevel: "> 30",
  19. CritLevel: "> 50",
  20. Interval: "10",
  21. Title: "Alerting title",
  22. Description: "Alerting description",
  23. QueryRange: "5m",
  24. Aggregator: "avg",
  25. State: "OK",
  26. },
  27. }
  28. cmd := m.SaveAlertsCommand{
  29. Alerts: &items,
  30. DashboardId: testDash.Id,
  31. OrgId: 1,
  32. UserId: 1,
  33. }
  34. err := SaveAlerts(&cmd)
  35. Convey("Can create one alert", func() {
  36. So(err, ShouldBeNil)
  37. query := &m.GetAlertChangesQuery{OrgId: 1}
  38. er := GetAlertRuleChanges(query)
  39. So(er, ShouldBeNil)
  40. So(len(query.Result), ShouldEqual, 1)
  41. })
  42. Convey("Can read properties", func() {
  43. query := m.GetAlertForPanelQuery{
  44. DashboardId: testDash.Id,
  45. PanelId: 1,
  46. }
  47. err2 := GetAlertsByDashboardAndPanelId(&query)
  48. So(err2, ShouldBeNil)
  49. So(query.Result.Interval, ShouldEqual, "10")
  50. So(query.Result.WarnLevel, ShouldEqual, "> 30")
  51. So(query.Result.CritLevel, ShouldEqual, "> 50")
  52. So(query.Result.Query, ShouldEqual, "Query")
  53. So(query.Result.QueryRefId, ShouldEqual, "A")
  54. So(query.Result.Title, ShouldEqual, "Alerting title")
  55. So(query.Result.Description, ShouldEqual, "Alerting description")
  56. So(query.Result.QueryRange, ShouldEqual, "5m")
  57. So(query.Result.Aggregator, ShouldEqual, "avg")
  58. So(query.Result.State, ShouldEqual, "OK")
  59. })
  60. Convey("Alerts with same dashboard id and panel id should update", func() {
  61. modifiedItems := items
  62. modifiedItems[0].Query = "Updated Query"
  63. modifiedItems[0].State = "ALERT"
  64. modifiedCmd := m.SaveAlertsCommand{
  65. DashboardId: testDash.Id,
  66. OrgId: 1,
  67. UserId: 1,
  68. Alerts: &modifiedItems,
  69. }
  70. err := SaveAlerts(&modifiedCmd)
  71. Convey("Can save alerts with same dashboard and panel id", func() {
  72. So(err, ShouldBeNil)
  73. })
  74. Convey("Alerts should be updated", func() {
  75. query := m.GetAlertsForDashboardQuery{DashboardId: testDash.Id}
  76. err2 := GetAlertsByDashboardId(&query)
  77. So(err2, ShouldBeNil)
  78. So(len(query.Result), ShouldEqual, 1)
  79. So(query.Result[0].Query, ShouldEqual, "Updated Query")
  80. Convey("Alert state should not be updated", func() {
  81. So(query.Result[0].State, ShouldEqual, "OK")
  82. })
  83. })
  84. Convey("Updates without changes should be ignored", func() {
  85. err3 := SaveAlerts(&modifiedCmd)
  86. So(err3, ShouldBeNil)
  87. query := &m.GetAlertChangesQuery{OrgId: 1}
  88. er := GetAlertRuleChanges(query)
  89. So(er, ShouldBeNil)
  90. So(len(query.Result), ShouldEqual, 2)
  91. })
  92. })
  93. Convey("Multiple alerts per dashboard", func() {
  94. multipleItems := []m.AlertRule{
  95. {
  96. DashboardId: testDash.Id,
  97. PanelId: 1,
  98. Query: "1",
  99. OrgId: 1,
  100. },
  101. {
  102. DashboardId: testDash.Id,
  103. PanelId: 2,
  104. Query: "2",
  105. OrgId: 1,
  106. },
  107. {
  108. DashboardId: testDash.Id,
  109. PanelId: 3,
  110. Query: "3",
  111. OrgId: 1,
  112. },
  113. }
  114. cmd.Alerts = &multipleItems
  115. err = SaveAlerts(&cmd)
  116. Convey("Should save 3 dashboards", func() {
  117. So(err, ShouldBeNil)
  118. queryForDashboard := m.GetAlertsForDashboardQuery{DashboardId: testDash.Id}
  119. err2 := GetAlertsByDashboardId(&queryForDashboard)
  120. So(err2, ShouldBeNil)
  121. So(len(queryForDashboard.Result), ShouldEqual, 3)
  122. query := &m.GetAlertChangesQuery{OrgId: 1}
  123. er := GetAlertRuleChanges(query)
  124. So(er, ShouldBeNil)
  125. So(len(query.Result), ShouldEqual, 4)
  126. })
  127. Convey("should updated two dashboards and delete one", func() {
  128. missingOneAlert := multipleItems[:2]
  129. cmd.Alerts = &missingOneAlert
  130. err = SaveAlerts(&cmd)
  131. Convey("should delete the missing alert", func() {
  132. query := m.GetAlertsForDashboardQuery{DashboardId: testDash.Id}
  133. err2 := GetAlertsByDashboardId(&query)
  134. So(err2, ShouldBeNil)
  135. So(len(query.Result), ShouldEqual, 2)
  136. })
  137. Convey("should add one more alert_rule_change", func() {
  138. query := &m.GetAlertChangesQuery{OrgId: 1}
  139. er := GetAlertRuleChanges(query)
  140. So(er, ShouldBeNil)
  141. So(len(query.Result), ShouldEqual, 6)
  142. })
  143. })
  144. })
  145. Convey("When dashboard is removed", func() {
  146. items := []m.AlertRule{
  147. {
  148. PanelId: 1,
  149. DashboardId: testDash.Id,
  150. Query: "Query",
  151. QueryRefId: "A",
  152. WarnLevel: "> 30",
  153. CritLevel: "> 50",
  154. Interval: "10",
  155. Title: "Alerting title",
  156. Description: "Alerting description",
  157. QueryRange: "5m",
  158. Aggregator: "avg",
  159. },
  160. }
  161. cmd := m.SaveAlertsCommand{
  162. Alerts: &items,
  163. DashboardId: testDash.Id,
  164. OrgId: 1,
  165. UserId: 1,
  166. }
  167. SaveAlerts(&cmd)
  168. err = DeleteDashboard(&m.DeleteDashboardCommand{
  169. OrgId: 1,
  170. Slug: testDash.Slug,
  171. })
  172. So(err, ShouldBeNil)
  173. Convey("Alerts should be removed", func() {
  174. query := m.GetAlertsForDashboardQuery{DashboardId: testDash.Id}
  175. err2 := GetAlertsByDashboardId(&query)
  176. So(testDash.Id, ShouldEqual, 1)
  177. So(err2, ShouldBeNil)
  178. So(len(query.Result), ShouldEqual, 0)
  179. })
  180. })
  181. })
  182. }