folder_test.go 7.7 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254
  1. package api
  2. import (
  3. "encoding/json"
  4. "fmt"
  5. "testing"
  6. "github.com/grafana/grafana/pkg/api/dtos"
  7. "github.com/grafana/grafana/pkg/bus"
  8. "github.com/grafana/grafana/pkg/middleware"
  9. "github.com/grafana/grafana/pkg/models"
  10. "github.com/grafana/grafana/pkg/services/dashboards"
  11. m "github.com/grafana/grafana/pkg/models"
  12. . "github.com/smartystreets/goconvey/convey"
  13. )
  14. func TestFoldersApiEndpoint(t *testing.T) {
  15. Convey("Create/update folder response tests", t, func() {
  16. Convey("Given a correct request for creating a folder", func() {
  17. cmd := m.CreateFolderCommand{
  18. Uid: "uid",
  19. Title: "Folder",
  20. }
  21. mock := &fakeFolderService{
  22. CreateFolderResult: &m.Folder{Id: 1, Uid: "uid", Title: "Folder"},
  23. }
  24. createFolderScenario("When calling POST on", "/api/folders", "/api/folders", mock, cmd, func(sc *scenarioContext) {
  25. callCreateFolder(sc)
  26. Convey("It should return correct response data", func() {
  27. folder := dtos.Folder{}
  28. err := json.NewDecoder(sc.resp.Body).Decode(&folder)
  29. So(err, ShouldBeNil)
  30. So(folder.Id, ShouldEqual, 1)
  31. So(folder.Uid, ShouldEqual, "uid")
  32. So(folder.Title, ShouldEqual, "Folder")
  33. })
  34. })
  35. })
  36. Convey("Given incorrect requests for creating a folder", func() {
  37. testCases := []struct {
  38. Error error
  39. ExpectedStatusCode int
  40. }{
  41. {Error: m.ErrFolderWithSameUIDExists, ExpectedStatusCode: 400},
  42. {Error: m.ErrFolderTitleEmpty, ExpectedStatusCode: 400},
  43. {Error: m.ErrFolderSameNameExists, ExpectedStatusCode: 400},
  44. {Error: m.ErrDashboardInvalidUid, ExpectedStatusCode: 400},
  45. {Error: m.ErrDashboardUidToLong, ExpectedStatusCode: 400},
  46. {Error: m.ErrFolderAccessDenied, ExpectedStatusCode: 403},
  47. {Error: m.ErrFolderNotFound, ExpectedStatusCode: 404},
  48. {Error: m.ErrFolderVersionMismatch, ExpectedStatusCode: 412},
  49. {Error: m.ErrFolderFailedGenerateUniqueUid, ExpectedStatusCode: 500},
  50. }
  51. cmd := m.CreateFolderCommand{
  52. Uid: "uid",
  53. Title: "Folder",
  54. }
  55. for _, tc := range testCases {
  56. mock := &fakeFolderService{
  57. CreateFolderError: tc.Error,
  58. }
  59. createFolderScenario(fmt.Sprintf("Expect '%s' error when calling POST on", tc.Error.Error()), "/api/folders", "/api/folders", mock, cmd, func(sc *scenarioContext) {
  60. callCreateFolder(sc)
  61. if sc.resp.Code != tc.ExpectedStatusCode {
  62. t.Errorf("For error '%s' expected status code %d, actual %d", tc.Error, tc.ExpectedStatusCode, sc.resp.Code)
  63. }
  64. })
  65. }
  66. })
  67. Convey("Given a correct request for updating a folder", func() {
  68. cmd := m.UpdateFolderCommand{
  69. Title: "Folder upd",
  70. }
  71. mock := &fakeFolderService{
  72. UpdateFolderResult: &m.Folder{Id: 1, Uid: "uid", Title: "Folder upd"},
  73. }
  74. updateFolderScenario("When calling PUT on", "/api/folders/uid", "/api/folders/:uid", mock, cmd, func(sc *scenarioContext) {
  75. callUpdateFolder(sc)
  76. Convey("It should return correct response data", func() {
  77. folder := dtos.Folder{}
  78. err := json.NewDecoder(sc.resp.Body).Decode(&folder)
  79. So(err, ShouldBeNil)
  80. So(folder.Id, ShouldEqual, 1)
  81. So(folder.Uid, ShouldEqual, "uid")
  82. So(folder.Title, ShouldEqual, "Folder upd")
  83. })
  84. })
  85. })
  86. Convey("Given incorrect requests for updating a folder", func() {
  87. testCases := []struct {
  88. Error error
  89. ExpectedStatusCode int
  90. }{
  91. {Error: m.ErrFolderWithSameUIDExists, ExpectedStatusCode: 400},
  92. {Error: m.ErrFolderTitleEmpty, ExpectedStatusCode: 400},
  93. {Error: m.ErrFolderSameNameExists, ExpectedStatusCode: 400},
  94. {Error: m.ErrDashboardInvalidUid, ExpectedStatusCode: 400},
  95. {Error: m.ErrDashboardUidToLong, ExpectedStatusCode: 400},
  96. {Error: m.ErrFolderAccessDenied, ExpectedStatusCode: 403},
  97. {Error: m.ErrFolderNotFound, ExpectedStatusCode: 404},
  98. {Error: m.ErrFolderVersionMismatch, ExpectedStatusCode: 412},
  99. {Error: m.ErrFolderFailedGenerateUniqueUid, ExpectedStatusCode: 500},
  100. }
  101. cmd := m.UpdateFolderCommand{
  102. Title: "Folder upd",
  103. }
  104. for _, tc := range testCases {
  105. mock := &fakeFolderService{
  106. UpdateFolderError: tc.Error,
  107. }
  108. updateFolderScenario(fmt.Sprintf("Expect '%s' error when calling PUT on", tc.Error.Error()), "/api/folders/uid", "/api/folders/:uid", mock, cmd, func(sc *scenarioContext) {
  109. callUpdateFolder(sc)
  110. if sc.resp.Code != tc.ExpectedStatusCode {
  111. t.Errorf("For error '%s' expected status code %d, actual %d", tc.Error, tc.ExpectedStatusCode, sc.resp.Code)
  112. }
  113. })
  114. }
  115. })
  116. })
  117. }
  118. func callGetFolderByUid(sc *scenarioContext) {
  119. sc.handlerFunc = GetFolderByUid
  120. sc.fakeReqWithParams("GET", sc.url, map[string]string{}).exec()
  121. }
  122. func callDeleteFolder(sc *scenarioContext) {
  123. sc.handlerFunc = DeleteFolder
  124. sc.fakeReqWithParams("DELETE", sc.url, map[string]string{}).exec()
  125. }
  126. func callCreateFolder(sc *scenarioContext) {
  127. sc.fakeReqWithParams("POST", sc.url, map[string]string{}).exec()
  128. }
  129. func createFolderScenario(desc string, url string, routePattern string, mock *fakeFolderService, cmd m.CreateFolderCommand, fn scenarioFunc) {
  130. Convey(desc+" "+url, func() {
  131. defer bus.ClearBusHandlers()
  132. sc := setupScenarioContext(url)
  133. sc.defaultHandler = wrap(func(c *middleware.Context) Response {
  134. sc.context = c
  135. sc.context.SignedInUser = &m.SignedInUser{OrgId: TestOrgID, UserId: TestUserID}
  136. return CreateFolder(c, cmd)
  137. })
  138. origNewFolderService := dashboards.NewFolderService
  139. mockFolderService(mock)
  140. sc.m.Post(routePattern, sc.defaultHandler)
  141. defer func() {
  142. dashboards.NewFolderService = origNewFolderService
  143. }()
  144. fn(sc)
  145. })
  146. }
  147. func callUpdateFolder(sc *scenarioContext) {
  148. sc.fakeReqWithParams("PUT", sc.url, map[string]string{}).exec()
  149. }
  150. func updateFolderScenario(desc string, url string, routePattern string, mock *fakeFolderService, cmd m.UpdateFolderCommand, fn scenarioFunc) {
  151. Convey(desc+" "+url, func() {
  152. defer bus.ClearBusHandlers()
  153. sc := setupScenarioContext(url)
  154. sc.defaultHandler = wrap(func(c *middleware.Context) Response {
  155. sc.context = c
  156. sc.context.SignedInUser = &m.SignedInUser{OrgId: TestOrgID, UserId: TestUserID}
  157. return UpdateFolder(c, cmd)
  158. })
  159. origNewFolderService := dashboards.NewFolderService
  160. mockFolderService(mock)
  161. sc.m.Put(routePattern, sc.defaultHandler)
  162. defer func() {
  163. dashboards.NewFolderService = origNewFolderService
  164. }()
  165. fn(sc)
  166. })
  167. }
  168. type fakeFolderService struct {
  169. GetFoldersResult []*models.Folder
  170. GetFoldersError error
  171. GetFolderByUidResult *models.Folder
  172. GetFolderByUidError error
  173. GetFolderByIdResult *models.Folder
  174. GetFolderByIdError error
  175. CreateFolderResult *models.Folder
  176. CreateFolderError error
  177. UpdateFolderResult *models.Folder
  178. UpdateFolderError error
  179. DeleteFolderResult *models.Folder
  180. DeleteFolderError error
  181. DeletedFolderUids []string
  182. }
  183. func (s *fakeFolderService) GetFolders(limit int) ([]*models.Folder, error) {
  184. return s.GetFoldersResult, s.GetFoldersError
  185. }
  186. func (s *fakeFolderService) GetFolderById(id int64) (*models.Folder, error) {
  187. return s.GetFolderByIdResult, s.GetFolderByIdError
  188. }
  189. func (s *fakeFolderService) GetFolderByUid(uid string) (*models.Folder, error) {
  190. return s.GetFolderByUidResult, s.GetFolderByUidError
  191. }
  192. func (s *fakeFolderService) CreateFolder(cmd *models.CreateFolderCommand) error {
  193. cmd.Result = s.CreateFolderResult
  194. return s.CreateFolderError
  195. }
  196. func (s *fakeFolderService) UpdateFolder(existingUid string, cmd *models.UpdateFolderCommand) error {
  197. cmd.Result = s.UpdateFolderResult
  198. return s.UpdateFolderError
  199. }
  200. func (s *fakeFolderService) DeleteFolder(uid string) (*models.Folder, error) {
  201. s.DeletedFolderUids = append(s.DeletedFolderUids, uid)
  202. return s.DeleteFolderResult, s.DeleteFolderError
  203. }
  204. func mockFolderService(mock *fakeFolderService) {
  205. dashboards.NewFolderService = func(orgId int64, user *models.SignedInUser) dashboards.FolderService {
  206. return mock
  207. }
  208. }