file_reader_test.go 7.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289
  1. package dashboards
  2. import (
  3. "os"
  4. "path/filepath"
  5. "testing"
  6. "time"
  7. "github.com/grafana/grafana/pkg/bus"
  8. "github.com/grafana/grafana/pkg/models"
  9. "github.com/grafana/grafana/pkg/services/dashboards"
  10. "github.com/grafana/grafana/pkg/log"
  11. . "github.com/smartystreets/goconvey/convey"
  12. )
  13. var (
  14. defaultDashboards = "testdata/test-dashboards/folder-one"
  15. brokenDashboards = "testdata/test-dashboards/broken-dashboards"
  16. oneDashboard = "testdata/test-dashboards/one-dashboard"
  17. containingId = "testdata/test-dashboards/containing-id"
  18. fakeService *fakeDashboardProvisioningService
  19. )
  20. func TestCreatingNewDashboardFileReader(t *testing.T) {
  21. Convey("creating new dashboard file reader", t, func() {
  22. cfg := &DashboardsAsConfig{
  23. Name: "Default",
  24. Type: "file",
  25. OrgId: 1,
  26. Folder: "",
  27. Options: map[string]interface{}{},
  28. }
  29. Convey("using path parameter", func() {
  30. cfg.Options["path"] = defaultDashboards
  31. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  32. So(err, ShouldBeNil)
  33. So(reader.Path, ShouldNotEqual, "")
  34. })
  35. Convey("using folder as options", func() {
  36. cfg.Options["folder"] = defaultDashboards
  37. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  38. So(err, ShouldBeNil)
  39. So(reader.Path, ShouldNotEqual, "")
  40. })
  41. Convey("using full path", func() {
  42. cfg.Options["folder"] = "/var/lib/grafana/dashboards"
  43. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  44. So(err, ShouldBeNil)
  45. So(reader.Path, ShouldEqual, "/var/lib/grafana/dashboards")
  46. So(filepath.IsAbs(reader.Path), ShouldBeTrue)
  47. })
  48. Convey("using relative path", func() {
  49. cfg.Options["folder"] = defaultDashboards
  50. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  51. So(err, ShouldBeNil)
  52. So(filepath.IsAbs(reader.Path), ShouldBeTrue)
  53. })
  54. })
  55. }
  56. func TestDashboardFileReader(t *testing.T) {
  57. Convey("Dashboard file reader", t, func() {
  58. bus.ClearBusHandlers()
  59. origNewDashboardProvisioningService := dashboards.NewProvisioningService
  60. fakeService = mockDashboardProvisioningService()
  61. bus.AddHandler("test", mockGetDashboardQuery)
  62. logger := log.New("test.logger")
  63. Convey("Reading dashboards from disk", func() {
  64. cfg := &DashboardsAsConfig{
  65. Name: "Default",
  66. Type: "file",
  67. OrgId: 1,
  68. Folder: "",
  69. Options: map[string]interface{}{},
  70. }
  71. Convey("Can read default dashboard", func() {
  72. cfg.Options["path"] = defaultDashboards
  73. cfg.Folder = "Team A"
  74. reader, err := NewDashboardFileReader(cfg, logger)
  75. So(err, ShouldBeNil)
  76. err = reader.startWalkingDisk()
  77. So(err, ShouldBeNil)
  78. folders := 0
  79. dashboards := 0
  80. for _, i := range fakeService.inserted {
  81. if i.Dashboard.IsFolder {
  82. folders++
  83. } else {
  84. dashboards++
  85. }
  86. }
  87. So(folders, ShouldEqual, 1)
  88. So(dashboards, ShouldEqual, 2)
  89. })
  90. Convey("Can read default dashboard and replace old version in database", func() {
  91. cfg.Options["path"] = oneDashboard
  92. stat, _ := os.Stat(oneDashboard + "/dashboard1.json")
  93. fakeService.getDashboard = append(fakeService.getDashboard, &models.Dashboard{
  94. Updated: stat.ModTime().AddDate(0, 0, -1),
  95. Slug: "grafana",
  96. })
  97. reader, err := NewDashboardFileReader(cfg, logger)
  98. So(err, ShouldBeNil)
  99. err = reader.startWalkingDisk()
  100. So(err, ShouldBeNil)
  101. So(len(fakeService.inserted), ShouldEqual, 1)
  102. })
  103. Convey("Overrides id from dashboard.json files", func() {
  104. cfg.Options["path"] = containingId
  105. reader, err := NewDashboardFileReader(cfg, logger)
  106. So(err, ShouldBeNil)
  107. err = reader.startWalkingDisk()
  108. So(err, ShouldBeNil)
  109. So(len(fakeService.inserted), ShouldEqual, 1)
  110. })
  111. Convey("Invalid configuration should return error", func() {
  112. cfg := &DashboardsAsConfig{
  113. Name: "Default",
  114. Type: "file",
  115. OrgId: 1,
  116. Folder: "",
  117. }
  118. _, err := NewDashboardFileReader(cfg, logger)
  119. So(err, ShouldNotBeNil)
  120. })
  121. Convey("Broken dashboards should not cause error", func() {
  122. cfg.Options["path"] = brokenDashboards
  123. _, err := NewDashboardFileReader(cfg, logger)
  124. So(err, ShouldBeNil)
  125. })
  126. })
  127. Convey("Should not create new folder if folder name is missing", func() {
  128. cfg := &DashboardsAsConfig{
  129. Name: "Default",
  130. Type: "file",
  131. OrgId: 1,
  132. Folder: "",
  133. Options: map[string]interface{}{
  134. "folder": defaultDashboards,
  135. },
  136. }
  137. _, err := getOrCreateFolderId(cfg, fakeService)
  138. So(err, ShouldEqual, ErrFolderNameMissing)
  139. })
  140. Convey("can get or Create dashboard folder", func() {
  141. cfg := &DashboardsAsConfig{
  142. Name: "Default",
  143. Type: "file",
  144. OrgId: 1,
  145. Folder: "TEAM A",
  146. Options: map[string]interface{}{
  147. "folder": defaultDashboards,
  148. },
  149. }
  150. folderId, err := getOrCreateFolderId(cfg, fakeService)
  151. So(err, ShouldBeNil)
  152. inserted := false
  153. for _, d := range fakeService.inserted {
  154. if d.Dashboard.IsFolder && d.Dashboard.Id == folderId {
  155. inserted = true
  156. }
  157. }
  158. So(len(fakeService.inserted), ShouldEqual, 1)
  159. So(inserted, ShouldBeTrue)
  160. })
  161. Convey("Walking the folder with dashboards", func() {
  162. noFiles := map[string]os.FileInfo{}
  163. Convey("should skip dirs that starts with .", func() {
  164. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: ".folder"}, nil)
  165. So(shouldSkip, ShouldEqual, filepath.SkipDir)
  166. })
  167. Convey("should keep walking if file is not .json", func() {
  168. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: "folder"}, nil)
  169. So(shouldSkip, ShouldBeNil)
  170. })
  171. })
  172. Reset(func() {
  173. dashboards.NewProvisioningService = origNewDashboardProvisioningService
  174. })
  175. })
  176. }
  177. type FakeFileInfo struct {
  178. isDirectory bool
  179. name string
  180. }
  181. func (ffi *FakeFileInfo) IsDir() bool {
  182. return ffi.isDirectory
  183. }
  184. func (ffi FakeFileInfo) Size() int64 {
  185. return 1
  186. }
  187. func (ffi FakeFileInfo) Mode() os.FileMode {
  188. return 0777
  189. }
  190. func (ffi FakeFileInfo) Name() string {
  191. return ffi.name
  192. }
  193. func (ffi FakeFileInfo) ModTime() time.Time {
  194. return time.Time{}
  195. }
  196. func (ffi FakeFileInfo) Sys() interface{} {
  197. return nil
  198. }
  199. func mockDashboardProvisioningService() *fakeDashboardProvisioningService {
  200. mock := fakeDashboardProvisioningService{}
  201. dashboards.NewProvisioningService = func() dashboards.DashboardProvisioningService {
  202. return &mock
  203. }
  204. return &mock
  205. }
  206. type fakeDashboardProvisioningService struct {
  207. inserted []*dashboards.SaveDashboardDTO
  208. provisioned []*models.DashboardProvisioning
  209. getDashboard []*models.Dashboard
  210. }
  211. func (s *fakeDashboardProvisioningService) GetProvisionedDashboardData(name string) ([]*models.DashboardProvisioning, error) {
  212. return s.provisioned, nil
  213. }
  214. func (s *fakeDashboardProvisioningService) SaveProvisionedDashboard(dto *dashboards.SaveDashboardDTO, provisioning *models.DashboardProvisioning) (*models.Dashboard, error) {
  215. s.inserted = append(s.inserted, dto)
  216. s.provisioned = append(s.provisioned, provisioning)
  217. return dto.Dashboard, nil
  218. }
  219. func (s *fakeDashboardProvisioningService) SaveFolderForProvisionedDashboards(dto *dashboards.SaveDashboardDTO) (*models.Dashboard, error) {
  220. s.inserted = append(s.inserted, dto)
  221. return dto.Dashboard, nil
  222. }
  223. func mockGetDashboardQuery(cmd *models.GetDashboardQuery) error {
  224. for _, d := range fakeService.getDashboard {
  225. if d.Slug == cmd.Slug {
  226. cmd.Result = d
  227. return nil
  228. }
  229. }
  230. return models.ErrDashboardNotFound
  231. }