auth_token_test.go 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386
  1. package authtoken
  2. import (
  3. "testing"
  4. "time"
  5. "github.com/grafana/grafana/pkg/setting"
  6. "github.com/grafana/grafana/pkg/log"
  7. "github.com/grafana/grafana/pkg/services/sqlstore"
  8. . "github.com/smartystreets/goconvey/convey"
  9. )
  10. func TestUserAuthToken(t *testing.T) {
  11. Convey("Test user auth token", t, func() {
  12. ctx := createTestContext(t)
  13. userAuthTokenService := ctx.tokenService
  14. userID := int64(10)
  15. t := time.Date(2018, 12, 13, 13, 45, 0, 0, time.UTC)
  16. getTime = func() time.Time {
  17. return t
  18. }
  19. Convey("When creating token", func() {
  20. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  21. So(err, ShouldBeNil)
  22. model, err := extractModelFromToken(userToken)
  23. So(err, ShouldBeNil)
  24. So(model, ShouldNotBeNil)
  25. So(model.AuthTokenSeen, ShouldBeFalse)
  26. Convey("When lookup unhashed token should return user auth token", func() {
  27. userToken, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  28. So(err, ShouldBeNil)
  29. lookedUpModel, err := extractModelFromToken(userToken)
  30. So(err, ShouldBeNil)
  31. So(lookedUpModel, ShouldNotBeNil)
  32. So(lookedUpModel.UserId, ShouldEqual, userID)
  33. So(lookedUpModel.AuthTokenSeen, ShouldBeTrue)
  34. storedAuthToken, err := ctx.getAuthTokenByID(lookedUpModel.Id)
  35. So(err, ShouldBeNil)
  36. So(storedAuthToken, ShouldNotBeNil)
  37. So(storedAuthToken.AuthTokenSeen, ShouldBeTrue)
  38. })
  39. Convey("When lookup hashed token should return user auth token not found error", func() {
  40. userToken, err := userAuthTokenService.LookupToken(model.AuthToken)
  41. So(err, ShouldEqual, ErrAuthTokenNotFound)
  42. So(userToken, ShouldBeNil)
  43. })
  44. Convey("revoking existing token should delete token", func() {
  45. err = userAuthTokenService.RevokeToken(userToken)
  46. So(err, ShouldBeNil)
  47. model, err := ctx.getAuthTokenByID(model.Id)
  48. So(err, ShouldBeNil)
  49. So(model, ShouldBeNil)
  50. })
  51. Convey("revoking nil token should return error", func() {
  52. err = userAuthTokenService.RevokeToken(nil)
  53. So(err, ShouldEqual, ErrAuthTokenNotFound)
  54. })
  55. Convey("revoking non-existing token should return error", func() {
  56. model.Id = 1000
  57. nonExistingToken, err := model.toUserToken()
  58. So(err, ShouldBeNil)
  59. err = userAuthTokenService.RevokeToken(nonExistingToken)
  60. So(err, ShouldEqual, ErrAuthTokenNotFound)
  61. })
  62. })
  63. Convey("expires correctly", func() {
  64. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  65. So(err, ShouldBeNil)
  66. model, err := extractModelFromToken(userToken)
  67. So(err, ShouldBeNil)
  68. So(model, ShouldNotBeNil)
  69. _, err = userAuthTokenService.LookupToken(model.UnhashedToken)
  70. So(err, ShouldBeNil)
  71. model, err = ctx.getAuthTokenByID(model.Id)
  72. So(err, ShouldBeNil)
  73. userToken, err = model.toUserToken()
  74. So(err, ShouldBeNil)
  75. getTime = func() time.Time {
  76. return t.Add(time.Hour)
  77. }
  78. rotated, err := userAuthTokenService.TryRotateToken(userToken, "192.168.10.11:1234", "some user agent")
  79. So(err, ShouldBeNil)
  80. So(rotated, ShouldBeTrue)
  81. _, err = userAuthTokenService.LookupToken(model.UnhashedToken)
  82. So(err, ShouldBeNil)
  83. stillGood, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  84. So(err, ShouldBeNil)
  85. So(stillGood, ShouldNotBeNil)
  86. getTime = func() time.Time {
  87. return t.Add(24 * 7 * time.Hour)
  88. }
  89. notGood, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  90. So(err, ShouldEqual, ErrAuthTokenNotFound)
  91. So(notGood, ShouldBeNil)
  92. })
  93. Convey("can properly rotate tokens", func() {
  94. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  95. So(err, ShouldBeNil)
  96. model, err := extractModelFromToken(userToken)
  97. So(err, ShouldBeNil)
  98. So(model, ShouldNotBeNil)
  99. prevToken := model.AuthToken
  100. unhashedPrev := model.UnhashedToken
  101. rotated, err := userAuthTokenService.TryRotateToken(userToken, "192.168.10.12:1234", "a new user agent")
  102. So(err, ShouldBeNil)
  103. So(rotated, ShouldBeFalse)
  104. updated, err := ctx.markAuthTokenAsSeen(model.Id)
  105. So(err, ShouldBeNil)
  106. So(updated, ShouldBeTrue)
  107. model, err = ctx.getAuthTokenByID(model.Id)
  108. So(err, ShouldBeNil)
  109. tok, err := model.toUserToken()
  110. So(err, ShouldBeNil)
  111. getTime = func() time.Time {
  112. return t.Add(time.Hour)
  113. }
  114. rotated, err = userAuthTokenService.TryRotateToken(tok, "192.168.10.12:1234", "a new user agent")
  115. So(err, ShouldBeNil)
  116. So(rotated, ShouldBeTrue)
  117. unhashedToken := model.UnhashedToken
  118. model, err = ctx.getAuthTokenByID(model.Id)
  119. So(err, ShouldBeNil)
  120. model.UnhashedToken = unhashedToken
  121. So(model.RotatedAt, ShouldEqual, getTime().Unix())
  122. So(model.ClientIp, ShouldEqual, "192.168.10.12")
  123. So(model.UserAgent, ShouldEqual, "a new user agent")
  124. So(model.AuthTokenSeen, ShouldBeFalse)
  125. So(model.SeenAt, ShouldEqual, 0)
  126. So(model.PrevAuthToken, ShouldEqual, prevToken)
  127. // ability to auth using an old token
  128. lookedUpUserToken, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  129. So(err, ShouldBeNil)
  130. lookedUpModel, err := extractModelFromToken(lookedUpUserToken)
  131. So(err, ShouldBeNil)
  132. So(lookedUpModel, ShouldNotBeNil)
  133. So(lookedUpModel.AuthTokenSeen, ShouldBeTrue)
  134. So(lookedUpModel.SeenAt, ShouldEqual, getTime().Unix())
  135. lookedUpUserToken, err = userAuthTokenService.LookupToken(unhashedPrev)
  136. So(err, ShouldBeNil)
  137. So(lookedUpModel, ShouldNotBeNil)
  138. So(lookedUpModel.Id, ShouldEqual, model.Id)
  139. So(lookedUpModel.AuthTokenSeen, ShouldBeTrue)
  140. getTime = func() time.Time {
  141. return t.Add(time.Hour + (2 * time.Minute))
  142. }
  143. lookedUpUserToken, err = userAuthTokenService.LookupToken(unhashedPrev)
  144. So(err, ShouldBeNil)
  145. lookedUpModel, err = extractModelFromToken(lookedUpUserToken)
  146. So(err, ShouldBeNil)
  147. So(lookedUpModel, ShouldNotBeNil)
  148. So(lookedUpModel.AuthTokenSeen, ShouldBeTrue)
  149. lookedUpModel, err = ctx.getAuthTokenByID(lookedUpModel.Id)
  150. So(err, ShouldBeNil)
  151. So(lookedUpModel, ShouldNotBeNil)
  152. So(lookedUpModel.AuthTokenSeen, ShouldBeFalse)
  153. rotated, err = userAuthTokenService.TryRotateToken(userToken, "192.168.10.12:1234", "a new user agent")
  154. So(err, ShouldBeNil)
  155. So(rotated, ShouldBeTrue)
  156. model, err = ctx.getAuthTokenByID(model.Id)
  157. So(err, ShouldBeNil)
  158. So(model, ShouldNotBeNil)
  159. So(model.SeenAt, ShouldEqual, 0)
  160. })
  161. Convey("keeps prev token valid for 1 minute after it is confirmed", func() {
  162. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  163. So(err, ShouldBeNil)
  164. model, err := extractModelFromToken(userToken)
  165. So(err, ShouldBeNil)
  166. So(model, ShouldNotBeNil)
  167. lookedUpUserToken, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  168. So(err, ShouldBeNil)
  169. So(lookedUpUserToken, ShouldNotBeNil)
  170. getTime = func() time.Time {
  171. return t.Add(10 * time.Minute)
  172. }
  173. prevToken := model.UnhashedToken
  174. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  175. So(err, ShouldBeNil)
  176. So(rotated, ShouldBeTrue)
  177. getTime = func() time.Time {
  178. return t.Add(20 * time.Minute)
  179. }
  180. currentUserToken, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  181. So(err, ShouldBeNil)
  182. So(currentUserToken, ShouldNotBeNil)
  183. prevUserToken, err := userAuthTokenService.LookupToken(prevToken)
  184. So(err, ShouldBeNil)
  185. So(prevUserToken, ShouldNotBeNil)
  186. })
  187. Convey("will not mark token unseen when prev and current are the same", func() {
  188. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  189. So(err, ShouldBeNil)
  190. model, err := extractModelFromToken(userToken)
  191. So(err, ShouldBeNil)
  192. So(model, ShouldNotBeNil)
  193. lookedUpUserToken, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  194. So(err, ShouldBeNil)
  195. lookedUpModel, err := extractModelFromToken(lookedUpUserToken)
  196. So(err, ShouldBeNil)
  197. So(lookedUpModel, ShouldNotBeNil)
  198. lookedUpUserToken, err = userAuthTokenService.LookupToken(model.UnhashedToken)
  199. So(err, ShouldBeNil)
  200. lookedUpModel, err = extractModelFromToken(lookedUpUserToken)
  201. So(err, ShouldBeNil)
  202. So(lookedUpModel, ShouldNotBeNil)
  203. lookedUpModel, err = ctx.getAuthTokenByID(lookedUpModel.Id)
  204. So(err, ShouldBeNil)
  205. So(lookedUpModel, ShouldNotBeNil)
  206. So(lookedUpModel.AuthTokenSeen, ShouldBeTrue)
  207. })
  208. Convey("Rotate token", func() {
  209. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  210. So(err, ShouldBeNil)
  211. model, err := extractModelFromToken(userToken)
  212. So(err, ShouldBeNil)
  213. So(model, ShouldNotBeNil)
  214. prevToken := model.AuthToken
  215. Convey("Should rotate current token and previous token when auth token seen", func() {
  216. updated, err := ctx.markAuthTokenAsSeen(model.Id)
  217. So(err, ShouldBeNil)
  218. So(updated, ShouldBeTrue)
  219. getTime = func() time.Time {
  220. return t.Add(10 * time.Minute)
  221. }
  222. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  223. So(err, ShouldBeNil)
  224. So(rotated, ShouldBeTrue)
  225. storedToken, err := ctx.getAuthTokenByID(model.Id)
  226. So(err, ShouldBeNil)
  227. So(storedToken, ShouldNotBeNil)
  228. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  229. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  230. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  231. prevToken = storedToken.AuthToken
  232. updated, err = ctx.markAuthTokenAsSeen(model.Id)
  233. So(err, ShouldBeNil)
  234. So(updated, ShouldBeTrue)
  235. getTime = func() time.Time {
  236. return t.Add(20 * time.Minute)
  237. }
  238. rotated, err = userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  239. So(err, ShouldBeNil)
  240. So(rotated, ShouldBeTrue)
  241. storedToken, err = ctx.getAuthTokenByID(model.Id)
  242. So(err, ShouldBeNil)
  243. So(storedToken, ShouldNotBeNil)
  244. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  245. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  246. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  247. })
  248. Convey("Should rotate current token, but keep previous token when auth token not seen", func() {
  249. model.RotatedAt = getTime().Add(-2 * time.Minute).Unix()
  250. getTime = func() time.Time {
  251. return t.Add(2 * time.Minute)
  252. }
  253. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  254. So(err, ShouldBeNil)
  255. So(rotated, ShouldBeTrue)
  256. storedToken, err := ctx.getAuthTokenByID(model.Id)
  257. So(err, ShouldBeNil)
  258. So(storedToken, ShouldNotBeNil)
  259. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  260. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  261. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  262. })
  263. })
  264. Reset(func() {
  265. getTime = time.Now
  266. })
  267. })
  268. }
  269. func createTestContext(t *testing.T) *testContext {
  270. t.Helper()
  271. sqlstore := sqlstore.InitTestDB(t)
  272. tokenService := &UserAuthTokenServiceImpl{
  273. SQLStore: sqlstore,
  274. Cfg: &setting.Cfg{
  275. LoginCookieName: "grafana_session",
  276. LoginCookieMaxDays: 7,
  277. LoginDeleteExpiredTokensAfterDays: 30,
  278. LoginCookieRotation: 10,
  279. },
  280. log: log.New("test-logger"),
  281. }
  282. return &testContext{
  283. sqlstore: sqlstore,
  284. tokenService: tokenService,
  285. }
  286. }
  287. type testContext struct {
  288. sqlstore *sqlstore.SqlStore
  289. tokenService *UserAuthTokenServiceImpl
  290. }
  291. func (c *testContext) getAuthTokenByID(id int64) (*userAuthToken, error) {
  292. sess := c.sqlstore.NewSession()
  293. var t userAuthToken
  294. found, err := sess.ID(id).Get(&t)
  295. if err != nil || !found {
  296. return nil, err
  297. }
  298. return &t, nil
  299. }
  300. func (c *testContext) markAuthTokenAsSeen(id int64) (bool, error) {
  301. sess := c.sqlstore.NewSession()
  302. res, err := sess.Exec("UPDATE user_auth_token SET auth_token_seen = ? WHERE id = ?", c.sqlstore.Dialect.BooleanStr(true), id)
  303. if err != nil {
  304. return false, err
  305. }
  306. rowsAffected, err := res.RowsAffected()
  307. if err != nil {
  308. return false, err
  309. }
  310. return rowsAffected == 1, nil
  311. }