file_reader_test.go 7.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292
  1. package dashboards
  2. import (
  3. "os"
  4. "path/filepath"
  5. "runtime"
  6. "testing"
  7. "time"
  8. "github.com/grafana/grafana/pkg/bus"
  9. "github.com/grafana/grafana/pkg/models"
  10. "github.com/grafana/grafana/pkg/services/dashboards"
  11. "github.com/grafana/grafana/pkg/log"
  12. . "github.com/smartystreets/goconvey/convey"
  13. )
  14. var (
  15. defaultDashboards = "testdata/test-dashboards/folder-one"
  16. brokenDashboards = "testdata/test-dashboards/broken-dashboards"
  17. oneDashboard = "testdata/test-dashboards/one-dashboard"
  18. containingId = "testdata/test-dashboards/containing-id"
  19. fakeService *fakeDashboardProvisioningService
  20. )
  21. func TestCreatingNewDashboardFileReader(t *testing.T) {
  22. Convey("creating new dashboard file reader", t, func() {
  23. cfg := &DashboardsAsConfig{
  24. Name: "Default",
  25. Type: "file",
  26. OrgId: 1,
  27. Folder: "",
  28. Options: map[string]interface{}{},
  29. }
  30. Convey("using path parameter", func() {
  31. cfg.Options["path"] = defaultDashboards
  32. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  33. So(err, ShouldBeNil)
  34. So(reader.Path, ShouldNotEqual, "")
  35. })
  36. Convey("using folder as options", func() {
  37. cfg.Options["folder"] = defaultDashboards
  38. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  39. So(err, ShouldBeNil)
  40. So(reader.Path, ShouldNotEqual, "")
  41. })
  42. Convey("using full path", func() {
  43. cfg.Options["folder"] = "/var/lib/grafana/dashboards"
  44. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  45. So(err, ShouldBeNil)
  46. if runtime.GOOS != "windows" {
  47. So(reader.Path, ShouldEqual, "/var/lib/grafana/dashboards")
  48. }
  49. So(filepath.IsAbs(reader.Path), ShouldBeTrue)
  50. })
  51. Convey("using relative path", func() {
  52. cfg.Options["folder"] = defaultDashboards
  53. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  54. So(err, ShouldBeNil)
  55. So(filepath.IsAbs(reader.Path), ShouldBeTrue)
  56. })
  57. })
  58. }
  59. func TestDashboardFileReader(t *testing.T) {
  60. Convey("Dashboard file reader", t, func() {
  61. bus.ClearBusHandlers()
  62. origNewDashboardProvisioningService := dashboards.NewProvisioningService
  63. fakeService = mockDashboardProvisioningService()
  64. bus.AddHandler("test", mockGetDashboardQuery)
  65. logger := log.New("test.logger")
  66. Convey("Reading dashboards from disk", func() {
  67. cfg := &DashboardsAsConfig{
  68. Name: "Default",
  69. Type: "file",
  70. OrgId: 1,
  71. Folder: "",
  72. Options: map[string]interface{}{},
  73. }
  74. Convey("Can read default dashboard", func() {
  75. cfg.Options["path"] = defaultDashboards
  76. cfg.Folder = "Team A"
  77. reader, err := NewDashboardFileReader(cfg, logger)
  78. So(err, ShouldBeNil)
  79. err = reader.startWalkingDisk()
  80. So(err, ShouldBeNil)
  81. folders := 0
  82. dashboards := 0
  83. for _, i := range fakeService.inserted {
  84. if i.Dashboard.IsFolder {
  85. folders++
  86. } else {
  87. dashboards++
  88. }
  89. }
  90. So(folders, ShouldEqual, 1)
  91. So(dashboards, ShouldEqual, 2)
  92. })
  93. Convey("Can read default dashboard and replace old version in database", func() {
  94. cfg.Options["path"] = oneDashboard
  95. stat, _ := os.Stat(oneDashboard + "/dashboard1.json")
  96. fakeService.getDashboard = append(fakeService.getDashboard, &models.Dashboard{
  97. Updated: stat.ModTime().AddDate(0, 0, -1),
  98. Slug: "grafana",
  99. })
  100. reader, err := NewDashboardFileReader(cfg, logger)
  101. So(err, ShouldBeNil)
  102. err = reader.startWalkingDisk()
  103. So(err, ShouldBeNil)
  104. So(len(fakeService.inserted), ShouldEqual, 1)
  105. })
  106. Convey("Overrides id from dashboard.json files", func() {
  107. cfg.Options["path"] = containingId
  108. reader, err := NewDashboardFileReader(cfg, logger)
  109. So(err, ShouldBeNil)
  110. err = reader.startWalkingDisk()
  111. So(err, ShouldBeNil)
  112. So(len(fakeService.inserted), ShouldEqual, 1)
  113. })
  114. Convey("Invalid configuration should return error", func() {
  115. cfg := &DashboardsAsConfig{
  116. Name: "Default",
  117. Type: "file",
  118. OrgId: 1,
  119. Folder: "",
  120. }
  121. _, err := NewDashboardFileReader(cfg, logger)
  122. So(err, ShouldNotBeNil)
  123. })
  124. Convey("Broken dashboards should not cause error", func() {
  125. cfg.Options["path"] = brokenDashboards
  126. _, err := NewDashboardFileReader(cfg, logger)
  127. So(err, ShouldBeNil)
  128. })
  129. })
  130. Convey("Should not create new folder if folder name is missing", func() {
  131. cfg := &DashboardsAsConfig{
  132. Name: "Default",
  133. Type: "file",
  134. OrgId: 1,
  135. Folder: "",
  136. Options: map[string]interface{}{
  137. "folder": defaultDashboards,
  138. },
  139. }
  140. _, err := getOrCreateFolderId(cfg, fakeService)
  141. So(err, ShouldEqual, ErrFolderNameMissing)
  142. })
  143. Convey("can get or Create dashboard folder", func() {
  144. cfg := &DashboardsAsConfig{
  145. Name: "Default",
  146. Type: "file",
  147. OrgId: 1,
  148. Folder: "TEAM A",
  149. Options: map[string]interface{}{
  150. "folder": defaultDashboards,
  151. },
  152. }
  153. folderId, err := getOrCreateFolderId(cfg, fakeService)
  154. So(err, ShouldBeNil)
  155. inserted := false
  156. for _, d := range fakeService.inserted {
  157. if d.Dashboard.IsFolder && d.Dashboard.Id == folderId {
  158. inserted = true
  159. }
  160. }
  161. So(len(fakeService.inserted), ShouldEqual, 1)
  162. So(inserted, ShouldBeTrue)
  163. })
  164. Convey("Walking the folder with dashboards", func() {
  165. noFiles := map[string]os.FileInfo{}
  166. Convey("should skip dirs that starts with .", func() {
  167. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: ".folder"}, nil)
  168. So(shouldSkip, ShouldEqual, filepath.SkipDir)
  169. })
  170. Convey("should keep walking if file is not .json", func() {
  171. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: "folder"}, nil)
  172. So(shouldSkip, ShouldBeNil)
  173. })
  174. })
  175. Reset(func() {
  176. dashboards.NewProvisioningService = origNewDashboardProvisioningService
  177. })
  178. })
  179. }
  180. type FakeFileInfo struct {
  181. isDirectory bool
  182. name string
  183. }
  184. func (ffi *FakeFileInfo) IsDir() bool {
  185. return ffi.isDirectory
  186. }
  187. func (ffi FakeFileInfo) Size() int64 {
  188. return 1
  189. }
  190. func (ffi FakeFileInfo) Mode() os.FileMode {
  191. return 0777
  192. }
  193. func (ffi FakeFileInfo) Name() string {
  194. return ffi.name
  195. }
  196. func (ffi FakeFileInfo) ModTime() time.Time {
  197. return time.Time{}
  198. }
  199. func (ffi FakeFileInfo) Sys() interface{} {
  200. return nil
  201. }
  202. func mockDashboardProvisioningService() *fakeDashboardProvisioningService {
  203. mock := fakeDashboardProvisioningService{}
  204. dashboards.NewProvisioningService = func() dashboards.DashboardProvisioningService {
  205. return &mock
  206. }
  207. return &mock
  208. }
  209. type fakeDashboardProvisioningService struct {
  210. inserted []*dashboards.SaveDashboardDTO
  211. provisioned []*models.DashboardProvisioning
  212. getDashboard []*models.Dashboard
  213. }
  214. func (s *fakeDashboardProvisioningService) GetProvisionedDashboardData(name string) ([]*models.DashboardProvisioning, error) {
  215. return s.provisioned, nil
  216. }
  217. func (s *fakeDashboardProvisioningService) SaveProvisionedDashboard(dto *dashboards.SaveDashboardDTO, provisioning *models.DashboardProvisioning) (*models.Dashboard, error) {
  218. s.inserted = append(s.inserted, dto)
  219. s.provisioned = append(s.provisioned, provisioning)
  220. return dto.Dashboard, nil
  221. }
  222. func (s *fakeDashboardProvisioningService) SaveFolderForProvisionedDashboards(dto *dashboards.SaveDashboardDTO) (*models.Dashboard, error) {
  223. s.inserted = append(s.inserted, dto)
  224. return dto.Dashboard, nil
  225. }
  226. func mockGetDashboardQuery(cmd *models.GetDashboardQuery) error {
  227. for _, d := range fakeService.getDashboard {
  228. if d.Slug == cmd.Slug {
  229. cmd.Result = d
  230. return nil
  231. }
  232. }
  233. return models.ErrDashboardNotFound
  234. }