auth_token_test.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493
  1. package auth
  2. import (
  3. "encoding/json"
  4. "testing"
  5. "time"
  6. "github.com/grafana/grafana/pkg/components/simplejson"
  7. "github.com/grafana/grafana/pkg/setting"
  8. "github.com/grafana/grafana/pkg/log"
  9. "github.com/grafana/grafana/pkg/models"
  10. "github.com/grafana/grafana/pkg/services/sqlstore"
  11. . "github.com/smartystreets/goconvey/convey"
  12. )
  13. func TestUserAuthToken(t *testing.T) {
  14. Convey("Test user auth token", t, func() {
  15. ctx := createTestContext(t)
  16. userAuthTokenService := ctx.tokenService
  17. userID := int64(10)
  18. t := time.Date(2018, 12, 13, 13, 45, 0, 0, time.UTC)
  19. getTime = func() time.Time {
  20. return t
  21. }
  22. Convey("When creating token", func() {
  23. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  24. So(err, ShouldBeNil)
  25. So(userToken, ShouldNotBeNil)
  26. So(userToken.AuthTokenSeen, ShouldBeFalse)
  27. Convey("Can count active tokens", func() {
  28. count, err := userAuthTokenService.ActiveTokenCount()
  29. So(err, ShouldBeNil)
  30. So(count, ShouldEqual, 1)
  31. })
  32. Convey("When lookup unhashed token should return user auth token", func() {
  33. userToken, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  34. So(err, ShouldBeNil)
  35. So(userToken, ShouldNotBeNil)
  36. So(userToken.UserId, ShouldEqual, userID)
  37. So(userToken.AuthTokenSeen, ShouldBeTrue)
  38. storedAuthToken, err := ctx.getAuthTokenByID(userToken.Id)
  39. So(err, ShouldBeNil)
  40. So(storedAuthToken, ShouldNotBeNil)
  41. So(storedAuthToken.AuthTokenSeen, ShouldBeTrue)
  42. })
  43. Convey("When lookup hashed token should return user auth token not found error", func() {
  44. userToken, err := userAuthTokenService.LookupToken(userToken.AuthToken)
  45. So(err, ShouldEqual, models.ErrUserTokenNotFound)
  46. So(userToken, ShouldBeNil)
  47. })
  48. Convey("revoking existing token should delete token", func() {
  49. err = userAuthTokenService.RevokeToken(userToken)
  50. So(err, ShouldBeNil)
  51. model, err := ctx.getAuthTokenByID(userToken.Id)
  52. So(err, ShouldBeNil)
  53. So(model, ShouldBeNil)
  54. })
  55. Convey("revoking nil token should return error", func() {
  56. err = userAuthTokenService.RevokeToken(nil)
  57. So(err, ShouldEqual, models.ErrUserTokenNotFound)
  58. })
  59. Convey("revoking non-existing token should return error", func() {
  60. userToken.Id = 1000
  61. err = userAuthTokenService.RevokeToken(userToken)
  62. So(err, ShouldEqual, models.ErrUserTokenNotFound)
  63. })
  64. })
  65. Convey("expires correctly", func() {
  66. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  67. So(err, ShouldBeNil)
  68. userToken, err = userAuthTokenService.LookupToken(userToken.UnhashedToken)
  69. So(err, ShouldBeNil)
  70. getTime = func() time.Time {
  71. return t.Add(time.Hour)
  72. }
  73. rotated, err := userAuthTokenService.TryRotateToken(userToken, "192.168.10.11:1234", "some user agent")
  74. So(err, ShouldBeNil)
  75. So(rotated, ShouldBeTrue)
  76. userToken, err = userAuthTokenService.LookupToken(userToken.UnhashedToken)
  77. So(err, ShouldBeNil)
  78. stillGood, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  79. So(err, ShouldBeNil)
  80. So(stillGood, ShouldNotBeNil)
  81. model, err := ctx.getAuthTokenByID(userToken.Id)
  82. So(err, ShouldBeNil)
  83. Convey("when rotated_at is 6:59:59 ago should find token", func() {
  84. getTime = func() time.Time {
  85. return time.Unix(model.RotatedAt, 0).Add(24 * 7 * time.Hour).Add(-time.Second)
  86. }
  87. stillGood, err = userAuthTokenService.LookupToken(stillGood.UnhashedToken)
  88. So(err, ShouldBeNil)
  89. So(stillGood, ShouldNotBeNil)
  90. })
  91. Convey("when rotated_at is 7:00:00 ago should not find token", func() {
  92. getTime = func() time.Time {
  93. return time.Unix(model.RotatedAt, 0).Add(24 * 7 * time.Hour)
  94. }
  95. notGood, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  96. So(err, ShouldEqual, models.ErrUserTokenNotFound)
  97. So(notGood, ShouldBeNil)
  98. Convey("should not find active token when expired", func() {
  99. count, err := userAuthTokenService.ActiveTokenCount()
  100. So(err, ShouldBeNil)
  101. So(count, ShouldEqual, 0)
  102. })
  103. })
  104. Convey("when rotated_at is 5 days ago and created_at is 29 days and 23:59:59 ago should not find token", func() {
  105. updated, err := ctx.updateRotatedAt(model.Id, time.Unix(model.CreatedAt, 0).Add(24*25*time.Hour).Unix())
  106. So(err, ShouldBeNil)
  107. So(updated, ShouldBeTrue)
  108. getTime = func() time.Time {
  109. return time.Unix(model.CreatedAt, 0).Add(24 * 30 * time.Hour).Add(-time.Second)
  110. }
  111. stillGood, err = userAuthTokenService.LookupToken(stillGood.UnhashedToken)
  112. So(err, ShouldBeNil)
  113. So(stillGood, ShouldNotBeNil)
  114. })
  115. Convey("when rotated_at is 5 days ago and created_at is 30 days ago should not find token", func() {
  116. updated, err := ctx.updateRotatedAt(model.Id, time.Unix(model.CreatedAt, 0).Add(24*25*time.Hour).Unix())
  117. So(err, ShouldBeNil)
  118. So(updated, ShouldBeTrue)
  119. getTime = func() time.Time {
  120. return time.Unix(model.CreatedAt, 0).Add(24 * 30 * time.Hour)
  121. }
  122. notGood, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  123. So(err, ShouldEqual, models.ErrUserTokenNotFound)
  124. So(notGood, ShouldBeNil)
  125. })
  126. })
  127. Convey("can properly rotate tokens", func() {
  128. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  129. So(err, ShouldBeNil)
  130. prevToken := userToken.AuthToken
  131. unhashedPrev := userToken.UnhashedToken
  132. rotated, err := userAuthTokenService.TryRotateToken(userToken, "192.168.10.12:1234", "a new user agent")
  133. So(err, ShouldBeNil)
  134. So(rotated, ShouldBeFalse)
  135. updated, err := ctx.markAuthTokenAsSeen(userToken.Id)
  136. So(err, ShouldBeNil)
  137. So(updated, ShouldBeTrue)
  138. model, err := ctx.getAuthTokenByID(userToken.Id)
  139. So(err, ShouldBeNil)
  140. var tok models.UserToken
  141. err = model.toUserToken(&tok)
  142. So(err, ShouldBeNil)
  143. getTime = func() time.Time {
  144. return t.Add(time.Hour)
  145. }
  146. rotated, err = userAuthTokenService.TryRotateToken(&tok, "192.168.10.12:1234", "a new user agent")
  147. So(err, ShouldBeNil)
  148. So(rotated, ShouldBeTrue)
  149. unhashedToken := tok.UnhashedToken
  150. model, err = ctx.getAuthTokenByID(tok.Id)
  151. So(err, ShouldBeNil)
  152. model.UnhashedToken = unhashedToken
  153. So(model.RotatedAt, ShouldEqual, getTime().Unix())
  154. So(model.ClientIp, ShouldEqual, "192.168.10.12")
  155. So(model.UserAgent, ShouldEqual, "a new user agent")
  156. So(model.AuthTokenSeen, ShouldBeFalse)
  157. So(model.SeenAt, ShouldEqual, 0)
  158. So(model.PrevAuthToken, ShouldEqual, prevToken)
  159. // ability to auth using an old token
  160. lookedUpUserToken, err := userAuthTokenService.LookupToken(model.UnhashedToken)
  161. So(err, ShouldBeNil)
  162. So(lookedUpUserToken, ShouldNotBeNil)
  163. So(lookedUpUserToken.AuthTokenSeen, ShouldBeTrue)
  164. So(lookedUpUserToken.SeenAt, ShouldEqual, getTime().Unix())
  165. lookedUpUserToken, err = userAuthTokenService.LookupToken(unhashedPrev)
  166. So(err, ShouldBeNil)
  167. So(lookedUpUserToken, ShouldNotBeNil)
  168. So(lookedUpUserToken.Id, ShouldEqual, model.Id)
  169. So(lookedUpUserToken.AuthTokenSeen, ShouldBeTrue)
  170. getTime = func() time.Time {
  171. return t.Add(time.Hour + (2 * time.Minute))
  172. }
  173. lookedUpUserToken, err = userAuthTokenService.LookupToken(unhashedPrev)
  174. So(err, ShouldBeNil)
  175. So(lookedUpUserToken, ShouldNotBeNil)
  176. So(lookedUpUserToken.AuthTokenSeen, ShouldBeTrue)
  177. lookedUpModel, err := ctx.getAuthTokenByID(lookedUpUserToken.Id)
  178. So(err, ShouldBeNil)
  179. So(lookedUpModel, ShouldNotBeNil)
  180. So(lookedUpModel.AuthTokenSeen, ShouldBeFalse)
  181. rotated, err = userAuthTokenService.TryRotateToken(userToken, "192.168.10.12:1234", "a new user agent")
  182. So(err, ShouldBeNil)
  183. So(rotated, ShouldBeTrue)
  184. model, err = ctx.getAuthTokenByID(userToken.Id)
  185. So(err, ShouldBeNil)
  186. So(model, ShouldNotBeNil)
  187. So(model.SeenAt, ShouldEqual, 0)
  188. })
  189. Convey("keeps prev token valid for 1 minute after it is confirmed", func() {
  190. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  191. So(err, ShouldBeNil)
  192. So(userToken, ShouldNotBeNil)
  193. lookedUpUserToken, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  194. So(err, ShouldBeNil)
  195. So(lookedUpUserToken, ShouldNotBeNil)
  196. getTime = func() time.Time {
  197. return t.Add(10 * time.Minute)
  198. }
  199. prevToken := userToken.UnhashedToken
  200. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  201. So(err, ShouldBeNil)
  202. So(rotated, ShouldBeTrue)
  203. getTime = func() time.Time {
  204. return t.Add(20 * time.Minute)
  205. }
  206. currentUserToken, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  207. So(err, ShouldBeNil)
  208. So(currentUserToken, ShouldNotBeNil)
  209. prevUserToken, err := userAuthTokenService.LookupToken(prevToken)
  210. So(err, ShouldBeNil)
  211. So(prevUserToken, ShouldNotBeNil)
  212. })
  213. Convey("will not mark token unseen when prev and current are the same", func() {
  214. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  215. So(err, ShouldBeNil)
  216. So(userToken, ShouldNotBeNil)
  217. lookedUpUserToken, err := userAuthTokenService.LookupToken(userToken.UnhashedToken)
  218. So(err, ShouldBeNil)
  219. So(lookedUpUserToken, ShouldNotBeNil)
  220. lookedUpUserToken, err = userAuthTokenService.LookupToken(userToken.UnhashedToken)
  221. So(err, ShouldBeNil)
  222. So(lookedUpUserToken, ShouldNotBeNil)
  223. lookedUpModel, err := ctx.getAuthTokenByID(lookedUpUserToken.Id)
  224. So(err, ShouldBeNil)
  225. So(lookedUpModel, ShouldNotBeNil)
  226. So(lookedUpModel.AuthTokenSeen, ShouldBeTrue)
  227. })
  228. Convey("Rotate token", func() {
  229. userToken, err := userAuthTokenService.CreateToken(userID, "192.168.10.11:1234", "some user agent")
  230. So(err, ShouldBeNil)
  231. So(userToken, ShouldNotBeNil)
  232. prevToken := userToken.AuthToken
  233. Convey("Should rotate current token and previous token when auth token seen", func() {
  234. updated, err := ctx.markAuthTokenAsSeen(userToken.Id)
  235. So(err, ShouldBeNil)
  236. So(updated, ShouldBeTrue)
  237. getTime = func() time.Time {
  238. return t.Add(10 * time.Minute)
  239. }
  240. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  241. So(err, ShouldBeNil)
  242. So(rotated, ShouldBeTrue)
  243. storedToken, err := ctx.getAuthTokenByID(userToken.Id)
  244. So(err, ShouldBeNil)
  245. So(storedToken, ShouldNotBeNil)
  246. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  247. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  248. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  249. prevToken = storedToken.AuthToken
  250. updated, err = ctx.markAuthTokenAsSeen(userToken.Id)
  251. So(err, ShouldBeNil)
  252. So(updated, ShouldBeTrue)
  253. getTime = func() time.Time {
  254. return t.Add(20 * time.Minute)
  255. }
  256. rotated, err = userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  257. So(err, ShouldBeNil)
  258. So(rotated, ShouldBeTrue)
  259. storedToken, err = ctx.getAuthTokenByID(userToken.Id)
  260. So(err, ShouldBeNil)
  261. So(storedToken, ShouldNotBeNil)
  262. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  263. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  264. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  265. })
  266. Convey("Should rotate current token, but keep previous token when auth token not seen", func() {
  267. userToken.RotatedAt = getTime().Add(-2 * time.Minute).Unix()
  268. getTime = func() time.Time {
  269. return t.Add(2 * time.Minute)
  270. }
  271. rotated, err := userAuthTokenService.TryRotateToken(userToken, "1.1.1.1", "firefox")
  272. So(err, ShouldBeNil)
  273. So(rotated, ShouldBeTrue)
  274. storedToken, err := ctx.getAuthTokenByID(userToken.Id)
  275. So(err, ShouldBeNil)
  276. So(storedToken, ShouldNotBeNil)
  277. So(storedToken.AuthTokenSeen, ShouldBeFalse)
  278. So(storedToken.PrevAuthToken, ShouldEqual, prevToken)
  279. So(storedToken.AuthToken, ShouldNotEqual, prevToken)
  280. })
  281. })
  282. Convey("When populating userAuthToken from UserToken should copy all properties", func() {
  283. ut := models.UserToken{
  284. Id: 1,
  285. UserId: 2,
  286. AuthToken: "a",
  287. PrevAuthToken: "b",
  288. UserAgent: "c",
  289. ClientIp: "d",
  290. AuthTokenSeen: true,
  291. SeenAt: 3,
  292. RotatedAt: 4,
  293. CreatedAt: 5,
  294. UpdatedAt: 6,
  295. UnhashedToken: "e",
  296. }
  297. utBytes, err := json.Marshal(ut)
  298. So(err, ShouldBeNil)
  299. utJSON, err := simplejson.NewJson(utBytes)
  300. So(err, ShouldBeNil)
  301. utMap := utJSON.MustMap()
  302. var uat userAuthToken
  303. uat.fromUserToken(&ut)
  304. uatBytes, err := json.Marshal(uat)
  305. So(err, ShouldBeNil)
  306. uatJSON, err := simplejson.NewJson(uatBytes)
  307. So(err, ShouldBeNil)
  308. uatMap := uatJSON.MustMap()
  309. So(uatMap, ShouldResemble, utMap)
  310. })
  311. Convey("When populating userToken from userAuthToken should copy all properties", func() {
  312. uat := userAuthToken{
  313. Id: 1,
  314. UserId: 2,
  315. AuthToken: "a",
  316. PrevAuthToken: "b",
  317. UserAgent: "c",
  318. ClientIp: "d",
  319. AuthTokenSeen: true,
  320. SeenAt: 3,
  321. RotatedAt: 4,
  322. CreatedAt: 5,
  323. UpdatedAt: 6,
  324. UnhashedToken: "e",
  325. }
  326. uatBytes, err := json.Marshal(uat)
  327. So(err, ShouldBeNil)
  328. uatJSON, err := simplejson.NewJson(uatBytes)
  329. So(err, ShouldBeNil)
  330. uatMap := uatJSON.MustMap()
  331. var ut models.UserToken
  332. err = uat.toUserToken(&ut)
  333. So(err, ShouldBeNil)
  334. utBytes, err := json.Marshal(ut)
  335. So(err, ShouldBeNil)
  336. utJSON, err := simplejson.NewJson(utBytes)
  337. So(err, ShouldBeNil)
  338. utMap := utJSON.MustMap()
  339. So(utMap, ShouldResemble, uatMap)
  340. })
  341. Reset(func() {
  342. getTime = time.Now
  343. })
  344. })
  345. }
  346. func createTestContext(t *testing.T) *testContext {
  347. t.Helper()
  348. sqlstore := sqlstore.InitTestDB(t)
  349. tokenService := &UserAuthTokenService{
  350. SQLStore: sqlstore,
  351. Cfg: &setting.Cfg{
  352. LoginMaxInactiveLifetimeDays: 7,
  353. LoginMaxLifetimeDays: 30,
  354. TokenRotationIntervalMinutes: 10,
  355. },
  356. log: log.New("test-logger"),
  357. }
  358. return &testContext{
  359. sqlstore: sqlstore,
  360. tokenService: tokenService,
  361. }
  362. }
  363. type testContext struct {
  364. sqlstore *sqlstore.SqlStore
  365. tokenService *UserAuthTokenService
  366. }
  367. func (c *testContext) getAuthTokenByID(id int64) (*userAuthToken, error) {
  368. sess := c.sqlstore.NewSession()
  369. var t userAuthToken
  370. found, err := sess.ID(id).Get(&t)
  371. if err != nil || !found {
  372. return nil, err
  373. }
  374. return &t, nil
  375. }
  376. func (c *testContext) markAuthTokenAsSeen(id int64) (bool, error) {
  377. sess := c.sqlstore.NewSession()
  378. res, err := sess.Exec("UPDATE user_auth_token SET auth_token_seen = ? WHERE id = ?", c.sqlstore.Dialect.BooleanStr(true), id)
  379. if err != nil {
  380. return false, err
  381. }
  382. rowsAffected, err := res.RowsAffected()
  383. if err != nil {
  384. return false, err
  385. }
  386. return rowsAffected == 1, nil
  387. }
  388. func (c *testContext) updateRotatedAt(id, rotatedAt int64) (bool, error) {
  389. sess := c.sqlstore.NewSession()
  390. res, err := sess.Exec("UPDATE user_auth_token SET rotated_at = ? WHERE id = ?", rotatedAt, id)
  391. if err != nil {
  392. return false, err
  393. }
  394. rowsAffected, err := res.RowsAffected()
  395. if err != nil {
  396. return false, err
  397. }
  398. return rowsAffected == 1, nil
  399. }