folder_test.go 7.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241
  1. package api
  2. import (
  3. "encoding/json"
  4. "fmt"
  5. "testing"
  6. "github.com/grafana/grafana/pkg/api/dtos"
  7. "github.com/grafana/grafana/pkg/bus"
  8. m "github.com/grafana/grafana/pkg/models"
  9. "github.com/grafana/grafana/pkg/services/dashboards"
  10. . "github.com/smartystreets/goconvey/convey"
  11. )
  12. func TestFoldersApiEndpoint(t *testing.T) {
  13. Convey("Create/update folder response tests", t, func() {
  14. Convey("Given a correct request for creating a folder", func() {
  15. cmd := m.CreateFolderCommand{
  16. Uid: "uid",
  17. Title: "Folder",
  18. }
  19. mock := &fakeFolderService{
  20. CreateFolderResult: &m.Folder{Id: 1, Uid: "uid", Title: "Folder"},
  21. }
  22. createFolderScenario("When calling POST on", "/api/folders", "/api/folders", mock, cmd, func(sc *scenarioContext) {
  23. callCreateFolder(sc)
  24. Convey("It should return correct response data", func() {
  25. folder := dtos.Folder{}
  26. err := json.NewDecoder(sc.resp.Body).Decode(&folder)
  27. So(err, ShouldBeNil)
  28. So(folder.Id, ShouldEqual, 1)
  29. So(folder.Uid, ShouldEqual, "uid")
  30. So(folder.Title, ShouldEqual, "Folder")
  31. })
  32. })
  33. })
  34. Convey("Given incorrect requests for creating a folder", func() {
  35. testCases := []struct {
  36. Error error
  37. ExpectedStatusCode int
  38. }{
  39. {Error: m.ErrFolderWithSameUIDExists, ExpectedStatusCode: 400},
  40. {Error: m.ErrFolderTitleEmpty, ExpectedStatusCode: 400},
  41. {Error: m.ErrFolderSameNameExists, ExpectedStatusCode: 400},
  42. {Error: m.ErrDashboardInvalidUid, ExpectedStatusCode: 400},
  43. {Error: m.ErrDashboardUidToLong, ExpectedStatusCode: 400},
  44. {Error: m.ErrFolderAccessDenied, ExpectedStatusCode: 403},
  45. {Error: m.ErrFolderNotFound, ExpectedStatusCode: 404},
  46. {Error: m.ErrFolderVersionMismatch, ExpectedStatusCode: 412},
  47. {Error: m.ErrFolderFailedGenerateUniqueUid, ExpectedStatusCode: 500},
  48. }
  49. cmd := m.CreateFolderCommand{
  50. Uid: "uid",
  51. Title: "Folder",
  52. }
  53. for _, tc := range testCases {
  54. mock := &fakeFolderService{
  55. CreateFolderError: tc.Error,
  56. }
  57. createFolderScenario(fmt.Sprintf("Expect '%s' error when calling POST on", tc.Error.Error()), "/api/folders", "/api/folders", mock, cmd, func(sc *scenarioContext) {
  58. callCreateFolder(sc)
  59. if sc.resp.Code != tc.ExpectedStatusCode {
  60. t.Errorf("For error '%s' expected status code %d, actual %d", tc.Error, tc.ExpectedStatusCode, sc.resp.Code)
  61. }
  62. })
  63. }
  64. })
  65. Convey("Given a correct request for updating a folder", func() {
  66. cmd := m.UpdateFolderCommand{
  67. Title: "Folder upd",
  68. }
  69. mock := &fakeFolderService{
  70. UpdateFolderResult: &m.Folder{Id: 1, Uid: "uid", Title: "Folder upd"},
  71. }
  72. updateFolderScenario("When calling PUT on", "/api/folders/uid", "/api/folders/:uid", mock, cmd, func(sc *scenarioContext) {
  73. callUpdateFolder(sc)
  74. Convey("It should return correct response data", func() {
  75. folder := dtos.Folder{}
  76. err := json.NewDecoder(sc.resp.Body).Decode(&folder)
  77. So(err, ShouldBeNil)
  78. So(folder.Id, ShouldEqual, 1)
  79. So(folder.Uid, ShouldEqual, "uid")
  80. So(folder.Title, ShouldEqual, "Folder upd")
  81. })
  82. })
  83. })
  84. Convey("Given incorrect requests for updating a folder", func() {
  85. testCases := []struct {
  86. Error error
  87. ExpectedStatusCode int
  88. }{
  89. {Error: m.ErrFolderWithSameUIDExists, ExpectedStatusCode: 400},
  90. {Error: m.ErrFolderTitleEmpty, ExpectedStatusCode: 400},
  91. {Error: m.ErrFolderSameNameExists, ExpectedStatusCode: 400},
  92. {Error: m.ErrDashboardInvalidUid, ExpectedStatusCode: 400},
  93. {Error: m.ErrDashboardUidToLong, ExpectedStatusCode: 400},
  94. {Error: m.ErrFolderAccessDenied, ExpectedStatusCode: 403},
  95. {Error: m.ErrFolderNotFound, ExpectedStatusCode: 404},
  96. {Error: m.ErrFolderVersionMismatch, ExpectedStatusCode: 412},
  97. {Error: m.ErrFolderFailedGenerateUniqueUid, ExpectedStatusCode: 500},
  98. }
  99. cmd := m.UpdateFolderCommand{
  100. Title: "Folder upd",
  101. }
  102. for _, tc := range testCases {
  103. mock := &fakeFolderService{
  104. UpdateFolderError: tc.Error,
  105. }
  106. updateFolderScenario(fmt.Sprintf("Expect '%s' error when calling PUT on", tc.Error.Error()), "/api/folders/uid", "/api/folders/:uid", mock, cmd, func(sc *scenarioContext) {
  107. callUpdateFolder(sc)
  108. if sc.resp.Code != tc.ExpectedStatusCode {
  109. t.Errorf("For error '%s' expected status code %d, actual %d", tc.Error, tc.ExpectedStatusCode, sc.resp.Code)
  110. }
  111. })
  112. }
  113. })
  114. })
  115. }
  116. func callCreateFolder(sc *scenarioContext) {
  117. sc.fakeReqWithParams("POST", sc.url, map[string]string{}).exec()
  118. }
  119. func createFolderScenario(desc string, url string, routePattern string, mock *fakeFolderService, cmd m.CreateFolderCommand, fn scenarioFunc) {
  120. Convey(desc+" "+url, func() {
  121. defer bus.ClearBusHandlers()
  122. sc := setupScenarioContext(url)
  123. sc.defaultHandler = Wrap(func(c *m.ReqContext) Response {
  124. sc.context = c
  125. sc.context.SignedInUser = &m.SignedInUser{OrgId: TestOrgID, UserId: TestUserID}
  126. return CreateFolder(c, cmd)
  127. })
  128. origNewFolderService := dashboards.NewFolderService
  129. mockFolderService(mock)
  130. sc.m.Post(routePattern, sc.defaultHandler)
  131. defer func() {
  132. dashboards.NewFolderService = origNewFolderService
  133. }()
  134. fn(sc)
  135. })
  136. }
  137. func callUpdateFolder(sc *scenarioContext) {
  138. sc.fakeReqWithParams("PUT", sc.url, map[string]string{}).exec()
  139. }
  140. func updateFolderScenario(desc string, url string, routePattern string, mock *fakeFolderService, cmd m.UpdateFolderCommand, fn scenarioFunc) {
  141. Convey(desc+" "+url, func() {
  142. defer bus.ClearBusHandlers()
  143. sc := setupScenarioContext(url)
  144. sc.defaultHandler = Wrap(func(c *m.ReqContext) Response {
  145. sc.context = c
  146. sc.context.SignedInUser = &m.SignedInUser{OrgId: TestOrgID, UserId: TestUserID}
  147. return UpdateFolder(c, cmd)
  148. })
  149. origNewFolderService := dashboards.NewFolderService
  150. mockFolderService(mock)
  151. sc.m.Put(routePattern, sc.defaultHandler)
  152. defer func() {
  153. dashboards.NewFolderService = origNewFolderService
  154. }()
  155. fn(sc)
  156. })
  157. }
  158. type fakeFolderService struct {
  159. GetFoldersResult []*m.Folder
  160. GetFoldersError error
  161. GetFolderByUIDResult *m.Folder
  162. GetFolderByUIDError error
  163. GetFolderByIDResult *m.Folder
  164. GetFolderByIDError error
  165. CreateFolderResult *m.Folder
  166. CreateFolderError error
  167. UpdateFolderResult *m.Folder
  168. UpdateFolderError error
  169. DeleteFolderResult *m.Folder
  170. DeleteFolderError error
  171. DeletedFolderUids []string
  172. }
  173. func (s *fakeFolderService) GetFolders(limit int) ([]*m.Folder, error) {
  174. return s.GetFoldersResult, s.GetFoldersError
  175. }
  176. func (s *fakeFolderService) GetFolderByID(id int64) (*m.Folder, error) {
  177. return s.GetFolderByIDResult, s.GetFolderByIDError
  178. }
  179. func (s *fakeFolderService) GetFolderByUID(uid string) (*m.Folder, error) {
  180. return s.GetFolderByUIDResult, s.GetFolderByUIDError
  181. }
  182. func (s *fakeFolderService) CreateFolder(cmd *m.CreateFolderCommand) error {
  183. cmd.Result = s.CreateFolderResult
  184. return s.CreateFolderError
  185. }
  186. func (s *fakeFolderService) UpdateFolder(existingUID string, cmd *m.UpdateFolderCommand) error {
  187. cmd.Result = s.UpdateFolderResult
  188. return s.UpdateFolderError
  189. }
  190. func (s *fakeFolderService) DeleteFolder(uid string) (*m.Folder, error) {
  191. s.DeletedFolderUids = append(s.DeletedFolderUids, uid)
  192. return s.DeleteFolderResult, s.DeleteFolderError
  193. }
  194. func mockFolderService(mock *fakeFolderService) {
  195. dashboards.NewFolderService = func(orgId int64, user *m.SignedInUser) dashboards.FolderService {
  196. return mock
  197. }
  198. }