file_reader_test.go 8.7 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337
  1. package dashboards
  2. import (
  3. "os"
  4. "path/filepath"
  5. "runtime"
  6. "testing"
  7. "time"
  8. "github.com/grafana/grafana/pkg/bus"
  9. "github.com/grafana/grafana/pkg/models"
  10. "github.com/grafana/grafana/pkg/services/dashboards"
  11. "github.com/grafana/grafana/pkg/log"
  12. . "github.com/smartystreets/goconvey/convey"
  13. )
  14. var (
  15. defaultDashboards = "testdata/test-dashboards/folder-one"
  16. brokenDashboards = "testdata/test-dashboards/broken-dashboards"
  17. oneDashboard = "testdata/test-dashboards/one-dashboard"
  18. containingId = "testdata/test-dashboards/containing-id"
  19. fakeService *fakeDashboardProvisioningService
  20. )
  21. func TestCreatingNewDashboardFileReader(t *testing.T) {
  22. Convey("creating new dashboard file reader", t, func() {
  23. cfg := &DashboardsAsConfig{
  24. Name: "Default",
  25. Type: "file",
  26. OrgId: 1,
  27. Folder: "",
  28. Options: map[string]interface{}{},
  29. }
  30. Convey("using path parameter", func() {
  31. cfg.Options["path"] = defaultDashboards
  32. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  33. So(err, ShouldBeNil)
  34. So(reader.Path, ShouldNotEqual, "")
  35. })
  36. Convey("using folder as options", func() {
  37. cfg.Options["folder"] = defaultDashboards
  38. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  39. So(err, ShouldBeNil)
  40. So(reader.Path, ShouldNotEqual, "")
  41. })
  42. Convey("using full path", func() {
  43. fullPath := "/var/lib/grafana/dashboards"
  44. if runtime.GOOS == "windows" {
  45. fullPath = `c:\var\lib\grafana`
  46. }
  47. cfg.Options["folder"] = fullPath
  48. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  49. So(err, ShouldBeNil)
  50. So(reader.Path, ShouldEqual, fullPath)
  51. So(filepath.IsAbs(reader.Path), ShouldBeTrue)
  52. })
  53. Convey("using relative path", func() {
  54. cfg.Options["folder"] = defaultDashboards
  55. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  56. So(err, ShouldBeNil)
  57. resolvedPath := reader.resolvePath(reader.Path)
  58. So(filepath.IsAbs(resolvedPath), ShouldBeTrue)
  59. })
  60. })
  61. }
  62. func TestDashboardFileReader(t *testing.T) {
  63. Convey("Dashboard file reader", t, func() {
  64. bus.ClearBusHandlers()
  65. origNewDashboardProvisioningService := dashboards.NewProvisioningService
  66. fakeService = mockDashboardProvisioningService()
  67. bus.AddHandler("test", mockGetDashboardQuery)
  68. logger := log.New("test.logger")
  69. Convey("Reading dashboards from disk", func() {
  70. cfg := &DashboardsAsConfig{
  71. Name: "Default",
  72. Type: "file",
  73. OrgId: 1,
  74. Folder: "",
  75. Options: map[string]interface{}{},
  76. }
  77. Convey("Can read default dashboard", func() {
  78. cfg.Options["path"] = defaultDashboards
  79. cfg.Folder = "Team A"
  80. reader, err := NewDashboardFileReader(cfg, logger)
  81. So(err, ShouldBeNil)
  82. err = reader.startWalkingDisk()
  83. So(err, ShouldBeNil)
  84. folders := 0
  85. dashboards := 0
  86. for _, i := range fakeService.inserted {
  87. if i.Dashboard.IsFolder {
  88. folders++
  89. } else {
  90. dashboards++
  91. }
  92. }
  93. So(folders, ShouldEqual, 1)
  94. So(dashboards, ShouldEqual, 2)
  95. })
  96. Convey("Can read default dashboard and replace old version in database", func() {
  97. cfg.Options["path"] = oneDashboard
  98. stat, _ := os.Stat(oneDashboard + "/dashboard1.json")
  99. fakeService.getDashboard = append(fakeService.getDashboard, &models.Dashboard{
  100. Updated: stat.ModTime().AddDate(0, 0, -1),
  101. Slug: "grafana",
  102. })
  103. reader, err := NewDashboardFileReader(cfg, logger)
  104. So(err, ShouldBeNil)
  105. err = reader.startWalkingDisk()
  106. So(err, ShouldBeNil)
  107. So(len(fakeService.inserted), ShouldEqual, 1)
  108. })
  109. Convey("Overrides id from dashboard.json files", func() {
  110. cfg.Options["path"] = containingId
  111. reader, err := NewDashboardFileReader(cfg, logger)
  112. So(err, ShouldBeNil)
  113. err = reader.startWalkingDisk()
  114. So(err, ShouldBeNil)
  115. So(len(fakeService.inserted), ShouldEqual, 1)
  116. })
  117. Convey("Invalid configuration should return error", func() {
  118. cfg := &DashboardsAsConfig{
  119. Name: "Default",
  120. Type: "file",
  121. OrgId: 1,
  122. Folder: "",
  123. }
  124. _, err := NewDashboardFileReader(cfg, logger)
  125. So(err, ShouldNotBeNil)
  126. })
  127. Convey("Broken dashboards should not cause error", func() {
  128. cfg.Options["path"] = brokenDashboards
  129. _, err := NewDashboardFileReader(cfg, logger)
  130. So(err, ShouldBeNil)
  131. })
  132. Convey("Two dashboard providers should be able to provisioned the same dashboard without uid", func() {
  133. cfg1 := &DashboardsAsConfig{Name: "1", Type: "file", OrgId: 1, Folder: "f1", Options: map[string]interface{}{"path": containingId}}
  134. cfg2 := &DashboardsAsConfig{Name: "2", Type: "file", OrgId: 1, Folder: "f2", Options: map[string]interface{}{"path": containingId}}
  135. reader1, err := NewDashboardFileReader(cfg1, logger)
  136. So(err, ShouldBeNil)
  137. err = reader1.startWalkingDisk()
  138. So(err, ShouldBeNil)
  139. reader2, err := NewDashboardFileReader(cfg2, logger)
  140. So(err, ShouldBeNil)
  141. err = reader2.startWalkingDisk()
  142. So(err, ShouldBeNil)
  143. var folderCount int
  144. var dashCount int
  145. for _, o := range fakeService.inserted {
  146. if o.Dashboard.IsFolder {
  147. folderCount++
  148. } else {
  149. dashCount++
  150. }
  151. }
  152. So(folderCount, ShouldEqual, 2)
  153. So(dashCount, ShouldEqual, 2)
  154. })
  155. })
  156. Convey("Should not create new folder if folder name is missing", func() {
  157. cfg := &DashboardsAsConfig{
  158. Name: "Default",
  159. Type: "file",
  160. OrgId: 1,
  161. Folder: "",
  162. Options: map[string]interface{}{
  163. "folder": defaultDashboards,
  164. },
  165. }
  166. _, err := getOrCreateFolderId(cfg, fakeService)
  167. So(err, ShouldEqual, ErrFolderNameMissing)
  168. })
  169. Convey("can get or Create dashboard folder", func() {
  170. cfg := &DashboardsAsConfig{
  171. Name: "Default",
  172. Type: "file",
  173. OrgId: 1,
  174. Folder: "TEAM A",
  175. Options: map[string]interface{}{
  176. "folder": defaultDashboards,
  177. },
  178. }
  179. folderId, err := getOrCreateFolderId(cfg, fakeService)
  180. So(err, ShouldBeNil)
  181. inserted := false
  182. for _, d := range fakeService.inserted {
  183. if d.Dashboard.IsFolder && d.Dashboard.Id == folderId {
  184. inserted = true
  185. }
  186. }
  187. So(len(fakeService.inserted), ShouldEqual, 1)
  188. So(inserted, ShouldBeTrue)
  189. })
  190. Convey("Walking the folder with dashboards", func() {
  191. noFiles := map[string]os.FileInfo{}
  192. Convey("should skip dirs that starts with .", func() {
  193. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: ".folder"}, nil)
  194. So(shouldSkip, ShouldEqual, filepath.SkipDir)
  195. })
  196. Convey("should keep walking if file is not .json", func() {
  197. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: "folder"}, nil)
  198. So(shouldSkip, ShouldBeNil)
  199. })
  200. })
  201. Reset(func() {
  202. dashboards.NewProvisioningService = origNewDashboardProvisioningService
  203. })
  204. })
  205. }
  206. type FakeFileInfo struct {
  207. isDirectory bool
  208. name string
  209. }
  210. func (ffi *FakeFileInfo) IsDir() bool {
  211. return ffi.isDirectory
  212. }
  213. func (ffi FakeFileInfo) Size() int64 {
  214. return 1
  215. }
  216. func (ffi FakeFileInfo) Mode() os.FileMode {
  217. return 0777
  218. }
  219. func (ffi FakeFileInfo) Name() string {
  220. return ffi.name
  221. }
  222. func (ffi FakeFileInfo) ModTime() time.Time {
  223. return time.Time{}
  224. }
  225. func (ffi FakeFileInfo) Sys() interface{} {
  226. return nil
  227. }
  228. func mockDashboardProvisioningService() *fakeDashboardProvisioningService {
  229. mock := fakeDashboardProvisioningService{
  230. provisioned: map[string][]*models.DashboardProvisioning{},
  231. }
  232. dashboards.NewProvisioningService = func() dashboards.DashboardProvisioningService {
  233. return &mock
  234. }
  235. return &mock
  236. }
  237. type fakeDashboardProvisioningService struct {
  238. inserted []*dashboards.SaveDashboardDTO
  239. provisioned map[string][]*models.DashboardProvisioning
  240. getDashboard []*models.Dashboard
  241. }
  242. func (s *fakeDashboardProvisioningService) GetProvisionedDashboardData(name string) ([]*models.DashboardProvisioning, error) {
  243. if _, ok := s.provisioned[name]; !ok {
  244. s.provisioned[name] = []*models.DashboardProvisioning{}
  245. }
  246. return s.provisioned[name], nil
  247. }
  248. func (s *fakeDashboardProvisioningService) SaveProvisionedDashboard(dto *dashboards.SaveDashboardDTO, provisioning *models.DashboardProvisioning) (*models.Dashboard, error) {
  249. s.inserted = append(s.inserted, dto)
  250. if _, ok := s.provisioned[provisioning.Name]; !ok {
  251. s.provisioned[provisioning.Name] = []*models.DashboardProvisioning{}
  252. }
  253. s.provisioned[provisioning.Name] = append(s.provisioned[provisioning.Name], provisioning)
  254. return dto.Dashboard, nil
  255. }
  256. func (s *fakeDashboardProvisioningService) SaveFolderForProvisionedDashboards(dto *dashboards.SaveDashboardDTO) (*models.Dashboard, error) {
  257. s.inserted = append(s.inserted, dto)
  258. return dto.Dashboard, nil
  259. }
  260. func mockGetDashboardQuery(cmd *models.GetDashboardQuery) error {
  261. for _, d := range fakeService.getDashboard {
  262. if d.Slug == cmd.Slug {
  263. cmd.Result = d
  264. return nil
  265. }
  266. }
  267. return models.ErrDashboardNotFound
  268. }