dashboard_acl_test.go 7.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217
  1. package sqlstore
  2. import (
  3. "testing"
  4. . "github.com/smartystreets/goconvey/convey"
  5. m "github.com/grafana/grafana/pkg/models"
  6. )
  7. func TestDashboardAclDataAccess(t *testing.T) {
  8. Convey("Testing DB", t, func() {
  9. InitTestDB(t)
  10. Convey("Given a dashboard folder and a user", func() {
  11. currentUser := createUser("viewer", "Viewer", false)
  12. savedFolder := insertTestDashboard("1 test dash folder", 1, 0, true, "prod", "webapp")
  13. childDash := insertTestDashboard("2 test dash", 1, savedFolder.Id, false, "prod", "webapp")
  14. Convey("When adding dashboard permission with userId and teamId set to 0", func() {
  15. err := testHelperUpdateDashboardAcl(savedFolder.Id, m.DashboardAcl{
  16. OrgId: 1,
  17. DashboardId: savedFolder.Id,
  18. Permission: m.PERMISSION_EDIT,
  19. })
  20. So(err, ShouldEqual, m.ErrDashboardAclInfoMissing)
  21. })
  22. Convey("Given dashboard folder with default permissions", func() {
  23. Convey("When reading dashboard acl should include acl for parent folder", func() {
  24. query := m.GetDashboardAclInfoListQuery{DashboardId: childDash.Id, OrgId: 1}
  25. err := GetDashboardAclInfoList(&query)
  26. So(err, ShouldBeNil)
  27. So(len(query.Result), ShouldEqual, 2)
  28. defaultPermissionsId := -1
  29. So(query.Result[0].DashboardId, ShouldEqual, defaultPermissionsId)
  30. So(*query.Result[0].Role, ShouldEqual, m.ROLE_VIEWER)
  31. So(query.Result[1].DashboardId, ShouldEqual, defaultPermissionsId)
  32. So(*query.Result[1].Role, ShouldEqual, m.ROLE_EDITOR)
  33. })
  34. })
  35. Convey("Given dashboard folder with removed default permissions", func() {
  36. err := UpdateDashboardAcl(&m.UpdateDashboardAclCommand{
  37. DashboardId: savedFolder.Id,
  38. Items: []*m.DashboardAcl{},
  39. })
  40. So(err, ShouldBeNil)
  41. Convey("When reading dashboard acl should return no acl items", func() {
  42. query := m.GetDashboardAclInfoListQuery{DashboardId: childDash.Id, OrgId: 1}
  43. err := GetDashboardAclInfoList(&query)
  44. So(err, ShouldBeNil)
  45. So(len(query.Result), ShouldEqual, 0)
  46. })
  47. })
  48. Convey("Given dashboard folder permission", func() {
  49. err := testHelperUpdateDashboardAcl(savedFolder.Id, m.DashboardAcl{
  50. OrgId: 1,
  51. UserId: currentUser.Id,
  52. DashboardId: savedFolder.Id,
  53. Permission: m.PERMISSION_EDIT,
  54. })
  55. So(err, ShouldBeNil)
  56. Convey("When reading dashboard acl should include acl for parent folder", func() {
  57. query := m.GetDashboardAclInfoListQuery{DashboardId: childDash.Id, OrgId: 1}
  58. err := GetDashboardAclInfoList(&query)
  59. So(err, ShouldBeNil)
  60. So(len(query.Result), ShouldEqual, 1)
  61. So(query.Result[0].DashboardId, ShouldEqual, savedFolder.Id)
  62. })
  63. Convey("Given child dashboard permission", func() {
  64. err := testHelperUpdateDashboardAcl(childDash.Id, m.DashboardAcl{
  65. OrgId: 1,
  66. UserId: currentUser.Id,
  67. DashboardId: childDash.Id,
  68. Permission: m.PERMISSION_EDIT,
  69. })
  70. So(err, ShouldBeNil)
  71. Convey("When reading dashboard acl should include acl for parent folder and child", func() {
  72. query := m.GetDashboardAclInfoListQuery{OrgId: 1, DashboardId: childDash.Id}
  73. err := GetDashboardAclInfoList(&query)
  74. So(err, ShouldBeNil)
  75. So(len(query.Result), ShouldEqual, 2)
  76. So(query.Result[0].DashboardId, ShouldEqual, savedFolder.Id)
  77. So(query.Result[1].DashboardId, ShouldEqual, childDash.Id)
  78. })
  79. })
  80. })
  81. Convey("Given child dashboard permission in folder with no permissions", func() {
  82. err := testHelperUpdateDashboardAcl(childDash.Id, m.DashboardAcl{
  83. OrgId: 1,
  84. UserId: currentUser.Id,
  85. DashboardId: childDash.Id,
  86. Permission: m.PERMISSION_EDIT,
  87. })
  88. So(err, ShouldBeNil)
  89. Convey("When reading dashboard acl should include default acl for parent folder and the child acl", func() {
  90. query := m.GetDashboardAclInfoListQuery{OrgId: 1, DashboardId: childDash.Id}
  91. err := GetDashboardAclInfoList(&query)
  92. So(err, ShouldBeNil)
  93. defaultPermissionsId := -1
  94. So(len(query.Result), ShouldEqual, 3)
  95. So(query.Result[0].DashboardId, ShouldEqual, defaultPermissionsId)
  96. So(*query.Result[0].Role, ShouldEqual, m.ROLE_VIEWER)
  97. So(query.Result[1].DashboardId, ShouldEqual, defaultPermissionsId)
  98. So(*query.Result[1].Role, ShouldEqual, m.ROLE_EDITOR)
  99. So(query.Result[2].DashboardId, ShouldEqual, childDash.Id)
  100. })
  101. })
  102. Convey("Should be able to add dashboard permission", func() {
  103. err := testHelperUpdateDashboardAcl(savedFolder.Id, m.DashboardAcl{
  104. OrgId: 1,
  105. UserId: currentUser.Id,
  106. DashboardId: savedFolder.Id,
  107. Permission: m.PERMISSION_EDIT,
  108. })
  109. q1 := &m.GetDashboardAclInfoListQuery{DashboardId: savedFolder.Id, OrgId: 1}
  110. err = GetDashboardAclInfoList(q1)
  111. So(err, ShouldBeNil)
  112. So(q1.Result[0].DashboardId, ShouldEqual, savedFolder.Id)
  113. So(q1.Result[0].Permission, ShouldEqual, m.PERMISSION_EDIT)
  114. So(q1.Result[0].PermissionName, ShouldEqual, "Edit")
  115. So(q1.Result[0].UserId, ShouldEqual, currentUser.Id)
  116. So(q1.Result[0].UserLogin, ShouldEqual, currentUser.Login)
  117. So(q1.Result[0].UserEmail, ShouldEqual, currentUser.Email)
  118. Convey("Should be able to delete an existing permission", func() {
  119. err := testHelperUpdateDashboardAcl(savedFolder.Id)
  120. So(err, ShouldBeNil)
  121. q3 := &m.GetDashboardAclInfoListQuery{DashboardId: savedFolder.Id, OrgId: 1}
  122. err = GetDashboardAclInfoList(q3)
  123. So(err, ShouldBeNil)
  124. So(len(q3.Result), ShouldEqual, 0)
  125. })
  126. })
  127. Convey("Given a team", func() {
  128. group1 := m.CreateTeamCommand{Name: "group1 name", OrgId: 1}
  129. err := CreateTeam(&group1)
  130. So(err, ShouldBeNil)
  131. Convey("Should be able to add a user permission for a team", func() {
  132. err := testHelperUpdateDashboardAcl(savedFolder.Id, m.DashboardAcl{
  133. OrgId: 1,
  134. TeamId: group1.Result.Id,
  135. DashboardId: savedFolder.Id,
  136. Permission: m.PERMISSION_EDIT,
  137. })
  138. So(err, ShouldBeNil)
  139. q1 := &m.GetDashboardAclInfoListQuery{DashboardId: savedFolder.Id, OrgId: 1}
  140. err = GetDashboardAclInfoList(q1)
  141. So(err, ShouldBeNil)
  142. So(q1.Result[0].DashboardId, ShouldEqual, savedFolder.Id)
  143. So(q1.Result[0].Permission, ShouldEqual, m.PERMISSION_EDIT)
  144. So(q1.Result[0].TeamId, ShouldEqual, group1.Result.Id)
  145. })
  146. Convey("Should be able to update an existing permission for a team", func() {
  147. err := testHelperUpdateDashboardAcl(savedFolder.Id, m.DashboardAcl{
  148. OrgId: 1,
  149. TeamId: group1.Result.Id,
  150. DashboardId: savedFolder.Id,
  151. Permission: m.PERMISSION_ADMIN,
  152. })
  153. So(err, ShouldBeNil)
  154. q3 := &m.GetDashboardAclInfoListQuery{DashboardId: savedFolder.Id, OrgId: 1}
  155. err = GetDashboardAclInfoList(q3)
  156. So(err, ShouldBeNil)
  157. So(len(q3.Result), ShouldEqual, 1)
  158. So(q3.Result[0].DashboardId, ShouldEqual, savedFolder.Id)
  159. So(q3.Result[0].Permission, ShouldEqual, m.PERMISSION_ADMIN)
  160. So(q3.Result[0].TeamId, ShouldEqual, group1.Result.Id)
  161. })
  162. })
  163. })
  164. Convey("Given a root folder", func() {
  165. var rootFolderId int64 = 0
  166. Convey("When reading dashboard acl should return default permissions", func() {
  167. query := m.GetDashboardAclInfoListQuery{DashboardId: rootFolderId, OrgId: 1}
  168. err := GetDashboardAclInfoList(&query)
  169. So(err, ShouldBeNil)
  170. So(len(query.Result), ShouldEqual, 2)
  171. defaultPermissionsId := -1
  172. So(query.Result[0].DashboardId, ShouldEqual, defaultPermissionsId)
  173. So(*query.Result[0].Role, ShouldEqual, m.ROLE_VIEWER)
  174. So(query.Result[1].DashboardId, ShouldEqual, defaultPermissionsId)
  175. So(*query.Result[1].Role, ShouldEqual, m.ROLE_EDITOR)
  176. })
  177. })
  178. })
  179. }