config_reader_test.go 7.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241
  1. package datasources
  2. import (
  3. "testing"
  4. "github.com/grafana/grafana/pkg/bus"
  5. "github.com/grafana/grafana/pkg/log"
  6. "github.com/grafana/grafana/pkg/models"
  7. . "github.com/smartystreets/goconvey/convey"
  8. )
  9. var (
  10. logger log.Logger = log.New("fake.log")
  11. oneDatasourcesConfig string = ""
  12. twoDatasourcesConfig string = "./test-configs/two-datasources"
  13. twoDatasourcesConfigPurgeOthers string = "./test-configs/insert-two-delete-two"
  14. doubleDatasourcesConfig string = "./test-configs/double-default"
  15. allProperties string = "./test-configs/all-properties"
  16. versionZero string = "./test-configs/version-0"
  17. brokenYaml string = "./test-configs/broken-yaml"
  18. fakeRepo *fakeRepository
  19. )
  20. func TestDatasourceAsConfig(t *testing.T) {
  21. Convey("Testing datasource as configuration", t, func() {
  22. fakeRepo = &fakeRepository{}
  23. bus.ClearBusHandlers()
  24. bus.AddHandler("test", mockDelete)
  25. bus.AddHandler("test", mockInsert)
  26. bus.AddHandler("test", mockUpdate)
  27. bus.AddHandler("test", mockGet)
  28. bus.AddHandler("test", mockGetAll)
  29. Convey("One configured datasource", func() {
  30. Convey("no datasource in database", func() {
  31. dc := newDatasourceProvisioner(logger)
  32. err := dc.applyChanges(twoDatasourcesConfig)
  33. if err != nil {
  34. t.Fatalf("applyChanges return an error %v", err)
  35. }
  36. So(len(fakeRepo.deleted), ShouldEqual, 0)
  37. So(len(fakeRepo.inserted), ShouldEqual, 2)
  38. So(len(fakeRepo.updated), ShouldEqual, 0)
  39. })
  40. Convey("One datasource in database with same name", func() {
  41. fakeRepo.loadAll = []*models.DataSource{
  42. {Name: "Graphite", OrgId: 1, Id: 1},
  43. }
  44. Convey("should update one datasource", func() {
  45. dc := newDatasourceProvisioner(logger)
  46. err := dc.applyChanges(twoDatasourcesConfig)
  47. if err != nil {
  48. t.Fatalf("applyChanges return an error %v", err)
  49. }
  50. So(len(fakeRepo.deleted), ShouldEqual, 0)
  51. So(len(fakeRepo.inserted), ShouldEqual, 1)
  52. So(len(fakeRepo.updated), ShouldEqual, 1)
  53. })
  54. })
  55. Convey("Two datasources with is_default", func() {
  56. dc := newDatasourceProvisioner(logger)
  57. err := dc.applyChanges(doubleDatasourcesConfig)
  58. Convey("should raise error", func() {
  59. So(err, ShouldEqual, ErrInvalidConfigToManyDefault)
  60. })
  61. })
  62. })
  63. Convey("Two configured datasource and purge others ", func() {
  64. Convey("two other datasources in database", func() {
  65. fakeRepo.loadAll = []*models.DataSource{
  66. {Name: "old-graphite", OrgId: 1, Id: 1},
  67. {Name: "old-graphite2", OrgId: 1, Id: 2},
  68. }
  69. Convey("should have two new datasources", func() {
  70. dc := newDatasourceProvisioner(logger)
  71. err := dc.applyChanges(twoDatasourcesConfigPurgeOthers)
  72. if err != nil {
  73. t.Fatalf("applyChanges return an error %v", err)
  74. }
  75. So(len(fakeRepo.deleted), ShouldEqual, 2)
  76. So(len(fakeRepo.inserted), ShouldEqual, 2)
  77. So(len(fakeRepo.updated), ShouldEqual, 0)
  78. })
  79. })
  80. })
  81. Convey("Two configured datasource and purge others = false", func() {
  82. Convey("two other datasources in database", func() {
  83. fakeRepo.loadAll = []*models.DataSource{
  84. {Name: "Graphite", OrgId: 1, Id: 1},
  85. {Name: "old-graphite2", OrgId: 1, Id: 2},
  86. }
  87. Convey("should have two new datasources", func() {
  88. dc := newDatasourceProvisioner(logger)
  89. err := dc.applyChanges(twoDatasourcesConfig)
  90. if err != nil {
  91. t.Fatalf("applyChanges return an error %v", err)
  92. }
  93. So(len(fakeRepo.deleted), ShouldEqual, 0)
  94. So(len(fakeRepo.inserted), ShouldEqual, 1)
  95. So(len(fakeRepo.updated), ShouldEqual, 1)
  96. })
  97. })
  98. })
  99. Convey("broken yaml should return error", func() {
  100. reader := &configReader{}
  101. _, err := reader.readConfig(brokenYaml)
  102. So(err, ShouldNotBeNil)
  103. })
  104. Convey("skip invalid directory", func() {
  105. cfgProvifer := &configReader{log: log.New("test logger")}
  106. cfg, err := cfgProvifer.readConfig("./invalid-directory")
  107. if err != nil {
  108. t.Fatalf("readConfig return an error %v", err)
  109. }
  110. So(len(cfg), ShouldEqual, 0)
  111. })
  112. Convey("can read all properties from version 1", func() {
  113. cfgProvifer := &configReader{log: log.New("test logger")}
  114. cfg, err := cfgProvifer.readConfig(allProperties)
  115. if err != nil {
  116. t.Fatalf("readConfig return an error %v", err)
  117. }
  118. So(len(cfg), ShouldEqual, 2)
  119. dsCfg := cfg[0]
  120. So(dsCfg.ApiVersion, ShouldEqual, 1)
  121. validateDatasource(dsCfg)
  122. validateDeleteDatasources(dsCfg)
  123. })
  124. Convey("can read all properties from version 0", func() {
  125. cfgProvifer := &configReader{log: log.New("test logger")}
  126. cfg, err := cfgProvifer.readConfig(versionZero)
  127. if err != nil {
  128. t.Fatalf("readConfig return an error %v", err)
  129. }
  130. So(len(cfg), ShouldEqual, 1)
  131. dsCfg := cfg[0]
  132. So(dsCfg.ApiVersion, ShouldEqual, 0)
  133. validateDatasource(dsCfg)
  134. validateDeleteDatasources(dsCfg)
  135. })
  136. })
  137. }
  138. func validateDeleteDatasources(dsCfg *DatasourcesAsConfig) {
  139. So(len(dsCfg.DeleteDatasources), ShouldEqual, 1)
  140. deleteDs := dsCfg.DeleteDatasources[0]
  141. So(deleteDs.Name, ShouldEqual, "old-graphite3")
  142. So(deleteDs.OrgId, ShouldEqual, 2)
  143. }
  144. func validateDatasource(dsCfg *DatasourcesAsConfig) {
  145. ds := dsCfg.Datasources[0]
  146. So(ds.Name, ShouldEqual, "name")
  147. So(ds.Type, ShouldEqual, "type")
  148. So(ds.Access, ShouldEqual, models.DS_ACCESS_PROXY)
  149. So(ds.OrgId, ShouldEqual, 2)
  150. So(ds.Url, ShouldEqual, "url")
  151. So(ds.User, ShouldEqual, "user")
  152. So(ds.Password, ShouldEqual, "password")
  153. So(ds.Database, ShouldEqual, "database")
  154. So(ds.BasicAuth, ShouldBeTrue)
  155. So(ds.BasicAuthUser, ShouldEqual, "basic_auth_user")
  156. So(ds.BasicAuthPassword, ShouldEqual, "basic_auth_password")
  157. So(ds.WithCredentials, ShouldBeTrue)
  158. So(ds.IsDefault, ShouldBeTrue)
  159. So(ds.Editable, ShouldBeTrue)
  160. So(ds.Version, ShouldEqual, 10)
  161. So(len(ds.JsonData), ShouldBeGreaterThan, 2)
  162. So(ds.JsonData["graphiteVersion"], ShouldEqual, "1.1")
  163. So(ds.JsonData["tlsAuth"], ShouldEqual, true)
  164. So(ds.JsonData["tlsAuthWithCACert"], ShouldEqual, true)
  165. So(len(ds.SecureJsonData), ShouldBeGreaterThan, 2)
  166. So(ds.SecureJsonData["tlsCACert"], ShouldEqual, "MjNOcW9RdkbUDHZmpco2HCYzVq9dE+i6Yi+gmUJotq5CDA==")
  167. So(ds.SecureJsonData["tlsClientCert"], ShouldEqual, "ckN0dGlyMXN503YNfjTcf9CV+GGQneN+xmAclQ==")
  168. So(ds.SecureJsonData["tlsClientKey"], ShouldEqual, "ZkN4aG1aNkja/gKAB1wlnKFIsy2SRDq4slrM0A==")
  169. }
  170. type fakeRepository struct {
  171. inserted []*models.AddDataSourceCommand
  172. deleted []*models.DeleteDataSourceByNameCommand
  173. updated []*models.UpdateDataSourceCommand
  174. loadAll []*models.DataSource
  175. }
  176. func mockDelete(cmd *models.DeleteDataSourceByNameCommand) error {
  177. fakeRepo.deleted = append(fakeRepo.deleted, cmd)
  178. return nil
  179. }
  180. func mockUpdate(cmd *models.UpdateDataSourceCommand) error {
  181. fakeRepo.updated = append(fakeRepo.updated, cmd)
  182. return nil
  183. }
  184. func mockInsert(cmd *models.AddDataSourceCommand) error {
  185. fakeRepo.inserted = append(fakeRepo.inserted, cmd)
  186. return nil
  187. }
  188. func mockGetAll(cmd *models.GetAllDataSourcesQuery) error {
  189. cmd.Result = fakeRepo.loadAll
  190. return nil
  191. }
  192. func mockGet(cmd *models.GetDataSourceByNameQuery) error {
  193. for _, v := range fakeRepo.loadAll {
  194. if cmd.Name == v.Name && cmd.OrgId == v.OrgId {
  195. cmd.Result = v
  196. return nil
  197. }
  198. }
  199. return models.ErrDataSourceNotFound
  200. }