file_reader_test.go 6.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270
  1. package dashboards
  2. import (
  3. "os"
  4. "path/filepath"
  5. "testing"
  6. "time"
  7. "github.com/grafana/grafana/pkg/bus"
  8. "github.com/grafana/grafana/pkg/models"
  9. "github.com/grafana/grafana/pkg/services/dashboards"
  10. "github.com/grafana/grafana/pkg/log"
  11. . "github.com/smartystreets/goconvey/convey"
  12. )
  13. var (
  14. defaultDashboards = "./test-dashboards/folder-one"
  15. brokenDashboards = "./test-dashboards/broken-dashboards"
  16. oneDashboard = "./test-dashboards/one-dashboard"
  17. containingId = "./test-dashboards/containing-id"
  18. fakeService *fakeDashboardProvisioningService
  19. )
  20. func TestDashboardFileReader(t *testing.T) {
  21. Convey("Dashboard file reader", t, func() {
  22. bus.ClearBusHandlers()
  23. origNewDashboardProvisioningService := dashboards.NewProvisioningService
  24. fakeService = mockDashboardProvisioningService()
  25. bus.AddHandler("test", mockGetDashboardQuery)
  26. logger := log.New("test.logger")
  27. Convey("Reading dashboards from disk", func() {
  28. cfg := &DashboardsAsConfig{
  29. Name: "Default",
  30. Type: "file",
  31. OrgId: 1,
  32. Folder: "",
  33. Options: map[string]interface{}{},
  34. }
  35. Convey("Can read default dashboard", func() {
  36. cfg.Options["path"] = defaultDashboards
  37. cfg.Folder = "Team A"
  38. reader, err := NewDashboardFileReader(cfg, logger)
  39. So(err, ShouldBeNil)
  40. err = reader.startWalkingDisk()
  41. So(err, ShouldBeNil)
  42. folders := 0
  43. dashboards := 0
  44. for _, i := range fakeService.inserted {
  45. if i.Dashboard.IsFolder {
  46. folders++
  47. } else {
  48. dashboards++
  49. }
  50. }
  51. So(folders, ShouldEqual, 1)
  52. So(dashboards, ShouldEqual, 2)
  53. })
  54. Convey("Can read default dashboard and replace old version in database", func() {
  55. cfg.Options["path"] = oneDashboard
  56. stat, _ := os.Stat(oneDashboard + "/dashboard1.json")
  57. fakeService.getDashboard = append(fakeService.getDashboard, &models.Dashboard{
  58. Updated: stat.ModTime().AddDate(0, 0, -1),
  59. Slug: "grafana",
  60. })
  61. reader, err := NewDashboardFileReader(cfg, logger)
  62. So(err, ShouldBeNil)
  63. err = reader.startWalkingDisk()
  64. So(err, ShouldBeNil)
  65. So(len(fakeService.inserted), ShouldEqual, 1)
  66. })
  67. Convey("Overrides id from dashboard.json files", func() {
  68. cfg.Options["path"] = containingId
  69. reader, err := NewDashboardFileReader(cfg, logger)
  70. So(err, ShouldBeNil)
  71. err = reader.startWalkingDisk()
  72. So(err, ShouldBeNil)
  73. So(len(fakeService.inserted), ShouldEqual, 1)
  74. })
  75. Convey("Invalid configuration should return error", func() {
  76. cfg := &DashboardsAsConfig{
  77. Name: "Default",
  78. Type: "file",
  79. OrgId: 1,
  80. Folder: "",
  81. }
  82. _, err := NewDashboardFileReader(cfg, logger)
  83. So(err, ShouldNotBeNil)
  84. })
  85. Convey("Broken dashboards should not cause error", func() {
  86. cfg.Options["path"] = brokenDashboards
  87. _, err := NewDashboardFileReader(cfg, logger)
  88. So(err, ShouldBeNil)
  89. })
  90. })
  91. Convey("Should not create new folder if folder name is missing", func() {
  92. cfg := &DashboardsAsConfig{
  93. Name: "Default",
  94. Type: "file",
  95. OrgId: 1,
  96. Folder: "",
  97. Options: map[string]interface{}{
  98. "folder": defaultDashboards,
  99. },
  100. }
  101. _, err := getOrCreateFolderId(cfg, fakeService)
  102. So(err, ShouldEqual, ErrFolderNameMissing)
  103. })
  104. Convey("can get or Create dashboard folder", func() {
  105. cfg := &DashboardsAsConfig{
  106. Name: "Default",
  107. Type: "file",
  108. OrgId: 1,
  109. Folder: "TEAM A",
  110. Options: map[string]interface{}{
  111. "folder": defaultDashboards,
  112. },
  113. }
  114. folderId, err := getOrCreateFolderId(cfg, fakeService)
  115. So(err, ShouldBeNil)
  116. inserted := false
  117. for _, d := range fakeService.inserted {
  118. if d.Dashboard.IsFolder && d.Dashboard.Id == folderId {
  119. inserted = true
  120. }
  121. }
  122. So(len(fakeService.inserted), ShouldEqual, 1)
  123. So(inserted, ShouldBeTrue)
  124. })
  125. Convey("Walking the folder with dashboards", func() {
  126. noFiles := map[string]os.FileInfo{}
  127. Convey("should skip dirs that starts with .", func() {
  128. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: ".folder"}, nil)
  129. So(shouldSkip, ShouldEqual, filepath.SkipDir)
  130. })
  131. Convey("should keep walking if file is not .json", func() {
  132. shouldSkip := createWalkFn(noFiles)("path", &FakeFileInfo{isDirectory: true, name: "folder"}, nil)
  133. So(shouldSkip, ShouldBeNil)
  134. })
  135. })
  136. Convey("Can use bpth path and folder as dashboard path", func() {
  137. cfg := &DashboardsAsConfig{
  138. Name: "Default",
  139. Type: "file",
  140. OrgId: 1,
  141. Folder: "",
  142. Options: map[string]interface{}{},
  143. }
  144. Convey("using path parameter", func() {
  145. cfg.Options["path"] = defaultDashboards
  146. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  147. So(err, ShouldBeNil)
  148. So(reader.Path, ShouldEqual, defaultDashboards)
  149. })
  150. Convey("using folder as options", func() {
  151. cfg.Options["folder"] = defaultDashboards
  152. reader, err := NewDashboardFileReader(cfg, log.New("test-logger"))
  153. So(err, ShouldBeNil)
  154. So(reader.Path, ShouldEqual, defaultDashboards)
  155. })
  156. })
  157. Reset(func() {
  158. dashboards.NewProvisioningService = origNewDashboardProvisioningService
  159. })
  160. })
  161. }
  162. type FakeFileInfo struct {
  163. isDirectory bool
  164. name string
  165. }
  166. func (ffi *FakeFileInfo) IsDir() bool {
  167. return ffi.isDirectory
  168. }
  169. func (ffi FakeFileInfo) Size() int64 {
  170. return 1
  171. }
  172. func (ffi FakeFileInfo) Mode() os.FileMode {
  173. return 0777
  174. }
  175. func (ffi FakeFileInfo) Name() string {
  176. return ffi.name
  177. }
  178. func (ffi FakeFileInfo) ModTime() time.Time {
  179. return time.Time{}
  180. }
  181. func (ffi FakeFileInfo) Sys() interface{} {
  182. return nil
  183. }
  184. func mockDashboardProvisioningService() *fakeDashboardProvisioningService {
  185. mock := fakeDashboardProvisioningService{}
  186. dashboards.NewProvisioningService = func() dashboards.DashboardProvisioningService {
  187. return &mock
  188. }
  189. return &mock
  190. }
  191. type fakeDashboardProvisioningService struct {
  192. inserted []*dashboards.SaveDashboardDTO
  193. provisioned []*models.DashboardProvisioning
  194. getDashboard []*models.Dashboard
  195. }
  196. func (s *fakeDashboardProvisioningService) GetProvisionedDashboardData(name string) ([]*models.DashboardProvisioning, error) {
  197. return s.provisioned, nil
  198. }
  199. func (s *fakeDashboardProvisioningService) SaveProvisionedDashboard(dto *dashboards.SaveDashboardDTO, provisioning *models.DashboardProvisioning) (*models.Dashboard, error) {
  200. s.inserted = append(s.inserted, dto)
  201. s.provisioned = append(s.provisioned, provisioning)
  202. return dto.Dashboard, nil
  203. }
  204. func (s *fakeDashboardProvisioningService) SaveFolderForProvisionedDashboards(dto *dashboards.SaveDashboardDTO) (*models.Dashboard, error) {
  205. s.inserted = append(s.inserted, dto)
  206. return dto.Dashboard, nil
  207. }
  208. func mockGetDashboardQuery(cmd *models.GetDashboardQuery) error {
  209. for _, d := range fakeService.getDashboard {
  210. if d.Slug == cmd.Slug {
  211. cmd.Result = d
  212. return nil
  213. }
  214. }
  215. return models.ErrDashboardNotFound
  216. }